From 0cdafc809918e462cded87b595b65f255041554d Mon Sep 17 00:00:00 2001 From: MadanKumarGovindaswamy Date: Thu, 22 Feb 2024 13:51:24 +0530 Subject: [PATCH 01/27] Update Button.module.scss --- packages/terra-button/src/Button.module.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/terra-button/src/Button.module.scss b/packages/terra-button/src/Button.module.scss index d7e1bc9b9c9..6bfd9cddc93 100644 --- a/packages/terra-button/src/Button.module.scss +++ b/packages/terra-button/src/Button.module.scss @@ -39,7 +39,7 @@ font-size: var(--terra-button-font-size, 1rem); justify-content: center; line-height: var(--terra-button-line-height, 1.429); - margin: 0; /* Reset margin for Safari. Safari defaults to 2px. */ + margin: 2px; /* Reset margin for Safari. Safari defaults to 2px. */ max-width: 100%; /* Need to help with overflow-wrap */ min-height: var(--terra-button-min-height, 2.14285rem); outline: none; From 7cfe7b6904dde02cf2a35396c5623bfaae125c71 Mon Sep 17 00:00:00 2001 From: MadanKumarGovindaswamy Date: Thu, 22 Feb 2024 15:12:06 +0530 Subject: [PATCH 02/27] Update: failed wdio --- packages/terra-button/CHANGELOG.md | 3 ++ .../terra-button/tests/wdio/button-spec.js | 8 ++++ .../test/button/ButtonInsideTable.test.jsx | 45 ++++++++++++++++++ .../closed_programmatic_toggle.png | Bin 6890 -> 6971 bytes ...atically_toggles_toggle-section-header.png | Bin 51179 -> 51256 bytes .../closed_programmatic_toggle.png | Bin 5929 -> 5967 bytes ...atically_toggles_toggle-section-header.png | Bin 42496 -> 42559 bytes .../closed_programmatic_toggle.png | Bin 7031 -> 7083 bytes ...atically_toggles_toggle-section-header.png | Bin 52356 -> 52412 bytes 9 files changed, 56 insertions(+) create mode 100644 packages/terra-core-docs/src/terra-dev-site/test/button/ButtonInsideTable.test.jsx diff --git a/packages/terra-button/CHANGELOG.md b/packages/terra-button/CHANGELOG.md index f2741291ba9..0e82cf99196 100644 --- a/packages/terra-button/CHANGELOG.md +++ b/packages/terra-button/CHANGELOG.md @@ -2,6 +2,9 @@ ## Unreleased +* Changed + * Updated default margin value for terra-button. + ## 3.74.0 - (February 15, 2024) * Changed diff --git a/packages/terra-button/tests/wdio/button-spec.js b/packages/terra-button/tests/wdio/button-spec.js index 9425e474bad..e3152b8f807 100644 --- a/packages/terra-button/tests/wdio/button-spec.js +++ b/packages/terra-button/tests/wdio/button-spec.js @@ -263,4 +263,12 @@ Terra.describeViewports('Button', ['tiny'], () => { Terra.validates.element('selected-button'); }); }); + + describe('Focusable button with in terra-table', () => { + it('displays focusable button within terra-table', () => { + browser.url('/raw/tests/cerner-terra-core-docs/button/button-inside-table'); + browser.keys(['Tab', 'Tab']); + Terra.validates.element('button within table', { selector: '#root' }); + }); + }); }); diff --git a/packages/terra-core-docs/src/terra-dev-site/test/button/ButtonInsideTable.test.jsx b/packages/terra-core-docs/src/terra-dev-site/test/button/ButtonInsideTable.test.jsx new file mode 100644 index 00000000000..c85dd51e928 --- /dev/null +++ b/packages/terra-core-docs/src/terra-dev-site/test/button/ButtonInsideTable.test.jsx @@ -0,0 +1,45 @@ +import React from 'react'; +import Button from 'terra-button'; +import Table from 'terra-table'; + +const buttonCell =