From 8da9d9f846afaceb1de08abb73c2634422cf1a3d Mon Sep 17 00:00:00 2001 From: Supreeth Date: Tue, 28 Feb 2023 01:40:51 +0530 Subject: [PATCH] [Terra-Button-Group] Button group A11y Updates (#3731) * Button group A11y Updates * Added JEst and WDIO test * jest snapshot update * fixed terra-button A11y issue of not hounoring A11ylabel of icon when provided * Updated change logs * A11y Guide Updated * typo * to fix WDIO focus missmatch issue * increased timer * increased timer * Fix WDiO --------- Co-authored-by: SM051274 Co-authored-by: saket2403 --- packages/terra-action-header/CHANGELOG.md | 3 + .../__snapshots__/ActionHeader.test.jsx.snap | 17 -- packages/terra-alert/CHANGELOG.md | 3 + .../jest/__snapshots__/Alert.test.jsx.snap | 8 - packages/terra-button-group/CHANGELOG.md | 6 + .../terra-button-group/src/ButtonGroup.jsx | 52 ++++- .../src/ButtonGroupButton.jsx | 3 +- .../tests/jest/ButtonGroup.test.jsx | 22 ++ .../__snapshots__/ButtonGroup.test.jsx.snap | 106 ++++++++- .../ButtonGroupButton.test.jsx.snap | 19 +- .../button-group-spec/Button-1_focused.png | Bin 0 -> 11219 bytes .../button-group-spec/Button-2_focused.png | Bin 0 -> 11751 bytes .../button-group-spec/Button-3_focused.png | Bin 0 -> 11704 bytes .../button-group-spec/Button-1_focused.png | Bin 0 -> 12099 bytes .../button-group-spec/Button-2_focused.png | Bin 0 -> 12790 bytes .../button-group-spec/Button-3_focused.png | Bin 0 -> 12793 bytes .../button-group-spec/Button-1_focused.png | Bin 0 -> 11421 bytes .../button-group-spec/Button-2_focused.png | Bin 0 -> 11986 bytes .../button-group-spec/Button-3_focused.png | Bin 0 -> 11986 bytes .../tests/wdio/button-group-spec.js | 21 ++ packages/terra-button/CHANGELOG.md | 6 + packages/terra-button/src/Button.jsx | 23 +- .../terra-button/tests/jest/Button.test.jsx | 4 +- .../jest/__snapshots__/Button.test.jsx.snap | 11 +- packages/terra-core-docs/CHANGELOG.md | 6 + .../button-group/AccessibilityGuide.2.doc.mdx | 216 ++++++++++++++++++ ...hangeLog.3.doc.mdx => ChangeLog.4.doc.mdx} | 0 ...Guide.2.doc.mdx => UpgradeGuide.3.doc.mdx} | 0 .../example/ButtonGroupA11yIcon.jsx | 16 ++ .../example/ButtonGroupIsBlock.jsx | 1 + .../example/ButtonGroupMultiSelect.jsx | 7 +- .../example/ButtonGroupSingleSelect.jsx | 6 +- .../doc/button/AccessibilityGuide.2.doc.mdx | 8 +- .../doc/button/example/A11yIconButton.jsx | 8 +- .../doc/button/example/ButtonIcon.jsx | 6 +- .../doc/button/example/IconButtonVariant.jsx | 6 +- .../button-group/ButtonGroupIsBlock.test.jsx | 1 + .../ButtonGroupIsBlockLongText.test.jsx | 1 + .../ButtonGroupMultiSelect.test.jsx | 1 + packages/terra-search-field/CHANGELOG.md | 3 + .../__snapshots__/SearchField.test.jsx.snap | 16 +- packages/terra-status-view/CHANGELOG.md | 3 + .../__snapshots__/StatusView.test.jsx.snap | 2 - packages/terra-toggle-button/CHANGELOG.md | 3 + .../__snapshots__/ToggleButton.test.jsx.snap | 6 +- 45 files changed, 516 insertions(+), 104 deletions(-) create mode 100644 packages/terra-button-group/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_huge/button-group-spec/Button-1_focused.png create mode 100644 packages/terra-button-group/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_huge/button-group-spec/Button-2_focused.png create mode 100644 packages/terra-button-group/tests/wdio/__snapshots__/reference/clinical-lowlight-theme/en/chrome_huge/button-group-spec/Button-3_focused.png create mode 100644 packages/terra-button-group/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_huge/button-group-spec/Button-1_focused.png create mode 100644 packages/terra-button-group/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_huge/button-group-spec/Button-2_focused.png create mode 100644 packages/terra-button-group/tests/wdio/__snapshots__/reference/orion-fusion-theme/en/chrome_huge/button-group-spec/Button-3_focused.png create mode 100644 packages/terra-button-group/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_huge/button-group-spec/Button-1_focused.png create mode 100644 packages/terra-button-group/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_huge/button-group-spec/Button-2_focused.png create mode 100644 packages/terra-button-group/tests/wdio/__snapshots__/reference/terra-default-theme/en/chrome_huge/button-group-spec/Button-3_focused.png create mode 100644 packages/terra-core-docs/src/terra-dev-site/doc/button-group/AccessibilityGuide.2.doc.mdx rename packages/terra-core-docs/src/terra-dev-site/doc/button-group/{ChangeLog.3.doc.mdx => ChangeLog.4.doc.mdx} (100%) rename packages/terra-core-docs/src/terra-dev-site/doc/button-group/{UpgradeGuide.2.doc.mdx => UpgradeGuide.3.doc.mdx} (100%) create mode 100644 packages/terra-core-docs/src/terra-dev-site/doc/button-group/example/ButtonGroupA11yIcon.jsx diff --git a/packages/terra-action-header/CHANGELOG.md b/packages/terra-action-header/CHANGELOG.md index dc035853829..d532b20712b 100644 --- a/packages/terra-action-header/CHANGELOG.md +++ b/packages/terra-action-header/CHANGELOG.md @@ -2,6 +2,9 @@ ## Unreleased +* Changed + * Updated jest snapshots for button changes. + ## 2.77.0 - (February 16, 2023) * Changed diff --git a/packages/terra-action-header/tests/jest/__snapshots__/ActionHeader.test.jsx.snap b/packages/terra-action-header/tests/jest/__snapshots__/ActionHeader.test.jsx.snap index 674e270dacd..522ba7bd47d 100644 --- a/packages/terra-action-header/tests/jest/__snapshots__/ActionHeader.test.jsx.snap +++ b/packages/terra-action-header/tests/jest/__snapshots__/ActionHeader.test.jsx.snap @@ -18,7 +18,6 @@ exports[`ActionHeader correctly applies the theme context className 1`] = ` className="header-icon maximize" /> } - iconType="decorative" isBlock={false} isCompact={false} isDisabled={false} @@ -58,7 +57,6 @@ exports[`ActionHeader correctly applies the theme context className 1`] = ` className="header-icon close" /> } - iconType="decorative" isBlock={false} isCompact={false} isDisabled={false} @@ -96,7 +94,6 @@ exports[`ActionHeader should render an action header with back and close buttons className="header-icon close" /> } - iconType="decorative" isBlock={false} isCompact={false} isDisabled={false} @@ -122,7 +119,6 @@ exports[`ActionHeader should render an action header with back and close buttons className="header-icon back" /> } - iconType="decorative" isBlock={false} isCompact={false} isDisabled={false} @@ -155,7 +151,6 @@ exports[`ActionHeader should render an action header with back button and title className="header-icon back" /> } - iconType="decorative" isBlock={false} isCompact={false} isDisabled={false} @@ -186,7 +181,6 @@ exports[`ActionHeader should render an action header with close button and title className="header-icon close" /> } - iconType="decorative" isBlock={false} isCompact={false} isDisabled={false} @@ -213,7 +207,6 @@ exports[`ActionHeader should render an action header with custom button and titl title="Action Header" >