This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
More options for thrift #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added (potentially redundant) socket selection
…cket/transport/protocol
| end | ||
|
|
||
| get '/sockets' do | ||
| sockets = {'Thrift::Socket'=>'Thrift::Socket'} |
There was a problem hiding this comment.
Are there other socket implementations? I'd like to understand the motivation for making this configurable.
|
We'll also want to show the |
| @@ -88,7 +101,8 @@ class App < Sinatra::Base | |||
| end.compact | |||
|
|
|||
| begin | |||
| transport = Thrift::FramedTransport.new Thrift::Socket.new(invocation['host'], invocation['port']) | |||
| socket = Object::const_get(invocation['socket']).new(invocation['host'], invocation['port']) | |||
| transport = Object::const_get(invocation['transport']).new(socket) | |||
There was a problem hiding this comment.
We should provide defaults for the new fields to keep this passive, i.e. invocation['transport'] || 'Thrift::FramedTransport', because there are some users who post request json that they've saved previously.
had to include patch file for thrift gem from https://issues.apache.org/jira/browse/THRIFT-1108
updated README.md fixed a typo in scrimp.rb reorderd transport list in app.rb
… cert for testing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to change the transport and the socket and added a 'dynamic' version of the sample server so that the extra variations can be tested