Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use resync to sync helm charts #3371

Merged
merged 1 commit into from
Sep 6, 2022
Merged

ci: use resync to sync helm charts #3371

merged 1 commit into from
Sep 6, 2022

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Sep 6, 2022

When a file on the source is deleted same need to be deleted on the destination, with rsync we can achieve it.

fixes: #3329

  • sample output
modified:   index.yaml
modified:   rbd/ceph-csi-rbd/Chart.yaml
deleted:    rbd/ceph-csi-rbd/templates/nodeplugin-psp.yaml
deleted:    rbd/ceph-csi-rbd/templates/nodeplugin-role.yaml
deleted:    rbd/ceph-csi-rbd/templates/nodeplugin-rolebinding.yaml
deleted:    rbd/ceph-csi-rbd/templates/nodeplugin-rules-clusterrole.yaml
deleted:    rbd/ceph-csi-rbd/templates/provisioner-psp.yaml
deleted:    rbd/ceph-csi-rbd/templates/provisioner-rules-clusterrole.yaml

modified:   cephfs/ceph-csi-cephfs/Chart.yaml
deleted:    cephfs/ceph-csi-cephfs/templates/nodeplugin-clusterrole.yaml
deleted:    cephfs/ceph-csi-cephfs/templates/nodeplugin-clusterrolebinding.yaml
deleted:    cephfs/ceph-csi-cephfs/templates/nodeplugin-psp.yaml
deleted:    cephfs/ceph-csi-cephfs/templates/nodeplugin-role.yaml
deleted:    cephfs/ceph-csi-cephfs/templates/nodeplugin-rolebinding.yaml
deleted:    cephfs/ceph-csi-cephfs/templates/nodeplugin-rules-clusterrole.yaml
deleted:    cephfs/ceph-csi-cephfs/templates/provisioner-psp.yaml
deleted:    cephfs/ceph-csi-cephfs/templates/provisioner-rules-clusterrole.yaml
modified:   index.yaml
modified:   rbd/ceph-csi-rbd/Chart.yaml
deleted:    rbd/ceph-csi-rbd/templates/nodeplugin-psp.yaml
deleted:    rbd/ceph-csi-rbd/templates/nodeplugin-role.yaml
deleted:    rbd/ceph-csi-rbd/templates/nodeplugin-rolebinding.yaml
deleted:    rbd/ceph-csi-rbd/templates/nodeplugin-rules-clusterrole.yaml
deleted:    rbd/ceph-csi-rbd/templates/provisioner-psp.yaml
deleted:    rbd/ceph-csi-rbd/templates/provisioner-rules-clusterrole.yaml

Signed-off-by: Madhu Rajanna madhupr007@gmail.com

@Madhu-1 Madhu-1 added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/build Issues and PRs related to compiling Ceph-CSI labels Sep 6, 2022
@Madhu-1 Madhu-1 requested review from a team September 6, 2022 05:08
@mergify mergify bot added component/testing Additional test cases or CI work component/deployment Helm chart, kubernetes templates and configuration Issues/PRs labels Sep 6, 2022
@nixpanic nixpanic requested a review from a team September 6, 2022 07:31
@Madhu-1 @mergify
ci: use resync to sync helm charts
ef12ffc 
When a file on source is deleted same
need to be deleted on the destination,
with rsync we can achieve it.

fixes: ceph#3329

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@mergify mergify bot merged commit 9d46478 into ceph:devel Sep 6, 2022
@mergify mergify bot mentioned this pull request Sep 6, 2022
Merged
@humblec humblec added this to the release-3.7.1 milestone Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixpanic nixpanic nixpanic approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/build Issues and PRs related to compiling Ceph-CSI component/deployment Helm chart, kubernetes templates and configuration Issues/PRs component/testing Additional test cases or CI work
Projects
None yet
Milestone
release-3.7.1
Development

Successfully merging this pull request may close these issues.

ceph-csi-cephfs helm chart still contains provisioner-rules-clusterrole.yaml template
4 participants
@Madhu-1 @nixpanic @Rakshith-R @humblec