Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update whitelist components #167

Closed
denniswell opened this issue Mar 21, 2021 · 2 comments · Fixed by #173
Closed

Update whitelist components #167

denniswell opened this issue Mar 21, 2021 · 2 comments · Fixed by #173
Assignees
@jpangelle

Comments

@denniswell
Copy link
Contributor

  • Background: Whitelisting will be automated, but manual workarounds may still be required and in particular removing someone from the memberlist needs to be done manually. This can be done through etherscan, but AOs should be also be able to whitelist and more importantly unwhitelist investors soon
  • Currently the components only allow to whitelist / dd member (with a date set 10 years into the future
  • Solution: Add secondary button Remove member (to the left of Add); Header should be Add/remove TIN/DROP member
  • Click on Remove should call update member function with the date set to yesterday
@jpangelle jpangelle self-assigned this Mar 22, 2021
@jpangelle
Copy link
Contributor

Currently, the confirmation toast displays: Add 0xXXXXXX... to TIN/DROP. Should I update the verbiage to: Remove 0xXXXXXX... from TIN/DROP when a member is being removed?

image

@denniswell
Copy link
Contributor Author

Ah, yes, please do. This makes sense

@jpangelle jpangelle mentioned this issue Mar 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpangelle jpangelle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add a remove button for member list centrifuge/apps
2 participants
@jpangelle @denniswell