Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multicall to update portfolio prices and values in real time #113

Closed
hieronx opened this issue Jan 18, 2021 · 0 comments · Fixed by #177
Closed

Use multicall to update portfolio prices and values in real time #113

hieronx opened this issue Jan 18, 2021 · 0 comments · Fixed by #177
Assignees

Comments

@hieronx
Copy link
Contributor

hieronx commented Jan 18, 2021

The portfolio page displays balances and prices of the token holdings of a specific address. An example is https://tinlake.centrifuge.io/portfolio?address=0x683b73162ca9f344847c01d5040f07926b4d1378.

This data is retrieved from the subgraph, but the subgraph only updates the balances on a daily basis. See https://github.com/centrifuge/tinlake-subgraph/blob/main/src/domain/DailyPoolData.ts#L12

We want to fix this by using multicall to retrieve the real-time balance and price. An example usage of multicall in the tinlake UI codebase is here: https://github.com/centrifuge/apps/blob/main/tinlake-ui/ducks/pool.ts#L124 Ideally we should refactor this, likely by moving it into tinlake.js, but that's a larger item to tackle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants