Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investor Dashboard MVP - Test Feedback / Final changes #105

Closed
denniswell opened this issue Jan 17, 2021 · 0 comments
Closed

Investor Dashboard MVP - Test Feedback / Final changes #105

denniswell opened this issue Jan 17, 2021 · 0 comments
Assignees

Comments

@denniswell
Copy link
Contributor

denniswell commented Jan 17, 2021

Generally works well. All calcs within Overview correct. Some things need to be checked, plus minor UI changes.

Test set-up

Testing based on this Preview: https://6000a3c1ed13d44e73ee7b1c--tinlake-kovan-staging.netlify.app/portfolio?address=0x683b73162ca9f344847c01d5040f07926b4d1378
here is a Screenshot for Jutta:

Find test calculations and links to investor portfolios here:
https://docs.google.com/spreadsheets/d/16KW30k5t5UptDxSX0UYw8lVaCJYveV1AtfsA7GRb1e4/edit#gid=879295250

Feedback

A few things to check

  • Check why icons not shown (I know they were before, but are not in this preview)
  • Check why current token price not show (though apparently used to calculate value)
  • Check whther correct token price grabbed (I grabbed one from Etherscan and it wasn't the same apparently used for the calcs, let's check which one we use)
  • Check if click on leads to investment tab of pool (didn't for me, but probably only works when connected with address)
  • TBD: Do we also grab tokens held in the tranches/not collected? I didn't check it, but ideally we should, right?

UI updates TBD (see mockup below):

  • Sort by Current Value
  • Rename Titel: My Tinlake Portfolio
  • Rename navbar component: Portfolio Value
  • In Sum components on top: Swap DAI icon (already behind number) with TIN and DROP icons
  • For each Token component (see mockup), Show Pool name + [TOKEN Symbol] as underliner (noone really knows the token symbols, )
  • Add CTA at bottom: Want to invest in other Tinlake pools? Explore them [here](Link to Dashblard)!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants