Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effective result of presence call diverge from typing annotation. #220

Closed
vindemasi opened this issue Mar 31, 2023 · 2 comments
Closed

Effective result of presence call diverge from typing annotation. #220

vindemasi opened this issue Mar 31, 2023 · 2 comments

Comments

@vindemasi
Copy link

Hello all,

Describe the bug
It seems type annotation for subscription.presence() diverge from the effective result.

To Reproduce
Steps to reproduce the behavior:

  1. Call subscription.presence()
  2. See a responce payload like:
 {
   "f7cfb659-8cda-4561-a1b2-bb8ecb173713": {
       "user": "1",
       "client": "f7cfb659-8cda-4561-a1b2-bb8ecb173713",
       "conn_info": {
           "id": "1",
           "name": "Someone"
       }
   }
}

Expected behavior
It should return (as per type annotation) a property connInfo instead of conn_info.

Versions

  • OS: macOS
  • Browser
  • centrifuge-js v3.1.0
  • Server version 4.1.2
@FZambia
Copy link
Member

FZambia commented Apr 1, 2023

Hello, thanks for opening!

Unfortunate thing, will fix keeping current field too - to not break someone's code.

@FZambia
Copy link
Member

FZambia commented Apr 1, 2023

Fixed in 3.1.1

@FZambia FZambia closed this as completed Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants