Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI should let approve proposals when in execution stage #177

Closed
1 task done
martinvol opened this issue Mar 7, 2024 · 2 comments
Closed
1 task done

CLI should let approve proposals when in execution stage #177

martinvol opened this issue Mar 7, 2024 · 2 comments
Assignees

Comments

@martinvol
Copy link
Contributor

Package

@celo/celocli

Have you ensured that all of these are up to date?

  • the package you are using

What version of the package are you on?

4

What command or function is the bug in?

celocli governance:approve

Operating System

None

Describe the bug

Previously, proposals where only approvable when they where in the approving stage. Nowadays, the approval stage doesn't exist anymore and rather they can be approved in both referendum and execution (source). But the cli only lets approve when in referendum stage (source).

@arthurgousset
Copy link
Contributor

Great point, thanks for logging this @martinvol 👍

@aaronmgdr
Copy link
Member

aaronmgdr commented Jul 17, 2024

being done in #296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants