Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[M01] Invalid Beneficiary #9240

Closed
m-chrzan opened this issue Jan 27, 2022 · 0 comments
Closed

[M01] Invalid Beneficiary #9240

m-chrzan opened this issue Jan 27, 2022 · 0 comments

Comments

@m-chrzan
Copy link
Contributor

The setPaymentDelegation function of the Accounts contract allows a validator to set the
zero address as their beneficiary with a non-zero payment fraction. In this scenario, the
reward distribution mechanism will attempt to mint tokens to the zero address, which will
revert. Consequently, neither the validator nor their group will receive the epoch payment.

Consider preventing validators from setting a zero beneficiary with a non-zero payment
fraction. Additionally, in the interest of clearly signaling user intentions, consider
introducing a deletePaymentDelegation function so the setPaymentDelegation function
can disallow any zero beneficiary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants