You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[follow up] we should enable golangci-lint for this repo and enable the export comment linter.
Why?
Exports should have comments so when other packages import them, it is abundantly clear what they are importing.
The additional benefit of having comments is that it forces line separation for things like this. So when 1 new error is added, we don't have an unnecessarily long diff that is unhelpful in understanding the actual change.
Copilot can add comments to all of these, so it isn't a big lift to add comments and new lines here in a separate PR.
Could be done now and merge to clean up the diff here.
[follow up] we should enable golangci-lint for this repo and enable the export comment linter.
Why?
Exports should have comments so when other packages import them, it is abundantly clear what they are importing.
The additional benefit of having comments is that it forces line separation for things like this. So when 1 new error is added, we don't have an unnecessarily long diff that is unhelpful in understanding the actual change.
Copilot can add comments to all of these, so it isn't a big lift to add comments and new lines here in a separate PR.
Could be done now and merge to clean up the diff here.
Originally posted by @MSevey in #336 (comment)
The text was updated successfully, but these errors were encountered: