Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: have knuu as an object #328

Closed
smuu opened this issue May 8, 2024 · 3 comments · Fixed by #356
Closed

refactor!: have knuu as an object #328

smuu opened this issue May 8, 2024 · 3 comments · Fixed by #356
Assignees
Labels
knuu refactor Refactoring

Comments

@smuu
Copy link
Member

smuu commented May 8, 2024

func Knuu(scope string) (*Knuu, error)

func (k *Knuu) GetScope() (string, error)
func (k *Knuu) CleanUp() (error)
func (k *Knuu) SetImageBuilder(b builder.Builder) (error)
func (k *Knuu) ImageBuilder() (builder.Builder, error)
func (k *Knuu) NewInstance(name string) error

If we do that before v1, please make changes backward compatible.

@smuu smuu added the refactor Refactoring label May 8, 2024
@mojtaba-esk mojtaba-esk self-assigned this May 15, 2024
@mojtaba-esk
Copy link
Contributor

This is a breaking change, we need to communicate it well to the users before cutting a release.

@mojtaba-esk mojtaba-esk changed the title refactor: have knuu as an object refactor!: have knuu as an object May 15, 2024
@smuu
Copy link
Member Author

smuu commented May 15, 2024

This is a breaking change, we need to communicate it well to the users before cutting a release.

Can we add this without touching the current code?

@mojtaba-esk
Copy link
Contributor

We can write some wrappers to support the current users, then in another release we can get rid of the wrapper and ask everyone to use it as an object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
knuu refactor Refactoring
Projects
Development

Successfully merging a pull request may close this issue.

2 participants