From 313624216bd2f1dc46c5e9f5c7ecb0ff2a5e3017 Mon Sep 17 00:00:00 2001 From: Ryan Date: Wed, 7 Jun 2023 14:44:36 +0200 Subject: [PATCH 1/2] fix(state): fixing panic when err != nil but response is nil --- state/core_access.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/state/core_access.go b/state/core_access.go index 0a265c2d08..44514818da 100644 --- a/state/core_access.go +++ b/state/core_access.go @@ -179,7 +179,7 @@ func (ca *CoreAccessor) SubmitPayForBlob( ca.payForBlobCount++ } - if response.Code != 0 { + if err == nil && response.Code != 0 { err = errors.Join(err, sdkErrors.ABCIError(response.Codespace, response.Code, response.Logs.String())) } return response, err From d9e85f6be093d99b09eb7960fd801ee0e7256608 Mon Sep 17 00:00:00 2001 From: Ryan Date: Thu, 8 Jun 2023 09:56:41 +0200 Subject: [PATCH 2/2] review comments --- state/core_access.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/state/core_access.go b/state/core_access.go index 44514818da..712100d921 100644 --- a/state/core_access.go +++ b/state/core_access.go @@ -179,7 +179,7 @@ func (ca *CoreAccessor) SubmitPayForBlob( ca.payForBlobCount++ } - if err == nil && response.Code != 0 { + if response != nil && response.Code != 0 { err = errors.Join(err, sdkErrors.ABCIError(response.Codespace, response.Code, response.Logs.String())) } return response, err