Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: decouple binary and utils #2754

Open
vgonkivs opened this issue Sep 25, 2023 · 1 comment
Open

cmd: decouple binary and utils #2754

vgonkivs opened this issue Sep 25, 2023 · 1 comment

Comments

@vgonkivs
Copy link
Member

Suggested by @Wondertan:
"Decouple cmd/binary from cli/cmd utils. Move all the cmd/...go files to cli or lib/cli, then cmd would only be a place for our main apps/entrypoints.
Alternatively, we can move them to nodebuilder/node/cmd. I just looked at we have there and all the stuff there are node/admin related cmds - start, auth, utils for them, etc. So it logically makes sense to keep it there.
Generally, I like the idea of not keeping the cmd pkg with 0 code and only subpkgs with binaries, which is also idiomatic."

@ramin
Copy link
Contributor

ramin commented Oct 18, 2023

@vgonkivs i think we are pretty much there on this with the completion of #2706? anything else remaining or can we mark it done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants