Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd/rpc): Rework all methods that take variadic params #2666

Open
vgonkivs opened this issue Sep 7, 2023 · 6 comments
Open

fix(cmd/rpc): Rework all methods that take variadic params #2666

vgonkivs opened this issue Sep 7, 2023 · 6 comments
Labels

Comments

@vgonkivs
Copy link
Member

vgonkivs commented Sep 7, 2023

Unfortunately, go-openrpc can't handle methods that accept variadic params. We should rework all these methods to accept the Options struct(as was proposed in #2630)

@Wondertan
Copy link
Member

We should aim to fix variadics so that we have non-breaking way to add Options struct to each method

@distractedm1nd
Copy link
Collaborator

We don't have any methods that use variadic params on our RPC so I think this can be closed

@Wondertan
Copy link
Member

Wondertan commented Sep 22, 2023

No, we want variadics for non-breaking options

@nodersteam
Copy link
Contributor

@Wondertan Can we start working on this?

@Wondertan
Copy link
Member

This is a tricky one, but I believe it is valuable, so I would happily review it

@moldis
Copy link
Contributor

moldis commented Jan 11, 2024

@Wondertan is there any specific endpoints need to support non-breaking options ? From my review, might be state package or anything else in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants