-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cmd/rpc): Rework all methods that take variadic params #2666
Comments
We should aim to fix variadics so that we have non-breaking way to add Options struct to each method |
We don't have any methods that use variadic params on our RPC so I think this can be closed |
No, we want variadics for non-breaking options |
@Wondertan Can we start working on this? |
This is a tricky one, but I believe it is valuable, so I would happily review it |
@Wondertan is there any specific endpoints need to support non-breaking options ? From my review, might be |
Unfortunately, go-openrpc can't handle methods that accept variadic params. We should rework all these methods to accept the
Options
struct(as was proposed in #2630)The text was updated successfully, but these errors were encountered: