Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(share/p2p/shrexnd): Non-Inclusion Proofs do not exist for ErrNamespaceNotFound #2183

Closed
Tracked by #2106
distractedm1nd opened this issue May 10, 2023 · 0 comments
Assignees
Labels
area:shares Shares and samples kind:feat Attached to feature PRs

Comments

@distractedm1nd
Copy link
Collaborator

In #2145 , we will introduce a new response type for the case when data exists, but the namespace requested is not found in the data. This introduces a critical attack vector where FNs can tell LNs that data does not exist for a specific nID at arbitrary heights.

The solution for this is implementing non-inclusion proofs. The signature for GetSharesByNamespace does not need to change, as it fits inside the nmt.Proof data structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:shares Shares and samples kind:feat Attached to feature PRs
Projects
None yet
Development

No branches or pull requests

3 participants