Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bridge: error failed to retrieve shares by namespace when running rollup on v0.9.0 #2089

Closed
Tracked by #2106
smuu opened this issue Apr 17, 2023 · 8 comments
Closed
Tracked by #2106
Assignees
Labels
bug Something isn't working external Issues created by non node team members

Comments

@smuu
Copy link
Member

smuu commented Apr 17, 2023

Celestia Node version

v0.9.0 & v0.9.1

OS

Docker (Alpine Linux)

Install tools

https://github.com/rollkit/local-celestia-devnet/blob/v0.9.0/Dockerfile

local-celestia-devnet starts a consensus full node in validating node and starts a bridge node connected to it.
The rollup directly connects to the bridge using the 26659 port. There is no celestia light node involved.

Others

No response

Steps to reproduce it

  1. Have docker & docker compose installed
  2. Clone https://github.com/rollkit/gm
  3. In one terminal, run docker compose -f docker/docker-compose.yaml up celestia
  4. In another terminal, run docker compose -f docker/docker-compose.yaml up gm
  5. Please wait until it is up & running

Expected result

No errors

Actual result

  • See an error in gm (second terminal): ERR failed to retrieve block from DALC
  • And the first terminal, you should see a lot of the following message: gateway gateway/util.go:9 serving request {"endpoint": "/namespaced_data", "err": "getter/store: failed to retrieve shares by namespace: data not found"}

Relevant log output

No response

Notes

No response

@smuu smuu added the bug Something isn't working label Apr 17, 2023
@github-actions github-actions bot added the external Issues created by non node team members label Apr 17, 2023
@tty47
Copy link
Contributor

tty47 commented Apr 17, 2023

cc: @jrmanes

@Bidon15
Copy link
Member

Bidon15 commented Apr 17, 2023

@smuu please provide more celestia-node context in the issue
Like, the bridge node is started with a consensus full node.
As well as there is no light node involved IIRC 🙏

@smuu
Copy link
Member Author

smuu commented Apr 18, 2023

Updated description as I have the same bug in v0.9.1

@renaynay
Copy link
Member

@smuu does it work on earlier version?

@smuu
Copy link
Member Author

smuu commented Apr 21, 2023

@smuu does it work on earlier version?

Can't reproduce the error with v0.8.2.

@walldiss
Copy link
Member

Resolved by #2074

@walldiss walldiss self-assigned this Apr 21, 2023
@smuu
Copy link
Member Author

smuu commented Apr 21, 2023

Resolved by #2074

This PR commit d375373 is included in v0.9.x, but I encountered this error in those versions.

@smuu smuu reopened this Apr 21, 2023
@smuu
Copy link
Member Author

smuu commented Apr 25, 2023

This comes from the changes in https://github.com/celestiaorg/celestia-node/pull/2074/files#diff-8d18fdcd01756b908640b77156572fe8af0520e027691bd88beeaf8cdca5085dR114-R117 where internal error handling was changed.
Before, it was returning {"data":null,"height":1} and now "getter/store: failed to retrieve shares by namespace: data not found". So this can be fixed on rollkit by handling the returned error correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external Issues created by non node team members
Projects
None yet
Development

No branches or pull requests

5 participants