Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is MinCommissionRate correct? #2480

Closed
rootulp opened this issue Sep 13, 2023 · 2 comments · Fixed by #2417
Closed

Is MinCommissionRate correct? #2480

rootulp opened this issue Sep 13, 2023 · 2 comments · Fixed by #2417
Assignees
Labels
documentation Improvements or additions to documentation specs directly relevant to the specs

Comments

@rootulp
Copy link
Collaborator

rootulp commented Sep 13, 2023

Context

| staking.MinCommissionRate | 0.05 (5%) | Minimum commission rate used by all validators. | True |

On main

$ celestia-appd query  staking params
bond_denom: utia
historical_entries: 10000
max_entries: 7
max_validators: 100
min_commission_rate: "0.000000000000000000"
unbonding_time: 1814400s

The default is defined here.

@rootulp rootulp added documentation Improvements or additions to documentation specs directly relevant to the specs labels Sep 13, 2023
@rootulp rootulp added this to the Mainnet milestone Sep 13, 2023
@cmwaters
Copy link
Contributor

@rootulp
Copy link
Collaborator Author

rootulp commented Sep 13, 2023

Ahh good point. Proposal to update the params.md on main so that it reflects the current value of 0. I think #2417 should update the param in both places (code and specs) so that the specs always match the param in-use. This is especially important b/c we're backporting certain PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation specs directly relevant to the specs
Projects
None yet
3 participants