Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS warning: FSEventStreamScheduleWithRunLoop is deprecated #1208

Closed
rootulp opened this issue Jan 10, 2023 · 1 comment
Closed

MacOS warning: FSEventStreamScheduleWithRunLoop is deprecated #1208

rootulp opened this issue Jan 10, 2023 · 1 comment
Labels
chore optional label for items that follow the `chore` conventional commit dependencies Pull requests that update a dependency file

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jan 10, 2023

Problem

On 800de23 I'm observing a warning

$ make test
--> Running unit tests
# github.com/rjeczalik/notify
cgo-gcc-prolog:217:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here

Proposal

The warning appears to originate from https://github.com/rjeczalik/notify which is transitively brought in via go-ethereum. I expect this issue to be resolvable after go-ethereum creates a release with ethereum/go-ethereum#26176 (likely 1.11.0) and this repo upgrades to it.

@rootulp rootulp added dependencies Pull requests that update a dependency file chore optional label for items that follow the `chore` conventional commit labels Jan 10, 2023
@rootulp
Copy link
Collaborator Author

rootulp commented Feb 16, 2023

Closed by #1387

Verified no more warnings

$ make test-short
--> Running tests in short mode
ok  	github.com/celestiaorg/celestia-app/app	10.631s
?   	github.com/celestiaorg/celestia-app/app/encoding	[no test files]
ok  	github.com/celestiaorg/celestia-app/app/test	9.080s
?   	github.com/celestiaorg/celestia-app/cmd/celestia-appd	[no test files]
?   	github.com/celestiaorg/celestia-app/cmd/celestia-appd/cmd	[no test files]
?   	github.com/celestiaorg/celestia-app/pkg/appconsts	[no test files]
ok  	github.com/celestiaorg/celestia-app/pkg/da	0.855s
ok  	github.com/celestiaorg/celestia-app/pkg/inclusion	0.648s
ok  	github.com/celestiaorg/celestia-app/pkg/proof	1.023s
ok  	github.com/celestiaorg/celestia-app/pkg/shares	0.758s
ok  	github.com/celestiaorg/celestia-app/pkg/wrapper	0.278s
?   	github.com/celestiaorg/celestia-app/proto/celestia/da	[no test files]
?   	github.com/celestiaorg/celestia-app/testutil	[no test files]
?   	github.com/celestiaorg/celestia-app/testutil/blobfactory	[no test files]
?   	github.com/celestiaorg/celestia-app/testutil/keeper	[no test files]
?   	github.com/celestiaorg/celestia-app/testutil/namespace	[no test files]
?   	github.com/celestiaorg/celestia-app/testutil/network	[no test files]
?   	github.com/celestiaorg/celestia-app/testutil/testfactory	[no test files]
ok  	github.com/celestiaorg/celestia-app/testutil/testnode	1.424s
ok  	github.com/celestiaorg/celestia-app/x/blob	1.274s
?   	github.com/celestiaorg/celestia-app/x/blob/client/cli	[no test files]
ok  	github.com/celestiaorg/celestia-app/x/blob/client/testutil	2.226s
ok  	github.com/celestiaorg/celestia-app/x/blob/keeper	1.730s
ok  	github.com/celestiaorg/celestia-app/x/blob/types	0.439s
ok  	github.com/celestiaorg/celestia-app/x/blob/types/test	2.462s
ok  	github.com/celestiaorg/celestia-app/x/qgb	1.643s
?   	github.com/celestiaorg/celestia-app/x/qgb/client	[no test files]
ok  	github.com/celestiaorg/celestia-app/x/qgb/keeper	1.977s
ok  	github.com/celestiaorg/celestia-app/x/qgb/types	1.545s
ok  	github.com/celestiaorg/celestia-app/x/tokenfilter	1.563s

@rootulp rootulp closed this as completed Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant