Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

BVC-47 :: Lack of Diagnosis keys download limit #157

Open
1 task
obrien-j opened this issue Jul 8, 2020 · 1 comment
Open
1 task

BVC-47 :: Lack of Diagnosis keys download limit #157

obrien-j opened this issue Jul 8, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request low priority S

Comments

@obrien-j
Copy link
Contributor

obrien-j commented Jul 8, 2020

We've set a maxKeysPerFile constant, but never actually use it when preparing the key bundles.

https://github.com/cds-snc/covid-shield-server/blob/e14893d09e065bf50039e9502a48cfce969d9704/pkg/retrieval/retrieval.go#L18

This is likely a non-issue, at least for the initial launch, but will obviously become problematic if we move into an international federation approach.

Flagging for awareness.

AC:

  • Set proper upper bound

Risk: We are not likely to reach this limit. It will become an issue if we decide to join an international federation.

@maxneuvians
Copy link
Contributor

Set proper upper bound

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request low priority S
Projects
None yet
Development

No branches or pull requests

5 participants