Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to implement forced anisotropic filtering? #26

Closed
aufkrawall opened this issue Jul 27, 2024 · 11 comments
Closed

Possible to implement forced anisotropic filtering? #26

aufkrawall opened this issue Jul 27, 2024 · 11 comments

Comments

@aufkrawall
Copy link

Since OptiScaler can already force mip map bias, would it be possible to implement forced anisotropic filtering as an optional feature? The AMD D3D12 driver unfortunately still can't force it, and while forcing it may cause issues in some games, it can improve visuals in others where game devs e.g. apply questionable "optimizations" with low anisotropic filtering values for some textures etc.
Thanks!

@cdozdil
Copy link
Owner

cdozdil commented Jul 29, 2024

Hi,

I have prepared a test build for anisotropy overriding. You can force it from nvngx.ini (better use this one) or from in-game menu. If you force it from menu probably need to change resolution or DLSS preset to activate changes.

[Hotfix]
; Override max anisotropy for textures
; 2, 4, 8, 16 - Default (auto) is disabled
AnisotropyOverride=auto

I have tried to limit override to Bilinear, Trilinear and Anisotropic filtered textures but might cause issues with menus and other 2D stuff.

nvngx-force-aniso-test.zip

@aufkrawall
Copy link
Author

Thanks a lot for your efforts!

It seems with this build, there already is some issue with mip mapping (?) with default settings:
witcher3_2024_07_29_15_31_01_283

@cdozdil
Copy link
Owner

cdozdil commented Jul 29, 2024

Ah yes made a copy/paste mistake, here is the fixed one 😊

And fixed a possible menu crash 😅

nvngx-force-aniso-test-3.zip

@aufkrawall
Copy link
Author

It works now, fantastic. :)

Probably a regression: It always shows the current mip bias as 0, whereas stable build v0.6.5 reports it as -2 with DLSS Performance selected in-game.

@cdozdil
Copy link
Owner

cdozdil commented Jul 29, 2024

Yeah, noticed and fixed that after sending you the build 😊

@cdozdil
Copy link
Owner

cdozdil commented Jul 29, 2024

@aufkrawall
Copy link
Author

Hm, still shows 0. I've also noticed that saving the aniso value to config file from OSD doesn't work. :)

@cdozdil
Copy link
Owner

cdozdil commented Jul 30, 2024

This build should fix both of the issues

https://github.com/cdozdil/OptiScaler/actions/runs/10170882440

@aufkrawall
Copy link
Author

Confirmed fixed. :)

Maybe one more nitpick (hope this doesn't get too annoying): When adjusting only the aniso value in OSD and not touching the mip bias bar, I think it shouldn't force mip bias to 0 (both runtime and when writing to config).

@cdozdil
Copy link
Owner

cdozdil commented Jul 31, 2024

Unless you click the set button it won't set mipbias. For anisotropy you don't need to click set, maybe putting anisotropy under set button makes it more obivous 👍

@aufkrawall
Copy link
Author

Alright, makes sense. Closing now, thanks a lot! This is such an amazing tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants