Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to projen #841

Merged
merged 8 commits into from
Jun 13, 2021
Merged

chore: migrate to projen #841

merged 8 commits into from
Jun 13, 2021

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Jun 13, 2021

Notable changes

  • Tests moved to lib/__tests__
  • change-control-lambda moved inside lib instead of a separate package + use NodeJSFunction for bundling (avoiding the need for the build-change-control-lambda script)
  • custom-resource-handlers moved inside lib (but are still being built with a dedicated script).
  • A bunch of ESLint fixes.

BREAKING CHANGE: esbuild or docker is required in order to bundle the change-control-lambda


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iliapolo iliapolo force-pushed the epolon/migrate-to-projen branch from 9637683 to 77a25dc Compare June 13, 2021 10:00
@iliapolo iliapolo marked this pull request as ready for review June 13, 2021 13:12
@iliapolo iliapolo requested a review from a team June 13, 2021 13:12
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow

@eladb eladb added the do-not-merge Do not automerge. THIS LABEL NAME SHOULD NOT BE CHANGED. It's co-dependent to the Github action. label Jun 13, 2021
@iliapolo iliapolo marked this pull request as draft June 13, 2021 13:43
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: GitHubPipelineAutoBuildProj-XK8ItpxnSow5
  • Commit ID: 7a1242f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@iliapolo
Copy link
Contributor Author

iliapolo commented Jun 13, 2021

@eladb It just dawned on me that the switch to NodejsFunction in the change-controller-lambda is a breaking change, since it requires either esbuild or docker to bundle.

I'm going to mark this breaking and release a new major version. Can you acknowledge?

@iliapolo iliapolo requested a review from eladb June 13, 2021 14:55
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@iliapolo iliapolo removed the do-not-merge Do not automerge. THIS LABEL NAME SHOULD NOT BE CHANGED. It's co-dependent to the Github action. label Jun 13, 2021
@iliapolo iliapolo marked this pull request as ready for review June 13, 2021 16:19
@iliapolo iliapolo merged commit 8b6eac1 into main Jun 13, 2021
@iliapolo iliapolo deleted the epolon/migrate-to-projen branch June 13, 2021 16:19
mergify bot pushed a commit that referenced this pull request Jun 13, 2021
The projen migration [PR](#841) introduced a breaking change.

Unfortunately when I merged the PR manually I removed the breaking change notice by accident.

This is just a dummy PR to re-introduce the notice so that `standard-version` performs a major version bump when the next release happens.

BREAKING CHANGE: `esbuild` or `docker` is required in order to bundle the change-control-lambda

-----

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants