-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to projen #841
Conversation
9637683
to
77a25dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@eladb It just dawned on me that the switch to I'm going to mark this breaking and release a new major version. Can you acknowledge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
The projen migration [PR](#841) introduced a breaking change. Unfortunately when I merged the PR manually I removed the breaking change notice by accident. This is just a dummy PR to re-introduce the notice so that `standard-version` performs a major version bump when the next release happens. BREAKING CHANGE: `esbuild` or `docker` is required in order to bundle the change-control-lambda ----- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Notable changes
lib/__tests__
change-control-lambda
moved insidelib
instead of a separate package + useNodeJSFunction
for bundling (avoiding the need for thebuild-change-control-lambda
script)custom-resource-handlers
moved insidelib
(but are still being built with a dedicated script).BREAKING CHANGE:
esbuild
ordocker
is required in order to bundle the change-control-lambdaBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.