Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old version of Github Logs Serverless app hardcoded in code #1820

Closed
biffgaut opened this issue Dec 31, 2024 · 3 comments
Closed

Old version of Github Logs Serverless app hardcoded in code #1820

biffgaut opened this issue Dec 31, 2024 · 3 comments

Comments

@biffgaut
Copy link
Contributor

A few months back I opened Issue 1719, along with a PR that fixed the issue. At that time the PR was marked do not merge, with the comment:

Hi @biffgaut, thank you for the contribution! Unfortunately we're not accepting any changes at this time while we're working on setting up additional testing for delivlib. We will get back to this PR once that is in place.

Eventually the PR was automatically closed due to inactivity and the Issue was also automatically closed as complete. But the bug is still there. (the other change in my PR, updating the JSII image, was addressed by someone else in a subsequent PR).

I'm creating this issue to again draw attention to this problem, and will be opening another PR to address it.

@biffgaut
Copy link
Contributor Author

biffgaut commented Jan 8, 2025

Until this gets fixed, if you are here because you're facing the same problem, here is the workaround we are using:

    const yourBuild = new AutoBuild(this, 'id', {
      // All your properties
    });
    // Use escape hatch to override the hardcoded version
    const logs = yourBuild.node.findChild('GitHubCodeBuildLogsSAR') as serverless.CfnApplication;
    logs.addPropertyOverride('Location.SemanticVersion', '1.6.0');

@biffgaut
Copy link
Contributor Author

biffgaut commented Jan 8, 2025

Here is the PR that addresses it - #1821

@moelasmar
Copy link
Contributor

Thanks @biffgaut for raising this issue, and for the fix. The Pr got merged, I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants