-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
h5py=3.1 upgrade causes test_FormatHDF5EigerNearlyNexusSPring8 failure #267
Comments
Does #263 fix it? |
Also humbly & respectfully note that this was my fault, should have run more comprehensive tests before putting the 3.1 PR change in. |
Checking out the branch in #263 results in a different error:
|
No, I think what you did was reasonable. This test only works at diamond dxtbx/tests/format/test_FormatHDF5EigerNearlyNexusSPring8.py Lines 22 to 24 in 6370c7a
|
I think this test should be able to use dials.data now: |
Okay, so #263 fixes this error now, but not yet dials/dials#1523 |
With the previous h5py=2.10.0 this test passes as expected:
After upgrading h5py to 3.1:
this test now fails with the following error:
The text was updated successfully, but these errors were encountered: