Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate options changes to consumer #18

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

thompsongl
Copy link

Summary

Previously, EuiSelectableList was directly modifying its props object by mutating the options list. These changes will have EuiSelectableList and EuiSelectable propagate a new, modified copy of the options up to the 'source of truth' parent.

  • onChange prop now takes the options list directly as its argument
  • The concept of an exposed selectedOptions list no longer exists*. It didn't really exist to start, but this removes a misnomer reference in the examples.

* This is different than how EuiComboBox works, which may be ok, but probably worth discussing. We can also decide this later during the abstraction work we're planning.

@thompsongl thompsongl mentioned this pull request Mar 29, 2019
8 tasks
@cchaos
Copy link
Owner

cchaos commented Mar 29, 2019

This is different than how EuiComboBox works, which may be ok, but probably worth discussing. We can also decide this later during the abstraction work we're planning.

I'll agree. We'll figure out the EuiComboBox later, even if it means adding some things back in later.

Thanks!

@cchaos cchaos merged commit 3d3ae08 into cchaos:eui-selectable Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants