Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+Pause/Break closing tab #422

Closed
chessami92 opened this issue Mar 6, 2017 · 4 comments
Closed

Ctrl+Pause/Break closing tab #422

chessami92 opened this issue Mar 6, 2017 · 4 comments

Comments

@chessami92
Copy link

Expected Behavior

When pressing Ctrl+Pause/Break, the INT is sent to running application.

Actual Behavior

The tab closes and bash never sees the INT from Ctrl+Pause/Break.

Steps to reproduce

  1. Set up Console to run bash.exe
  2. Press Ctrl+Pause/Break

If I run bash.exe directly, this code in the .bashrc will be triggered on both Ctrl+C and Ctrl+Pause/Break and the bash window never closes. In console, only Ctrl+C triggers the code and Ctrl+Pause/Break immediately closes the tab.

trap ctrl_break INT

function ctrl_break() {
    echo "** Trapped CTRL-BREAK"
}

I am seeing this issue because there is an application I use that ignores Ctrl+C but instead only listens for Ctrl+Pause/Break to exit early.

@chessami92 chessami92 changed the title Ctrl+Pause/Break Ctrl+Pause/Break closing tab Mar 6, 2017
@cbucher
Copy link
Owner

cbucher commented Mar 7, 2017

(Diagnostic report is mandatory!)
Very old buggy version of git for windows?
See #380, #262

@chessami92
Copy link
Author

chessami92 commented Mar 7, 2017

I recall updating git for windows not too long ago.

git version 2.11.0.windows.1
GNU bash, version 4.3.46(2)-release (x86_64-pc-msys)

ConsoleZ aero amd64 1.17.2
Windows 7 Service Pack 1 (64 bits) [6.1.7601]
is elevated? no
UAC prefix "Administrator: "
Tab: ConsoleZ
  View (active): 2. ConsoleZ - /e/p/temp
  is elevated? no
  Windows console font
font index: 8
face name: Lucida Console
font familly: 54 MODERN vector true type
font weight: 400
font size: width=8 height=14
max window size: cols=120 rows=72
  ConsoleZ font
GetFontLanguageInfo returns 262144.
The font contains extra glyphs not normally accessible using the code page.

Tab (active): ConsoleZ
  View (active): 1. ConsoleZ - /e/p/temp
  is elevated? no
  Windows console font
font index: 8
face name: Lucida Console
font familly: 54 MODERN vector true type
font weight: 400
font size: width=8 height=14
max window size: cols=120 rows=72
  ConsoleZ font
GetFontLanguageInfo returns 262144.
The font contains extra glyphs not normally accessible using the code page.

Monitors 2
+ Flags 0
  DeviceID \\?\DISPLAY#DEL4098#5&1504cf88&0&UID261#{e6f07b5f-ee97-4a90-b076-33f57bf4eaa7}
  DeviceKey \Registry\Machine\System\CurrentControlSet\Control\Class\{4d36e96e-e325-11ce-bfc1-08002be10318}\0002
  DeviceName \\.\DISPLAY1\Monitor0
  DeviceString Generic PnP Monitor
  StateFlags 3
  Rect (1920,0)x(3840,1080)
  Work (1920,0)x(3840,1080)
  DPI (per monitor: no)
+ Flags 1  primary
  DeviceID \\?\DISPLAY#DEL4098#5&1504cf88&0&UID257#{e6f07b5f-ee97-4a90-b076-33f57bf4eaa7}
  DeviceKey \Registry\Machine\System\CurrentControlSet\Control\Class\{4d36e96e-e325-11ce-bfc1-08002be10318}\0001
  DeviceName \\.\DISPLAY2\Monitor0
  DeviceString Generic PnP Monitor
  StateFlags 3
  Rect (0,0)x(1920,1080)
  Work (0,0)x(1920,1040)
  DPI (per monitor: no)
System dpi 96
System metrics
  SM_CXSMICON        16
  SM_CYSMICON        16
  SM_CXICON          32
  SM_CYICON          32
  SM_CXVIRTUALSCREEN 3840
  SM_CYVIRTUALSCREEN 1080
  SM_CYVIRTUALSCREEN 1080
Settings file C:\Program Files\ConsoleZ\console.xml
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<settings lang="auto" icon_size="0">
	<console shell="C:\Program Files\Git\bin\bash.exe" init_dir="E:\projects" refresh="100" change_refresh="10" rows="60" columns="120" buffer_rows="9999" buffer_columns="0" start_hidden="0" save_size="0">
		<colors background_text_opacity="255">
			<color id="0" r="0" g="0" b="0"/>
			<color id="1" r="0" g="0" b="128"/>
			<color id="2" r="0" g="150" b="0"/>
			<color id="3" r="0" g="150" b="150"/>
			<color id="4" r="170" g="25" b="25"/>
			<color id="5" r="128" g="0" b="128"/>
			<color id="6" r="128" g="128" b="0"/>
			<color id="7" r="192" g="192" b="192"/>
			<color id="8" r="128" g="128" b="128"/>
			<color id="9" r="0" g="100" b="255"/>
			<color id="10" r="0" g="255" b="0"/>
			<color id="11" r="0" g="255" b="255"/>
			<color id="12" r="255" g="50" b="50"/>
			<color id="13" r="255" g="0" b="255"/>
			<color id="14" r="255" g="255" b="0"/>
			<color id="15" r="255" g="255" b="255"/>
		</colors>
		<cursor style="0" r="255" g="255" b="255"/>
		<background type="0" r="0" g="0" b="0">
			<image file="" relative="0" extend="0" position="0">
				<tint opacity="0" r="0" g="0" b="0"/></image></background></console>
	<appearance>
		<font name="Consolas" size="10" extra_width="0" bold="0" italic="0" smoothing="0" bold_intensified="0" italic_intensified="0" ligature="0">
			<color use="0" r="0" g="0" b="0"/></font>
		<window title="" icon="" main_title_format="?U([%u] )?N({%u} )%m?s( - %s)" tab_title_format="%n. ?U([%u] )?N({%u} )%t?s( - %s)" use_tab_icon="1" use_tab_title="0" trim_tab_titles="0" trim_tab_titles_right="0"/>
		<fullscreen start_in_fullscreen="0" fullscreen_monitor="0">
			<controls show_menu="1" show_toolbar="1" show_searchbar="1" show_statusbar="1" show_tabs="1" hide_single_tab="1" tabs_on_bottom="0" hide_tab_icons="0" show_scrollbars="1"/></fullscreen>
		<controls show_menu="1" show_toolbar="1" show_searchbar="1" show_statusbar="1" show_tabs="1" hide_single_tab="1" tabs_on_bottom="0" hide_tab_icons="0" show_scrollbars="1"/>
		<styles caption="1" resizable="1" taskbar_button="1" border="1" inside_border="2" tray_icon="1" quake_like="0" quake_animation_time="300" jumplist="0" integrated_ime="0" hide_when_inactive="0" per_monitor_dpi="0">
			<selection_color r="255" g="255" b="255"/>
			<highlight_color r="191" g="191" b="191"/></styles>
		<position x="-1" y="-1" save_position="0" w="-1" h="-1" save_size="0" z_order="0" dock="-1" snap="-1" save_state="0" state="-1"/>
		<transparency type="0" active_alpha="255" inactive_alpha="255" r="0" g="0" b="0"/></appearance>
	<behavior>
		<copy_paste copy_on_select="1" clear_on_copy="1" sensitive_copy="1" no_wrap="1" eol_spaces="1" trim_spaces="1" rtf="1" copy_newline_char="0" include_left_delimiter="0" include_right_delimiter="0" left_delimiters=" ([" right_delimiters=" )]"/>
		<scroll page_scroll_rows="0"/>
		<tab_highlight flashes="3" stay_highligted="1"/>
		<close allow_closing_last_view="0" exit_on_closing_of_last_tab="1" confirm_closing_multiple_views="1"/>
		<focus follow_mouse="0"/>
		<instance allow_multi="1"/>
		<clone use_current_dir="0"/>
		<search match_case="0" match_whole_word="0"/>
		<runas use_credprov="1"/></behavior>
	<hotkeys use_scroll_lock="1">
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="83" command="settings"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="112" command="help"/>
		<hotkey ctrl="0" shift="0" alt="1" extended="0" code="115" command="exit"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="84" command="newtab1"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="113" command="newtab2"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="114" command="newtab3"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="115" command="newtab4"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="116" command="newtab5"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="117" command="newtab6"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="118" command="newtab7"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="119" command="newtab8"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="120" command="newtab9"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="121" command="newtab10"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="newtab11"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="newtab12"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="49" command="switchtab1"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="50" command="switchtab2"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="51" command="switchtab3"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="52" command="switchtab4"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="53" command="switchtab5"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="54" command="switchtab6"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="55" command="switchtab7"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="56" command="switchtab8"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="57" command="switchtab9"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="48" command="switchtab10"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="switchtab11"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="switchtab12"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="9" command="nexttab"/>
		<hotkey ctrl="1" shift="1" alt="0" extended="0" code="9" command="prevtab"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="movetableft"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="movetabright"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="0" code="87" command="closetab"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="renametab"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="nextview"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="prevview"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="leftview"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="rightview"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="topview"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="bottomview"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="dechsize"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="inchsize"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="decvsize"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="incvsize"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="closeview"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="detachview"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="attach"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="splithoriz"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="splitvert"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="splitswap"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="clone"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="fullscreen"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="zoom100"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="zoominc"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="zoomdec"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="groupall"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="ungroupall"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="grouptab"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="ungrouptab"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="clear"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="1" code="45" command="copy"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="selectall"/>
		<hotkey ctrl="1" shift="0" alt="0" extended="1" code="46" command="clear_selection"/>
		<hotkey ctrl="0" shift="1" alt="0" extended="1" code="45" command="paste"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="paste_selection"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="stopscroll"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="resumescroll"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="textselleft"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="textselright"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="textseltop"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="textselbottom"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="textselhome"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="textselend"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="textselpageup"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="textselpagedown"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="colselleft"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="colselright"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="colseltop"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="colselbottom"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="colselhome"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="colselend"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="colselpageup"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="colselpagedown"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="scrollrowup"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="scrollrowdown"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="scrollpageup"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="scrollpagedown"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="scrollcolleft"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="scrollcolright"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="scrollpageleft"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="scrollpageright"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="find"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="findnext"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="findprev"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="switchtransparency"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="alwaysontop"/>
		<hotkey ctrl="1" shift="1" alt="0" extended="0" code="112" command="dumpbuffer"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="cmdMenu1"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="cmdMenu2"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="cmdMenu3"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="cmdSnippets"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="ctrlC"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="externalcmd1"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="externalcmd2"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="externalcmd3"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="externalcmd4"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="externalcmd5"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="externalcmd6"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="externalcmd7"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="externalcmd8"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="externalcmd9"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="externalcmd10"/>
		<hotkey ctrl="0" shift="0" alt="0" extended="0" code="0" command="activate" win="0"/>
	</hotkeys>
	<external_commands>
	</external_commands>
	<mouse>
		<actions>
			<action ctrl="0" shift="0" alt="0" button="0" name="copy"/>
			<action ctrl="0" shift="0" alt="0" button="1" name="select"/>
			<action ctrl="0" shift="0" alt="0" button="0" name="select_column"/>
			<action ctrl="0" shift="0" alt="0" button="2" name="paste"/>
			<action ctrl="1" shift="0" alt="0" button="1" name="drag"/>
			<action ctrl="0" shift="0" alt="0" button="0" name="link"/>
			<action ctrl="0" shift="0" alt="0" button="0" name="menu"/>
			<action ctrl="0" shift="0" alt="0" button="0" name="menu2"/>
			<action ctrl="0" shift="0" alt="0" button="0" name="menu3"/>
			<action ctrl="0" shift="0" alt="0" button="0" name="snippets"/>
		</actions></mouse>
	<snippets dir=""/>
	<tabs>
		<tab title="ConsoleZ" use_default_icon="0">
			<console shell="" init_dir="" priority="2" run_as_user="0" user="" net_only="0" run_as_admin="0">
				<env var="MSYSTEM" value="MINGW64" check="1"/>
				<env var="TERM" value="xterm" check="1"/>
			</console>
		</tab>
	</tabs></settings>

@cbucher
Copy link
Owner

cbucher commented Mar 7, 2017

ConsoleZ is not up to date.

Use C:\Program Files\Git\usr\bin\bash.exe.

C:\Program Files\Git\bin\bash.exe is a buggy launcher...
Git For Windows team has only fixed CTRL-C problem in their code. 😞
git-for-windows/git#205 (comment)

I had provided a patch to Git For Windows team. This patch corrected CTRL-BREAK too.
But they preferred waiting many months for an incomplete fix.

You can open a new issue here: https://github.com/git-for-windows/git

@chessami92
Copy link
Author

I did not realize there was a difference between bin\bash and usr\bin\bash in git for windows. usr\bin\bash seems to be working correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants