Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conan Package missing Catch.cmake #2455

Closed
mjohnsonwy opened this issue Jun 10, 2022 · 2 comments · Fixed by #2460
Closed

Conan Package missing Catch.cmake #2455

mjohnsonwy opened this issue Jun 10, 2022 · 2 comments · Fixed by #2460
Labels
Building and Packaging Issues affecting build/packaging scripts and utilities

Comments

@mjohnsonwy
Copy link
Contributor

mjohnsonwy commented Jun 10, 2022

Describe the bug

The Conan package for version 3.0.1 seems to no longer include the Catch.cmake and CatchAddTests.cmake files, so the CMake integration no longer works like it did in the 2.X versions of the package.

Reproduction steps

conanfile.txt:

[requires]
catch2/3.0.1

[generators]
cmake_find_package

CMakeLists.txt:

cmake_minimum_required(VERSION 3.5)

project(foo LANGUAGES CXX VERSION 0.0.1)

list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}")

find_package(Catch2 REQUIRED)

include(CTest)
include(Catch) # does not work

Build commands:

conan install . --build=missing
cmake .
@gegles
Copy link
Contributor

gegles commented Jun 10, 2022

Yes, this is an issue for us too and seemingly the only blocker for us to move to using the official Conan package for Catch2 v3.x.

@mjohnsonwy
Copy link
Contributor Author

Looks like this might be the line that missing from the v3.0 Conan recipe?

@horenmar horenmar added the Building and Packaging Issues affecting build/packaging scripts and utilities label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Building and Packaging Issues affecting build/packaging scripts and utilities
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants