Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HAVE_SCIPY #316

Closed
h-mayorquin opened this issue Apr 23, 2024 · 0 comments · Fixed by #364
Closed

Remove HAVE_SCIPY #316

h-mayorquin opened this issue Apr 23, 2024 · 0 comments · Fixed by #364

Comments

@h-mayorquin
Copy link
Collaborator

We have try-except blocks like this in a couple of places:

try:
    from scipy.sparse import csc_matrix

    HAVE_SCIPY = True
except ImportError:
    HAVE_SCIPY = False

But requirements minimal already has scipy:

https://github.com/catalystneuro/roiextractors/blob/275acbb66672766232fa9f7f1b232d7739d89745/requirements-minimal.txt#L9

So what's the point of them?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed unnecessary import checks for scipy, h5py, and zarr catalystneuro/roiextractors
1 participant
@h-mayorquin