divide by 0 crash when trading with more than 7 npcs

[scarf005]

Describe the bug

attempting to trade with 7+ npcs nearby crashes the game.

Steps To Reproduce

1. spawn 8 npcs, debug them into friendly
2. select e: let's trade items
3. divide by 0 error caused from item::ideal_ranged_dps

Screenshots

Cataclysm-BN/src/npcmove.cpp

Line 2108 in 8f34053

reload_cost /= magazine_integral() ? 1 : ammo_capacity() / mode.qty;

Versions and configuration

• OS: Linux
  • OS Version: Distributor ID: Ubuntu; Description: Ubuntu 23.04; Release: 23.04; Codename: lunar;
• Game Version: 8f34053 [64-bit]
• Graphics Version: Tiles
• LAPI Version: 1
• Game Language: English [en_US]
• Mods loaded: [
  Bright Nights [bn],
  Disable NPC Needs [no_npc_food],
  Simplified Nutrition [novitamins],
  No Rail Stations [No_Rail_Stations],
  Elevated bridges [elevated_bridges]
  ]

Additional context

crash.log
debug.log

Default.tar.gz

[scarf005]

cc @OrenAudeles could this be related to #3283?

[scarf005]

no wait, it's ancient, this is reproducible since 1efef0f (and who knows how long have this bug been staying around)