Rubocop formatting does not work #83

gencer · 2018-10-12T09:50:40Z

I want to fix, clean and format my *.rb files when I press Format Document. However, it doesn't work. It was working before but today I want to format few files and it just doesn't work.

.solargraph.yml:

	---
	include:
	- "**/*.rb"
	exclude:
	- spec/**/*
	- test/**/*
	- vendor/**/*
	- ".bundle/**/*"
	require: []
	domains: []
	reporters:
	- rubocop
	- require_not_found
	plugins:
	- runtime
	max_files: 5000

No rubocop.yml file present in folder. Simply press F1 and select Format Document. ruby.exe starts in the background and exits after few seconds. No formatting done to the document. No logs (including in debug console) indicating any error. This is my settings:

	// "ruby.format": "rubocop",
	"solargraph.formatting": true,
	"editor.formatOnSave": true,
	"files.insertFinalNewline": true,
	"files.autoSave": "onFocusChange",
	"ruby.lint": {
		"reek": false,
		"rubocop": {
			"lint": true,
			"rails": true
		},
		"ruby": {
			"unicode": true
		},
		"fasterer": false,
		"debride": false,
		"ruby-lint": false
	},
	"editor.formatOnSaveTimeout": 20000,
	"[ruby]": {
		"editor.formatOnSave": true
	},

VScode + OS Env:

	Version: 1.28.1 (user setup)
	Commit: 3368db6750222d319c851f6d90eb619d886e08f5
	Date: 2018-10-11T18:13:53.910Z
	Electron: 2.0.9
	Chrome: 61.0.3163.100
	Node.js: 8.9.3
	V8: 6.1.534.41
	Architecture: x64 Windows 10

The text was updated successfully, but these errors were encountered:

castwide · 2018-10-12T11:01:33Z

Confirmed. The server responds with the formatted document and a null range, which is supposed to mean that the whole document should be replaced. Apparently the client ignores edits without ranges. I'll fix it in the gem for the next release.

gencer · 2018-10-12T11:07:52Z

@castwide, Thank you so much. I was driving nuts by thinking if I did something wrong with config.

Hopefully, wait for a fix now.

Gencer.

castwide · 2018-10-22T16:58:42Z

Fixed in gem v0.28.3.

gencer · 2018-10-22T23:14:52Z

@castwide , I do not know what other fixes/additions other than this fix happen in master branch but at the moment everytime I open VSCode and work on Ruby, solargraph (actually ruby.exe) terminates itself. "Restart solargraph" does not work either.

gencer · 2018-10-22T23:15:51Z

This is only output i can find at the moment:

[2018-10-23 02:03:11.866] [renderer5] [info] no standard startup: not just one window
[2018-10-23 02:03:27.727] [renderer5] [error] An unknown error occurred. Please consult the log for more details.
[2018-10-23 02:07:17.716] [renderer5] [error] Connection is closed.: Error: Connection is closed.
    at new ConnectionError (C:\Users\gence\.vscode\extensions\castwide.solargraph-0.17.6\node_modules\vscode-jsonrpc\lib\main.js:138:28)
    at throwIfClosedOrDisposed (C:\Users\gence\.vscode\extensions\castwide.solargraph-0.17.6\node_modules\vscode-jsonrpc\lib\main.js:613:19)
    at Object.sendNotification (C:\Users\gence\.vscode\extensions\castwide.solargraph-0.17.6\node_modules\vscode-jsonrpc\lib\main.js:667:13)
    at C:\Users\gence\.vscode\extensions\castwide.solargraph-0.17.6\node_modules\vscode-jsonrpc\lib\main.js:783:32
    at e.fire (c:\Users\gence\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:99:496)
    at e.cancel (c:\Users\gence\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:106:331)
    at e.cancel (c:\Users\gence\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:107:51)
    at Object.l (c:\Users\gence\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:639:104)
    at t._receiveCancel (c:\Users\gence\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:639:864)
    at t._receiveOneMessage (c:\Users\gence\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:638:387)
    at c:\Users\gence\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:635:926
    at c:\Users\gence\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:98:138
    at e.fire (c:\Users\gence\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:99:496)
    at a (c:\Users\gence\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:154:213)
    at Socket._socketDataListener (c:\Users\gence\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:154:432)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at addChunk (_stream_readable.js:263:12)
    at readableAddChunk (_stream_readable.js:250:11)
    at Socket.Readable.push (_stream_readable.js:208:10)
    at Pipe.onread (net.js:594:20)

castwide · 2018-10-22T23:54:37Z

One possibility: can you tell me the results of gem list eventmachine?

gencer · 2018-10-23T00:03:48Z

gence@GENCER MINGW64 ~/Desktop
$ gem list eventmachine
eventmachine (1.2.7)

I always uninstall eventmachine and install with system libraries as stated in README. When eventmachine is wrong, Solargraph doesnt even start. In my case, it starts, works for a while then ruby.exe exits.

castwide · 2018-10-23T00:16:48Z

The only time I've seen that happen is in an experimental version of the extension that uses a stdio transport. This is the first time I've seen anything similar with the socket transport.

Does it happen with any workspace you open? How about a single ruby file without a workspace?

castwide · 2018-10-23T00:56:31Z

Also, one other thing you can try is removing the experimental runtime plugin from your .solargraph.yml file. I don't know if it's the cause here, but it has some known issues.

gencer · 2018-10-23T01:07:25Z

Let me try both with another project and without runtime and report back. I do not want to report without being sure. If this happens again I will raise a new issue and link here.

castwide · 2018-10-24T08:27:18Z

@gencer I may have found the issue. The server crashes intermittently while generating additional documentation for completion items. Best I can tell, it's an access violation due to some component in the RDoc library that's not thread-safe. That would explain why you and I encounter the same bug under different circumstances.

I'll fast-track a fix and update the gem in a day or so.

gencer · 2018-10-24T10:00:54Z

@castwide, I was going to update here and saw your reply. I tested and;

It crashes on every project/workspace
runtime doesn't change anything.

I will follow on #97

Thank you for the reply.

gencer · 2018-11-18T16:51:46Z

I got it again:

[Error - 7:48:27 PM] Connection to server is erroring. Shutting down server.
... repeated ...

This is happen usually and especially two or more projects are open at the same time.

Any log in anywhere?

gencer · 2018-11-18T17:00:23Z

@castwide, one more thing. I am not sure if this log entry belongs to your gem but I got this:

[Error - 7:40:05 PM] Request textDocument/completion failed.
  Message: [SystemStackError] stack level too deep
  Code: -32603 
[Error - 7:58:59 PM] Connection to server is erroring. Shutting down server.
[Error - 7:58:59 PM] Connection to server is erroring. Shutting down server.
[Error - 7:58:59 PM] Connection to server is erroring. Shutting down server.
[Error - 7:58:59 PM] Connection to server is erroring. Shutting down server.
[Error - 7:58:59 PM] Connection to server is erroring. Shutting down server.
[Error - 7:58:59 PM] Connection to server is erroring. Shutting down server.

castwide · 2018-11-18T17:35:57Z

The stack level too deep message looks like it came from the server while trying to provide completion suggestions for something you recently typed. Any chance you can identify a snippet of code where it happens?

There might be more information in the console (Help -> Toggle Developer Tools).

gencer · 2018-11-18T18:13:01Z

Unfortunately, there is no any log in developer tools rather than I sent above.

Usually happens when I work inside each blocks. Like;

folders.each do |f|
 ...
end

gencer · 2018-11-18T19:16:16Z

@castwide, I've finally reproduced it. Here is anew GIF: (it's 1MB so maybe slow to load)

Probably when I copy/paste or edit such blocks, solargraph get crashed. This happens all the time.

Also in zip:
first.zip

castwide · 2018-11-18T23:17:28Z

@gencer Thanks. I haven't been able to reproduce it yet, but I think we're getting closer.

I tried a few different ways of copy/pasting blocks in code, including variations that result in parse errors. Nothing so far.

If you can share the file where it happens, or point me to a GitHub repo that contains the code, that might help, but I understand if it's not an option.

gencer · 2018-11-19T07:43:18Z

@castwide. This is what I did:

I copied this file outside of my project and open a fresh visual studio.
I dropped that file to VSCode and tried above behavior. Simply copy paste between (and including) Lines 386 - 394. r select those lines and press "m" from keyboard then Ctrl+Z (Revert).
This will cause stack level too deep error. If you do this second time, server will close.

But if I try this code block only outside of that file then it works without problem. This means there is an another thing that trigger this error.

Do you have an email? I can send you that file privately. Or how can I transfer that file to you privately?

Gencer.

gencer · 2018-11-19T07:44:09Z

Update: I found your email on your profile and send to you.

castwide · 2018-11-19T15:22:04Z

@gencer I'm finally able to reproduce the error following the steps you posted with the file you sent. Now I'll get to work on tracking down the root cause. With any luck, I can have a fix released within a week or so. Thanks again for all your help.

gencer · 2018-11-19T15:29:25Z

@castwide, I'm glad I could help. Let me know if anything needed!

Awaiting for your fixes.

Thanks,
Gencer.

castwide · 2018-11-21T03:25:36Z

The root cause turned out to be a bug in how AST nodes are generated for code with unrecoverable syntax errors. It worked most of the time by sheer coincidence, but in rare instances it would result in recursive trees.

The fix is in the master branch and will be released in gem version 0.29.0.

gencer · 2018-11-21T09:54:47Z

I've tested master branch and yeah, it worked! No more crashes.

Thank you so much, Fred, for your awesome gem and help.

(P.S.: If I encounter any problem again, I will ping here and send you the whole file via email if necessary)

castwide · 2018-11-29T16:40:16Z

The fix is published in gem v0.29.0.

dogweather · 2018-12-28T22:30:09Z

Could you please close this issue?

castwide mentioned this issue Oct 24, 2018

Server crashes intermittently castwide/solargraph#97

Closed

castwide closed this as completed Dec 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rubocop formatting does not work #83

Rubocop formatting does not work #83

gencer commented Oct 12, 2018 •

edited

Loading

castwide commented Oct 12, 2018

gencer commented Oct 12, 2018

castwide commented Oct 22, 2018

gencer commented Oct 22, 2018

gencer commented Oct 22, 2018

castwide commented Oct 22, 2018

gencer commented Oct 23, 2018

castwide commented Oct 23, 2018

castwide commented Oct 23, 2018

gencer commented Oct 23, 2018

castwide commented Oct 24, 2018

gencer commented Oct 24, 2018

gencer commented Nov 18, 2018 •

edited

Loading

gencer commented Nov 18, 2018

castwide commented Nov 18, 2018

gencer commented Nov 18, 2018

gencer commented Nov 18, 2018

castwide commented Nov 18, 2018

gencer commented Nov 19, 2018

gencer commented Nov 19, 2018

castwide commented Nov 19, 2018

gencer commented Nov 19, 2018

castwide commented Nov 21, 2018

gencer commented Nov 21, 2018

castwide commented Nov 29, 2018

dogweather commented Dec 28, 2018

Rubocop formatting does not work #83

Rubocop formatting does not work #83

Comments

gencer commented Oct 12, 2018 • edited Loading

castwide commented Oct 12, 2018

gencer commented Oct 12, 2018

castwide commented Oct 22, 2018

gencer commented Oct 22, 2018

gencer commented Oct 22, 2018

castwide commented Oct 22, 2018

gencer commented Oct 23, 2018

castwide commented Oct 23, 2018

castwide commented Oct 23, 2018

gencer commented Oct 23, 2018

castwide commented Oct 24, 2018

gencer commented Oct 24, 2018

gencer commented Nov 18, 2018 • edited Loading

gencer commented Nov 18, 2018

castwide commented Nov 18, 2018

gencer commented Nov 18, 2018

gencer commented Nov 18, 2018

castwide commented Nov 18, 2018

gencer commented Nov 19, 2018

gencer commented Nov 19, 2018

castwide commented Nov 19, 2018

gencer commented Nov 19, 2018

castwide commented Nov 21, 2018

gencer commented Nov 21, 2018

castwide commented Nov 29, 2018

dogweather commented Dec 28, 2018

gencer commented Oct 12, 2018 •

edited

Loading

gencer commented Nov 18, 2018 •

edited

Loading