Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome Picker Source from onChange is always RGB #648

Closed
JCron245 opened this issue Oct 5, 2019 · 2 comments · Fixed by #671
Closed

Chrome Picker Source from onChange is always RGB #648

JCron245 opened this issue Oct 5, 2019 · 2 comments · Fixed by #671

Comments

@JCron245
Copy link

JCron245 commented Oct 5, 2019

I thought the intent of the 'source' key in the onChange event was to show which 'editable field' is in use by the Chrome Picker but it always returns 'rgb'. Am I misunderstanding the usage, or is there a bug?
@casesandberg casesandberg mentioned this issue Jan 11, 2020
Merged
@casesandberg
Copy link
Owner

This is definitely a bug. Putting a fix up for it now!

@stanislav-grin
Copy link

After the fix it's always hsv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Color Source Bug on Saturation and Hue casesandberg/react-color
3 participants
@JCron245 @casesandberg @stanislav-grin