Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mago lint does not return exit code 1 #61

Closed
thyseus opened this issue Jan 29, 2025 · 1 comment
Closed

mago lint does not return exit code 1 #61

thyseus opened this issue Jan 29, 2025 · 1 comment
Assignees
Labels
Priority: Critical This should be dealt with ASAP. Not fixing would be a serious error. Status: Closed This issue is closed and no more work is planned. Type: Bug An issue causing unintended or problematic behavior.

Comments

@thyseus
Copy link

thyseus commented Jan 29, 2025

🐞 Describe the Bug

I run mago lint and have errors in my project. I expect the exit code to be 1.
(or at least not 0) so scripts and CI/CD pipelines will fail when there are errors.

🔄 Steps to Reproduce

Run mago lint when having errors in your code.

⚙️ Configuration (mago.toml)

[source]
paths = ["app", "bootstrap", "config", "operations", "database", "tests"]
includes = ["vendor"]

📜 Command Output

vendor/bin/mago lint

📂 PHP Code Sample (If Applicable)

🖥️ Operating System

Linux

📦 How did you install Mago?

Composer (composer require carthage-software/mago)

📝 Additional Context

Sorry if i have missed an option.

Found nothing in the documentation. If its there, please consider making the option more prominent.

Even if it is possible to configure the behavior, the default behavior should be exit code 1 in case of errors.

@thyseus thyseus added the Type: Bug An issue causing unintended or problematic behavior. label Jan 29, 2025
@azjezz azjezz added Priority: Critical This should be dealt with ASAP. Not fixing would be a serious error. Status: In Progress This issue is being worked on and has someone assigned. labels Jan 29, 2025
@azjezz
Copy link
Member

azjezz commented Jan 29, 2025

Fixed and released as 0.6.1.

Sorry for the trouble!

https://github.com/carthage-software/mago/releases/tag/0.6.1

@azjezz azjezz closed this as completed Jan 29, 2025
@azjezz azjezz added Status: Closed This issue is closed and no more work is planned. and removed Status: In Progress This issue is being worked on and has someone assigned. labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Critical This should be dealt with ASAP. Not fixing would be a serious error. Status: Closed This issue is closed and no more work is planned. Type: Bug An issue causing unintended or problematic behavior.
Projects
None yet
Development

No branches or pull requests

2 participants