Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Makefile and CI #66

Open
mpolitzer opened this issue May 30, 2023 · 0 comments
Open

Refactor Makefile and CI #66

mpolitzer opened this issue May 30, 2023 · 0 comments
Assignees
@mpolitzer
Labels
refactor Restructuring code, while not changing its original functionality
Milestone
v0.19.0

Comments

@mpolitzer
Copy link
Contributor

mpolitzer commented May 30, 2023 •
edited
Loading

Context

Makefile could use some improvements.

  • install-emulator is the target responsible for variable substitutions in scripts via sed calls when doing installation. This could be simplified by using envsubst to do the replacement for us.
  • INSTALL= cp -RP is being used together with mkdir instead of the install tool.

envsubst is on gettext-base for debian

CI

  • remove instances of patchelf, it is not necessary with proper use of DESTDIR and PREFIX (introduced in Added deb package #67)

Possible solutions

Use envsubst and install
@mpolitzer mpolitzer added the refactor Restructuring code, while not changing its original functionality label May 30, 2023
@mpolitzer mpolitzer changed the title Consider replacing sed by envsubst in Makefile:install-emulator Refactor Makefile May 31, 2023
@edubart edubart moved this to Todo in Machine Emulator SDK May 31, 2023
@mpolitzer mpolitzer changed the title Refactor Makefile Refactor Makefile and CI Jun 2, 2023
@edubart edubart added this to the v0.19.0 milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpolitzer mpolitzer

Labels
refactor Restructuring code, while not changing its original functionality
Projects
Machine Emulator SDK
Status: Todo
Milestone
v0.19.0
Development

No branches or pull requests
2 participants
@mpolitzer @edubart