From 1a3674ab418fac4c8e7e62c32b764cd40fe0c43e Mon Sep 17 00:00:00 2001 From: Tyler Yahn Date: Fri, 31 May 2024 10:40:07 -0700 Subject: [PATCH] Clarify the trace SDK should log discarded events and links (#4064) --- CHANGELOG.md | 3 +++ specification/trace/sdk.md | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 653d45d89d6..33ed10f55c0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,9 @@ release. ### Traces +- Clarify the trace SDK should log discarded events and links. + ([#4064](https://github.com/open-telemetry/opentelemetry-specification/pull/4064)) + ### Metrics ### Logs diff --git a/specification/trace/sdk.md b/specification/trace/sdk.md index d9d58aaedd9..feb2933d443 100644 --- a/specification/trace/sdk.md +++ b/specification/trace/sdk.md @@ -495,7 +495,7 @@ public final class SpanLimits { * `AttributePerLinkCountLimit` (Default=128) - Maximum allowed attribute per span link count; There SHOULD be a message printed in the SDK's log to indicate to the user -that an attribute was discarded due to such a limit. +that an attribute, event, or link was discarded due to such a limit. To prevent excessive logging, the message MUST be printed at most once per span (i.e., not per discarded attribute, event, or link).