Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with being unable to deserialise parties resulting in fatal error #1856

Closed
noonio opened this issue Feb 14, 2025 · 1 comment · Fixed by #1857
Closed

Fix bug with being unable to deserialise parties resulting in fatal error #1856

noonio opened this issue Feb 14, 2025 · 1 comment · Fixed by #1857

Comments

@noonio
Copy link
Contributor

noonio commented Feb 14, 2025

As part of #1282 we noticed that 0.19 on preprod is, we think, trying to deserialise a party key -

maybe (error "TODO: SerialiseAsRawBytesError, but constructor not exported") (Right . HydraVerificationKey) (rawDeserialiseVerKeyDSIGN bs)
- and hits the error case there.

Because it's an error, it entirely crashes the Hydra process, and prevents the chain-observer from being able to make observations.

Perhaps we need to represent "invalid" head states like this one a bit more explicitlly; i.e. it's still a Hydra head, but with an unparseable head participant.

Options:

  • Just drop the unparsable party, instead of crashing (and at least log an error instead of dieing entirely),
  • Represent unparsable parties differently; i.e. data Party = ValidParty Party | BadParty ....
  • Represent the entire head state differently, if one of the parties fails parsing ...
  • ???

Context

This error was observed with the 0.19 hydra-chain-observer and deployed from this commit over on the hydra-explorer repo - docker-compose,yaml @ relevant version.

In particular it was observed through docker logs ... of the relevant image; and even more in particular docker logs prints any errors it sees to stderr`; so you can get all the relevant information like:

docker logs hydra-explorer-hydra-chain-observer-preprod-0.19-1 >logs.txt 2>&1
@noonio noonio converted this from a draft issue Feb 14, 2025
@noonio noonio moved this from Todo 📋 to In progress 🕐 in ☕ Hydra Team Work Feb 14, 2025
@ch1bo
Copy link
Member

ch1bo commented Feb 14, 2025

We don't know whether it is a head transaction that was tried to parse!

  • Not use error -> Yes
  • Changing Party data type -> No

@noonio can you include steps to reproduce please? i.e. which commit, which binary, how we observed this.

@ch1bo ch1bo linked a pull request Feb 14, 2025 that will close this issue
4 tasks
@github-project-automation github-project-automation bot moved this from In progress 🕐 to Done ✔ in ☕ Hydra Team Work Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants