Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add floating-ui to ButtonSetWithOverflow #5491

Closed
2 tasks
Tracked by #6121
elycheea opened this issue Jun 13, 2024 · 2 comments
Closed
2 tasks
Tracked by #6121

Add floating-ui to ButtonSetWithOverflow #5491

elycheea opened this issue Jun 13, 2024 · 2 comments
Assignees

Comments

@elycheea
Copy link
Contributor

elycheea commented Jun 13, 2024

At smaller screen sizes (use containerWidth in Storybook to demonstrate), ButtonSetWithOverflow collapses to use MenuButton.

Verify that Carbon version with MenuButton floating UI is updated in our library. Blocked until @carbon/react adds support for floating ui to OverflowMenu.

Tasks

Preview Give feedback
@elycheea
Copy link
Contributor Author

floating-ui was been added to the new OverflowMenu. Will open an issue for adopting the v12 overflow menu.

@amal-k-joy
Copy link
Contributor

Closing this as not planned.
As we analysed, ButtonSetWithOverflow component uses carbon MenuButton rather than Overflowmenu and
enable-v12-overflowmenu feature flag is not available for MenuButton.
Also we can explore more and adopt floating UI in the new PageHeader V2.

@github-project-automation github-project-automation bot moved this from In progress to Done 🚀 in Carbon for IBM Products Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants