From 535e87142413695c530952f7b314201c8a35becc Mon Sep 17 00:00:00 2001 From: Afsal K Date: Fri, 15 Nov 2024 23:58:16 +0530 Subject: [PATCH 1/9] fix(APIKeyModal): implement focus return to generate button (#6440) * fix(APIKeyModal): implement focus return * test(APIKeyModal): implement test for focus return --------- Co-authored-by: Nandan Devadula <47176249+devadula-nandan@users.noreply.github.com> --- .../APIKeyModal/APIKeyModal.stories.jsx | 30 +++++++++--- .../APIKeyModal/APIKeyModal.test.js | 47 +++++++++++++++++++ .../components/APIKeyModal/APIKeyModal.tsx | 17 ++++++- .../APIKeyModal/APIKeyModal.types.ts | 6 ++- 4 files changed, 92 insertions(+), 8 deletions(-) diff --git a/packages/ibm-products/src/components/APIKeyModal/APIKeyModal.stories.jsx b/packages/ibm-products/src/components/APIKeyModal/APIKeyModal.stories.jsx index 28dd6f748f..f65a7487da 100644 --- a/packages/ibm-products/src/components/APIKeyModal/APIKeyModal.stories.jsx +++ b/packages/ibm-products/src/components/APIKeyModal/APIKeyModal.stories.jsx @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -import React, { useState } from 'react'; +import React, { useRef, useState } from 'react'; import { Button, TextInput, @@ -85,6 +85,7 @@ const blockClass = `${pkg.prefix}--apikey-modal`; const InstantTemplate = (args) => { const [open, setOpen] = useState(false); const [loading, setLoading] = useState(false); + const buttonRef = useRef(undefined); const generateKey = async () => { setLoading(true); @@ -96,7 +97,12 @@ const InstantTemplate = (args) => { return ( <> - setOpen(false)} open={open} /> + setOpen(false)} + open={open} + launcherButtonRef={buttonRef} + /> {loading ? ( ) : ( - + )} ); @@ -117,6 +125,7 @@ const TemplateWithState = (args) => { const [apiKey, setApiKey] = useState(''); const [loading, setLoading] = useState(false); const [fetchError, setFetchError] = useState(false); + const buttonRef = useRef(undefined); // eslint-disable-next-line const submitHandler = async (apiKeyName) => { @@ -148,8 +157,11 @@ const TemplateWithState = (args) => { onRequestGenerate={submitHandler} open={open} error={fetchError} + launcherButtonRef={buttonRef} /> - + ); }; @@ -166,6 +178,7 @@ const MultiStepTemplate = (args) => { const [open, setOpen] = useState(false); const [apiKey, setApiKey] = useState(''); const [loading, setLoading] = useState(false); + const buttonRef = useRef(undefined); // multi step options const [name, setName] = useState(savedName); @@ -310,8 +323,9 @@ const MultiStepTemplate = (args) => { customSteps={steps} nameRequired={false} editSuccess={editSuccess} + launcherButtonRef={buttonRef} /> - @@ -324,6 +338,7 @@ const EditTemplate = (args) => { const [loading, setLoading] = useState(false); const [fetchError, setFetchError] = useState(false); const [fetchSuccess, setFetchSuccess] = useState(false); + const buttonRef = useRef(undefined); const submitHandler = async () => { action(`submitted ${apiKeyName}`)(); @@ -357,8 +372,11 @@ const EditTemplate = (args) => { open={open} error={fetchError} editSuccess={fetchSuccess} + launcherButtonRef={buttonRef} /> - + ); }; diff --git a/packages/ibm-products/src/components/APIKeyModal/APIKeyModal.test.js b/packages/ibm-products/src/components/APIKeyModal/APIKeyModal.test.js index b46f110f76..0e69271bec 100644 --- a/packages/ibm-products/src/components/APIKeyModal/APIKeyModal.test.js +++ b/packages/ibm-products/src/components/APIKeyModal/APIKeyModal.test.js @@ -17,6 +17,7 @@ import React from 'react'; import { carbon } from '../../settings'; import { APIKeyModal } from '.'; +import { Button } from '@carbon/react'; Object.assign(navigator, { clipboard: { @@ -302,6 +303,52 @@ describe(componentName, () => { expect(step1InputB).toHaveFocus(); }); + it('should return focus to the generate button', async () => { + const onOpen = jest.fn(() => false); + const onClose = jest.fn(() => true); + + // eslint-disable-next-line react/prop-types + const DummyComponent = ({ open }) => { + const buttonRef = React.useRef(undefined); + + return ( + <> + + + + ); + }; + + const { getByText, rerender } = render(); + + const launchButtonEl = getByText('Generate'); + expect(launchButtonEl).toBeInTheDocument(); + + await act(() => userEvent.click(launchButtonEl)); + expect(onOpen).toHaveBeenCalled(); + + rerender(); + + const closeButton = getByText(defaultProps.closeButtonText); + await act(() => new Promise((resolve) => setTimeout(resolve, 0))); + expect(closeButton).toBeInTheDocument(); + + await act(() => userEvent.click(closeButton)); + expect(onClose).toHaveBeenCalled(); + + rerender(); + + await act(() => new Promise((resolve) => setTimeout(resolve, 0))); + expect(launchButtonEl).toHaveFocus(); + }); + it('successfully edits', async () => { const { change } = fireEvent; const { click } = userEvent; diff --git a/packages/ibm-products/src/components/APIKeyModal/APIKeyModal.tsx b/packages/ibm-products/src/components/APIKeyModal/APIKeyModal.tsx index 847aed8762..5e2b48217f 100644 --- a/packages/ibm-products/src/components/APIKeyModal/APIKeyModal.tsx +++ b/packages/ibm-products/src/components/APIKeyModal/APIKeyModal.tsx @@ -35,7 +35,7 @@ import { getDevtoolsProps } from '../../global/js/utils/devtools'; import { isRequiredIf } from '../../global/js/utils/props-helper'; import uuidv4 from '../../global/js/utils/uuidv4'; import { APIKeyModalProps } from './APIKeyModal.types'; -import { useFocus } from '../../global/js/hooks'; +import { useFocus, usePreviousValue } from '../../global/js/hooks'; import { getSpecificElement } from '../../global/js/hooks/useFocus'; const componentName = 'APIKeyModal'; @@ -78,6 +78,7 @@ export let APIKeyModal: React.FC = forwardRef( hasAPIKeyVisibilityToggle, hasDownloadLink, hideAPIKeyLabel, + launcherButtonRef, loading, loadingText, modalLabel, @@ -125,6 +126,7 @@ export let APIKeyModal: React.FC = forwardRef( modalRef, selectorPrimaryFocus ); + const prevOpen = usePreviousValue(open); useEffect(() => { if (copyRef.current && open && apiKeyLoaded) { @@ -159,6 +161,14 @@ export let APIKeyModal: React.FC = forwardRef( } }, [firstElement, modalRef, open, selectorPrimaryFocus]); + useEffect(() => { + if (prevOpen && !open && launcherButtonRef) { + setTimeout(() => { + launcherButtonRef.current.focus(); + }, 0); + } + }, [launcherButtonRef, open, prevOpen]); + const isPrimaryButtonDisabled = () => { if (loading) { return true; @@ -517,6 +527,11 @@ APIKeyModal.propTypes = { * label text that's displayed when hovering over visibility toggler to hide key */ hideAPIKeyLabel: PropTypes.string, + /** + * Provide a ref to return focus to once the tearsheet is closed. + */ + /**@ts-ignore */ + launcherButtonRef: PropTypes.any, /** * designates if the modal is in a loading state via a request or some other in progress operation */ diff --git a/packages/ibm-products/src/components/APIKeyModal/APIKeyModal.types.ts b/packages/ibm-products/src/components/APIKeyModal/APIKeyModal.types.ts index 0297bcfd43..200528760a 100644 --- a/packages/ibm-products/src/components/APIKeyModal/APIKeyModal.types.ts +++ b/packages/ibm-products/src/components/APIKeyModal/APIKeyModal.types.ts @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -import { ReactNode } from 'react'; +import { ReactNode, RefObject } from 'react'; interface APIKeyModalCommonProps { /** @@ -94,6 +94,10 @@ interface APIKeyModalCommonProps { * label text that's displayed when hovering over visibility toggler to hide key */ hideAPIKeyLabel?: string; + /** + * Provide a ref to return focus to once the tearsheet is closed. + */ + launcherButtonRef?: RefObject; /** * designates if the modal is in a loading state via a request or some other in progress operation */ From b9e1f976a6bc13501749a7e4f1294d7fe366981c Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri, 15 Nov 2024 13:40:17 -0500 Subject: [PATCH 2/9] chore(release): publish [skip ci] (#6447) - jest-config-ibm-cloud-cognitive@1.13.0-rc.1 - @carbon/storybook-addon-theme@2.3.0-rc.1 - @carbon/ibm-cloud-cognitive-core@2.30.0-rc.1 - @carbon/ibm-products@2.54.0-rc.1 - @carbon/ibm-products-styles@2.50.0-rc.1 - @carbon/ibm-products-web-components@0.3.0-rc.1 Co-authored-by: carbon-bot Co-authored-by: elysia --- .../CHANGELOG.md | 14 ++ .../package.json | 2 +- .../storybook-addon-carbon-theme/CHANGELOG.md | 8 ++ .../storybook-addon-carbon-theme/package.json | 2 +- packages/core/CHANGELOG.md | 22 +++ packages/core/package.json | 4 +- packages/ibm-products-styles/CHANGELOG.md | 43 ++++++ packages/ibm-products-styles/package.json | 4 +- .../ibm-products-web-components/CHANGELOG.md | 22 +++ .../ibm-products-web-components/package.json | 4 +- packages/ibm-products/CHANGELOG.md | 127 ++++++++++++++++++ packages/ibm-products/package.json | 6 +- yarn.lock | 12 +- 13 files changed, 253 insertions(+), 17 deletions(-) diff --git a/config/jest-config-ibm-cloud-cognitive/CHANGELOG.md b/config/jest-config-ibm-cloud-cognitive/CHANGELOG.md index e2203c2b24..640c71cd83 100644 --- a/config/jest-config-ibm-cloud-cognitive/CHANGELOG.md +++ b/config/jest-config-ibm-cloud-cognitive/CHANGELOG.md @@ -3,6 +3,20 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [1.13.0-rc.1](https://github.com/carbon-design-system/ibm-products/compare/jest-config-ibm-cloud-cognitive@1.7.0-rc.0...jest-config-ibm-cloud-cognitive@1.13.0-rc.1) (2024-11-15) + + +### Bug Fixes + +* adds html output for coverage reporting ([#6150](https://github.com/carbon-design-system/ibm-products/issues/6150)) ([beaa94c](https://github.com/carbon-design-system/ibm-products/commit/beaa94c98a2df75f6773d810726fe1b6522658d2)) +* adds typescript to coverage report ([#6140](https://github.com/carbon-design-system/ibm-products/issues/6140)) ([2466c5b](https://github.com/carbon-design-system/ibm-products/commit/2466c5bb001f18ad065eb669f380cd32db0d0bfc)) +* temp workaround for target_spacing_sufficient rule ([#6166](https://github.com/carbon-design-system/ibm-products/issues/6166)) ([314a6d8](https://github.com/carbon-design-system/ibm-products/commit/314a6d835bc5335d750392156c6fbcdff25db85b)) +* update toHaveNoAxeViolations and remove skips ([#5955](https://github.com/carbon-design-system/ibm-products/issues/5955)) ([694128b](https://github.com/carbon-design-system/ibm-products/commit/694128bb707a2400d67e6618af3fea3f3ffba86f)) + + + + + # [1.13.0-rc.0](https://github.com/carbon-design-system/ibm-products/compare/jest-config-ibm-cloud-cognitive@1.7.0-rc.0...jest-config-ibm-cloud-cognitive@1.13.0-rc.0) (2024-11-11) diff --git a/config/jest-config-ibm-cloud-cognitive/package.json b/config/jest-config-ibm-cloud-cognitive/package.json index 3832387ba7..e675a9d87c 100644 --- a/config/jest-config-ibm-cloud-cognitive/package.json +++ b/config/jest-config-ibm-cloud-cognitive/package.json @@ -1,7 +1,7 @@ { "name": "jest-config-ibm-cloud-cognitive", "private": true, - "version": "1.13.0-rc.0", + "version": "1.13.0-rc.1", "license": "Apache-2.0", "main": "index.js", "repository": { diff --git a/config/storybook-addon-carbon-theme/CHANGELOG.md b/config/storybook-addon-carbon-theme/CHANGELOG.md index 0b2f19ef04..98d3fb7ed8 100644 --- a/config/storybook-addon-carbon-theme/CHANGELOG.md +++ b/config/storybook-addon-carbon-theme/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [2.3.0-rc.1](https://github.com/carbon-design-system/ibm-products/compare/@carbon/storybook-addon-theme@2.1.0...@carbon/storybook-addon-theme@2.3.0-rc.1) (2024-11-15) + +**Note:** Version bump only for package @carbon/storybook-addon-theme + + + + + # [2.3.0-rc.0](https://github.com/carbon-design-system/ibm-products/compare/@carbon/storybook-addon-theme@2.1.0...@carbon/storybook-addon-theme@2.3.0-rc.0) (2024-11-11) **Note:** Version bump only for package @carbon/storybook-addon-theme diff --git a/config/storybook-addon-carbon-theme/package.json b/config/storybook-addon-carbon-theme/package.json index a8fd1b0eda..56ac2e238b 100644 --- a/config/storybook-addon-carbon-theme/package.json +++ b/config/storybook-addon-carbon-theme/package.json @@ -1,7 +1,7 @@ { "name": "@carbon/storybook-addon-theme", "description": "Carbon theme switcher for Storybook", - "version": "2.3.0-rc.0", + "version": "2.3.0-rc.1", "license": "Apache-2.0", "main": "dist/react.js", "repository": { diff --git a/packages/core/CHANGELOG.md b/packages/core/CHANGELOG.md index 9b38809315..692d2102a7 100644 --- a/packages/core/CHANGELOG.md +++ b/packages/core/CHANGELOG.md @@ -3,6 +3,28 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [2.30.0-rc.1](https://github.com/carbon-design-system/ibm-products/compare/@carbon/ibm-cloud-cognitive-core@2.24.0-rc.0...@carbon/ibm-cloud-cognitive-core@2.30.0-rc.1) (2024-11-15) + + +### Bug Fixes + +* correctly renders component when using feature flags ([#6357](https://github.com/carbon-design-system/ibm-products/issues/6357)) ([c04f635](https://github.com/carbon-design-system/ibm-products/commit/c04f63508bb0f43d6b31dcf983d0cd9ac6083a06)) +* move config to core to follow monorepo docs w/ multiple sites ([#6196](https://github.com/carbon-design-system/ibm-products/issues/6196)) ([fa285b7](https://github.com/carbon-design-system/ibm-products/commit/fa285b743bff65577aece8ebddad6e3a75dff85e)) +* update Carbon 11 compatible versions to latest ([#6054](https://github.com/carbon-design-system/ibm-products/issues/6054)) ([0ac7669](https://github.com/carbon-design-system/ibm-products/commit/0ac76692a6eeb85655ca64ca9189297708e26bd9)) +* update to Carbon 11 compatible versions to latest ([#5987](https://github.com/carbon-design-system/ibm-products/issues/5987)) ([173e6c6](https://github.com/carbon-design-system/ibm-products/commit/173e6c6455a4fe619d56148ab432926bc6c640a4)) +* update to Carbon 11 compatible versions to latest ([#6214](https://github.com/carbon-design-system/ibm-products/issues/6214)) ([911c341](https://github.com/carbon-design-system/ibm-products/commit/911c341d258b410ff2109ecb39293c2670796a0e)) +* update to Carbon 11 compatible versions to latest ([#6343](https://github.com/carbon-design-system/ibm-products/issues/6343)) ([71a201a](https://github.com/carbon-design-system/ibm-products/commit/71a201a50fbebe76699ffb0d7df1d2d998370256)) + + +### Features + +* add conditional deploys for web component and react netlify sites ([#6221](https://github.com/carbon-design-system/ibm-products/issues/6221)) ([8a4255c](https://github.com/carbon-design-system/ibm-products/commit/8a4255c0a0269068f66018d215a7bc07d3015f25)) +* **Tearsheet:** Move Tearsheet into @carbon/ibm-products-web-components ([#6204](https://github.com/carbon-design-system/ibm-products/issues/6204)) ([c21d102](https://github.com/carbon-design-system/ibm-products/commit/c21d102de17c311421884ddc17065f81e2c0f44a)) + + + + + # [2.30.0-rc.0](https://github.com/carbon-design-system/ibm-products/compare/@carbon/ibm-cloud-cognitive-core@2.24.0-rc.0...@carbon/ibm-cloud-cognitive-core@2.30.0-rc.0) (2024-11-11) diff --git a/packages/core/package.json b/packages/core/package.json index 4a5c454001..741b878c78 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -1,7 +1,7 @@ { "name": "@carbon/ibm-cloud-cognitive-core", "private": true, - "version": "2.30.0-rc.0", + "version": "2.30.0-rc.1", "license": "Apache-2.0", "main": "scripts/build.js", "repository": { @@ -29,7 +29,7 @@ }, "devDependencies": { "@carbon/grid": "^11.29.0", - "@carbon/ibm-products-styles": "^2.50.0-rc.0", + "@carbon/ibm-products-styles": "^2.50.0-rc.1", "@carbon/layout": "^11.28.0", "@carbon/motion": "^11.24.0", "@carbon/react": "^1.69.0", diff --git a/packages/ibm-products-styles/CHANGELOG.md b/packages/ibm-products-styles/CHANGELOG.md index 30202d87e9..4c68eafe64 100644 --- a/packages/ibm-products-styles/CHANGELOG.md +++ b/packages/ibm-products-styles/CHANGELOG.md @@ -3,6 +3,49 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [2.50.0-rc.1](https://github.com/carbon-design-system/ibm-products/compare/@carbon/ibm-products-styles@2.44.0-rc.0...@carbon/ibm-products-styles@2.50.0-rc.1) (2024-11-15) + + +### Bug Fixes + +* **conditionBuilder:** _conditionBuilderItem.scss causing sass warnings ([#5906](https://github.com/carbon-design-system/ibm-products/issues/5906)) ([2100bd4](https://github.com/carbon-design-system/ibm-products/commit/2100bd4134628ce785c411f582cd3e5d2b53cbbb)) +* **conditionBuilder:** release review changes1 ([#6133](https://github.com/carbon-design-system/ibm-products/issues/6133)) ([d3f08bc](https://github.com/carbon-design-system/ibm-products/commit/d3f08bcd0b479a84e69fc29dfe03a931618168a7)) +* createTearsheet height fix ([#6111](https://github.com/carbon-design-system/ibm-products/issues/6111)) ([00a472f](https://github.com/carbon-design-system/ibm-products/commit/00a472fb18ccc231343f0851fbae76e9d98db300)) +* **datagrid:** adds missing header hover styles in v2 ([#6272](https://github.com/carbon-design-system/ibm-products/issues/6272)) ([2311bdb](https://github.com/carbon-design-system/ibm-products/commit/2311bdb7477e72a6cd4d7f915f6dc754874b7375)) +* **DataGrid:** column headers vertically misaligned for sortable ([#5994](https://github.com/carbon-design-system/ibm-products/issues/5994)) ([df0ade1](https://github.com/carbon-design-system/ibm-products/commit/df0ade1c26c17448aa2dd212d75e88f1c4544e61)) +* **Datagrid:** csp violation ([#5831](https://github.com/carbon-design-system/ibm-products/issues/5831)) ([73a9824](https://github.com/carbon-design-system/ibm-products/commit/73a98242150e421a7c414bf7743f453a2234caba)) +* **dataGrid:** header scroll issues ([#6135](https://github.com/carbon-design-system/ibm-products/issues/6135)) ([9d60c0c](https://github.com/carbon-design-system/ibm-products/commit/9d60c0cd0f0ab98ba87915eb50a9de2a55dff5a1)) +* editinplace replace outline with border ([#5869](https://github.com/carbon-design-system/ibm-products/issues/5869)) ([0fb5afd](https://github.com/carbon-design-system/ibm-products/commit/0fb5afd7c210e6b726f67887b8126f3f0692c106)) +* **EditInPlace:** focus and style issue ([#6146](https://github.com/carbon-design-system/ibm-products/issues/6146)) ([831a0bc](https://github.com/carbon-design-system/ibm-products/commit/831a0bc7da65e65c09228cf2b292cbb879484d3a)) +* **Pageheader:** scrollable headers are not tabbable ([#6145](https://github.com/carbon-design-system/ibm-products/issues/6145)) ([ed578ec](https://github.com/carbon-design-system/ibm-products/commit/ed578ec0d45dcd72a7c96fd1e8370d4a67019ec6)) +* remove ellipsis from EditInPlace ([#6098](https://github.com/carbon-design-system/ibm-products/issues/6098)) ([0b40cce](https://github.com/carbon-design-system/ibm-products/commit/0b40cce8451abd0e509a6b16490fff862496b414)) +* **SidePanel:** style issue with multi select ([#6123](https://github.com/carbon-design-system/ibm-products/issues/6123)) ([feb6a99](https://github.com/carbon-design-system/ibm-products/commit/feb6a993cb0971442cca80f4c7c86d90eede0bbf)) +* **TagOverflow:** use operational tag ([#6132](https://github.com/carbon-design-system/ibm-products/issues/6132)) ([791cbec](https://github.com/carbon-design-system/ibm-products/commit/791cbecb2319ce832c1a6341c0a8fbf16b76a3e0)) +* **TagSet:** modal gradient ([#4478](https://github.com/carbon-design-system/ibm-products/issues/4478)) ([459109d](https://github.com/carbon-design-system/ibm-products/commit/459109d08ca6baf6a66954dd6fa49360dc553dc6)) +* **tearsheet:** slug spacing ([#6023](https://github.com/carbon-design-system/ibm-products/issues/6023)) ([1db6688](https://github.com/carbon-design-system/ibm-products/commit/1db66886b00f9540825988c7397fe6c84411d26a)) +* these at imports should not exist ([#6359](https://github.com/carbon-design-system/ibm-products/issues/6359)) ([3ea78f2](https://github.com/carbon-design-system/ibm-products/commit/3ea78f2cefc632bfec990026418a4851b3f582f0)) +* update Carbon 11 compatible versions to latest ([#6054](https://github.com/carbon-design-system/ibm-products/issues/6054)) ([0ac7669](https://github.com/carbon-design-system/ibm-products/commit/0ac76692a6eeb85655ca64ca9189297708e26bd9)) +* update to Carbon 11 compatible versions to latest ([#5987](https://github.com/carbon-design-system/ibm-products/issues/5987)) ([173e6c6](https://github.com/carbon-design-system/ibm-products/commit/173e6c6455a4fe619d56148ab432926bc6c640a4)) +* update to Carbon 11 compatible versions to latest ([#6214](https://github.com/carbon-design-system/ibm-products/issues/6214)) ([911c341](https://github.com/carbon-design-system/ibm-products/commit/911c341d258b410ff2109ecb39293c2670796a0e)) +* update to Carbon 11 compatible versions to latest ([#6343](https://github.com/carbon-design-system/ibm-products/issues/6343)) ([71a201a](https://github.com/carbon-design-system/ibm-products/commit/71a201a50fbebe76699ffb0d7df1d2d998370256)) +* **UserAvatar:** release review fixes ([#6293](https://github.com/carbon-design-system/ibm-products/issues/6293)) ([eafbba3](https://github.com/carbon-design-system/ibm-products/commit/eafbba33b6c9630457eeb0c6d86d030ee699940f)) + + +### Features + +* **`ibm-products-web-components`:** setup new web component package and storybook ([#6148](https://github.com/carbon-design-system/ibm-products/issues/6148)) ([6962187](https://github.com/carbon-design-system/ibm-products/commit/6962187634ba4317c5a4dcbf495978a176efcb79)) +* **cards:** renames slug to aiLabel ([#6167](https://github.com/carbon-design-system/ibm-products/issues/6167)) ([5b94ed8](https://github.com/carbon-design-system/ibm-products/commit/5b94ed8d01638db747277f104d9f7dd9ab2e0eb3)) +* **ConditionBuilder:** enhancing the conditional operators section that manages the primary logic flow ([#5921](https://github.com/carbon-design-system/ibm-products/issues/5921)) ([91733fb](https://github.com/carbon-design-system/ibm-products/commit/91733fb43157eab26c885f0652adaf9276f372d4)) +* **Conditionbuilder:** renaming both variants to Hierarchical and Non-Hierarchical ([#5847](https://github.com/carbon-design-system/ibm-products/issues/5847)) ([791e2b3](https://github.com/carbon-design-system/ibm-products/commit/791e2b31549f3f4480cac2fc142e550b5e12ea31)) +* **datagrids:** Add custom batch actions display min ([#5776](https://github.com/carbon-design-system/ibm-products/issues/5776)) ([485e8bc](https://github.com/carbon-design-system/ibm-products/commit/485e8bcac3193e56d65721076160944b4e126256)) +* **Datagrid:** slug to aiLabel renaming ([#6151](https://github.com/carbon-design-system/ibm-products/issues/6151)) ([b0b3c1c](https://github.com/carbon-design-system/ibm-products/commit/b0b3c1cf40199e7458584ea1d9093224264e1f4c)) +* **tagset:** support for size on overflow tag ([#6065](https://github.com/carbon-design-system/ibm-products/issues/6065)) ([ba29c09](https://github.com/carbon-design-system/ibm-products/commit/ba29c0950f1fcc7388e58523e94a32abd588d59d)) +* **Tearsheet:** Slug to aiLabel ([#6169](https://github.com/carbon-design-system/ibm-products/issues/6169)) ([5c0f2ad](https://github.com/carbon-design-system/ibm-products/commit/5c0f2adf55e6c9c7f081dab72ab711b611593476)) + + + + + # [2.50.0-rc.0](https://github.com/carbon-design-system/ibm-products/compare/@carbon/ibm-products-styles@2.44.0-rc.0...@carbon/ibm-products-styles@2.50.0-rc.0) (2024-11-11) diff --git a/packages/ibm-products-styles/package.json b/packages/ibm-products-styles/package.json index 7ef662a384..6190ce283d 100644 --- a/packages/ibm-products-styles/package.json +++ b/packages/ibm-products-styles/package.json @@ -1,7 +1,7 @@ { "name": "@carbon/ibm-products-styles", "description": "Carbon for IBM Products styles", - "version": "2.50.0-rc.0", + "version": "2.50.0-rc.1", "license": "Apache-2.0", "installConfig": { "hoistingLimits": "none" @@ -52,7 +52,7 @@ "cross-env": "^7.0.3", "glob": "^10.3.10", "jest": "^29.7.0", - "jest-config-ibm-cloud-cognitive": "^1.13.0-rc.0", + "jest-config-ibm-cloud-cognitive": "^1.13.0-rc.1", "jest-environment-jsdom": "^29.7.0", "npm-check-updates": "^16.14.12", "npm-run-all": "^4.1.5", diff --git a/packages/ibm-products-web-components/CHANGELOG.md b/packages/ibm-products-web-components/CHANGELOG.md index dbd6a80b5c..7b1615df7e 100644 --- a/packages/ibm-products-web-components/CHANGELOG.md +++ b/packages/ibm-products-web-components/CHANGELOG.md @@ -3,6 +3,28 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# 0.3.0-rc.1 (2024-11-15) + + +### Bug Fixes + +* move config to core to follow monorepo docs w/ multiple sites ([#6196](https://github.com/carbon-design-system/ibm-products/issues/6196)) ([fa285b7](https://github.com/carbon-design-system/ibm-products/commit/fa285b743bff65577aece8ebddad6e3a75dff85e)) +* **SidePanel web components:** slide in issue ([#6301](https://github.com/carbon-design-system/ibm-products/issues/6301)) ([3f4e21a](https://github.com/carbon-design-system/ibm-products/commit/3f4e21ae04e772d6687c3295c512dd13979e9bd4)) +* update to Carbon 11 compatible versions to latest ([#6214](https://github.com/carbon-design-system/ibm-products/issues/6214)) ([911c341](https://github.com/carbon-design-system/ibm-products/commit/911c341d258b410ff2109ecb39293c2670796a0e)) +* update to Carbon 11 compatible versions to latest ([#6343](https://github.com/carbon-design-system/ibm-products/issues/6343)) ([71a201a](https://github.com/carbon-design-system/ibm-products/commit/71a201a50fbebe76699ffb0d7df1d2d998370256)) +* use plex cdn to load custom font in wc storybook ([#6213](https://github.com/carbon-design-system/ibm-products/issues/6213)) ([f85396c](https://github.com/carbon-design-system/ibm-products/commit/f85396c7dc06aa1b91039af035e96f02bd5c1ef9)) + + +### Features + +* **`ibm-products-web-components`:** setup new web component package and storybook ([#6148](https://github.com/carbon-design-system/ibm-products/issues/6148)) ([6962187](https://github.com/carbon-design-system/ibm-products/commit/6962187634ba4317c5a4dcbf495978a176efcb79)) +* add conditional deploys for web component and react netlify sites ([#6221](https://github.com/carbon-design-system/ibm-products/issues/6221)) ([8a4255c](https://github.com/carbon-design-system/ibm-products/commit/8a4255c0a0269068f66018d215a7bc07d3015f25)) +* **Tearsheet:** Move Tearsheet into @carbon/ibm-products-web-components ([#6204](https://github.com/carbon-design-system/ibm-products/issues/6204)) ([c21d102](https://github.com/carbon-design-system/ibm-products/commit/c21d102de17c311421884ddc17065f81e2c0f44a)) + + + + + # 0.3.0-rc.0 (2024-11-11) diff --git a/packages/ibm-products-web-components/package.json b/packages/ibm-products-web-components/package.json index a35a581d4e..a6de6211f6 100644 --- a/packages/ibm-products-web-components/package.json +++ b/packages/ibm-products-web-components/package.json @@ -1,7 +1,7 @@ { "name": "@carbon/ibm-products-web-components", "description": "Carbon for IBM Products Web Components", - "version": "0.3.0-rc.0", + "version": "0.3.0-rc.1", "license": "Apache-2.0", "main": "es/index.js", "module": "es/index.js", @@ -49,7 +49,7 @@ "wca": "web-component-analyzer analyze src --outFile custom-elements.json" }, "dependencies": { - "@carbon/ibm-products-styles": "^2.50.0-rc.0", + "@carbon/ibm-products-styles": "^2.50.0-rc.1", "@carbon/styles": "1.68.0", "@carbon/web-components": "2.16.0", "lit": "^3.1.0" diff --git a/packages/ibm-products/CHANGELOG.md b/packages/ibm-products/CHANGELOG.md index 67ad6a802d..f851258641 100644 --- a/packages/ibm-products/CHANGELOG.md +++ b/packages/ibm-products/CHANGELOG.md @@ -3,6 +3,133 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [2.54.0-rc.1](https://github.com/carbon-design-system/ibm-products/compare/@carbon/ibm-products@2.48.0-rc.0...@carbon/ibm-products@2.54.0-rc.1) (2024-11-15) + + + +# 2.54.0-rc.0 (2024-11-11) + + +### Bug Fixes + +* **AboutModal:** implement useFocus() ([#5981](https://github.com/carbon-design-system/ibm-products/issues/5981)) ([e37beea](https://github.com/carbon-design-system/ibm-products/commit/e37beeafa1f592de3c9a38930487ed7cf4e8239b)) +* add floating ui to tagset ([#6005](https://github.com/carbon-design-system/ibm-products/issues/6005)) ([fac868b](https://github.com/carbon-design-system/ibm-products/commit/fac868b0bb3382aac79ab2780480d58e901da517)) +* add primaryButtonDisabled prop to ProductiveCard ([#6100](https://github.com/carbon-design-system/ibm-products/issues/6100)) ([7d17364](https://github.com/carbon-design-system/ibm-products/commit/7d17364029712bd54fc9f97e7a2c1af0a9e7b381)) +* **API Key Modal:** heading,label and downloadlink ([#6298](https://github.com/carbon-design-system/ibm-products/issues/6298)) ([68cb175](https://github.com/carbon-design-system/ibm-products/commit/68cb17576b7647759e68bd29d543c40c2e205e87)) +* **APIKeyModal:** focus issue inside onBlue default behaviour ([#6347](https://github.com/carbon-design-system/ibm-products/issues/6347)) ([e5a66ce](https://github.com/carbon-design-system/ibm-products/commit/e5a66ce58bcf5f671365f26adf47993a70dd00d1)) +* broken coachmark accessibility tests and avt ([#6398](https://github.com/carbon-design-system/ibm-products/issues/6398)) ([1fe4d81](https://github.com/carbon-design-system/ibm-products/commit/1fe4d815100c0dbaf6b7685f20dd0a4ccfac4bb9)) +* **Conditionbuilder:** add await for accessibility test ([#5794](https://github.com/carbon-design-system/ibm-products/issues/5794)) ([0d86010](https://github.com/carbon-design-system/ibm-products/commit/0d860101791e8587f8d1688348aae8438c4d0fc9)) +* **ConditionBuilder:** correct role for NON HIERARCHICAL_VARIANT ([#6117](https://github.com/carbon-design-system/ibm-products/issues/6117)) ([6c7823e](https://github.com/carbon-design-system/ibm-products/commit/6c7823ed1405d0dfa6ef51cac89e0373f6763ef0)) +* **conditionBuilder:** release review changes1 ([#6133](https://github.com/carbon-design-system/ibm-products/issues/6133)) ([d3f08bc](https://github.com/carbon-design-system/ibm-products/commit/d3f08bcd0b479a84e69fc29dfe03a931618168a7)) +* **create-full-page-step:** update hasFieldSet type ([#5876](https://github.com/carbon-design-system/ibm-products/issues/5876)) ([54afdf6](https://github.com/carbon-design-system/ibm-products/commit/54afdf6f31b60e87a21949a69e01ec94bbdc2b79)) +* **CreateFullPage:** breadcrumb tooltip visibility issue ([#6064](https://github.com/carbon-design-system/ibm-products/issues/6064)) ([03eadd2](https://github.com/carbon-design-system/ibm-products/commit/03eadd20c856a18121c5cb516fd49cd2ddc87b6a)) +* **CreateFullPage:** breadcrumbs should be array ([#6058](https://github.com/carbon-design-system/ibm-products/issues/6058)) ([f076047](https://github.com/carbon-design-system/ibm-products/commit/f076047b593235b01b9c4666194c080e0b4a3b4e)), closes [#5707](https://github.com/carbon-design-system/ibm-products/issues/5707) +* **createfullpagestep:** hasFieldset and fieldsetLegendText types ([#6057](https://github.com/carbon-design-system/ibm-products/issues/6057)) ([b5db933](https://github.com/carbon-design-system/ibm-products/commit/b5db933dc668b451451736dc61fc18d35ba38ec5)), closes [#4512](https://github.com/carbon-design-system/ibm-products/issues/4512) +* **CreateTearsheet:** add custom button ([#5666](https://github.com/carbon-design-system/ibm-products/issues/5666)) ([d5f9538](https://github.com/carbon-design-system/ibm-products/commit/d5f9538902233075e38a60abf70efc52838f5804)) +* csp errors on 2 illustrations ([#6202](https://github.com/carbon-design-system/ibm-products/issues/6202)) ([ad8c2d8](https://github.com/carbon-design-system/ibm-products/commit/ad8c2d84b231e9a4a5243cbfafc618fdbb63aace)) +* data spreadsheet object drag drop ([#5800](https://github.com/carbon-design-system/ibm-products/issues/5800)) ([25e95ba](https://github.com/carbon-design-system/ibm-products/commit/25e95bab041d69b28cc8e2a1c15ddd78ea4ab311)) +* datagrid typescript declarations ([#6122](https://github.com/carbon-design-system/ibm-products/issues/6122)) ([977e279](https://github.com/carbon-design-system/ibm-products/commit/977e279608be3d7151a4f6b58d7006dfbdd7fec3)), closes [#5257](https://github.com/carbon-design-system/ibm-products/issues/5257) [#6115](https://github.com/carbon-design-system/ibm-products/issues/6115) +* **Datagrid:** add support for autoAlign in row resize popover ([#6289](https://github.com/carbon-design-system/ibm-products/issues/6289)) ([17aeb86](https://github.com/carbon-design-system/ibm-products/commit/17aeb86bc2877974fa398b8563f7999d9c3cbce3)) +* **datagrid:** batch no longer updates filter tag ([#6031](https://github.com/carbon-design-system/ibm-products/issues/6031)) ([11c1554](https://github.com/carbon-design-system/ibm-products/commit/11c1554ba92037f559862ad9c83cfdf048074659)) +* **Datagrid:** clickable row retain focus after sidepanel closes ([#5952](https://github.com/carbon-design-system/ibm-products/issues/5952)) ([0df9085](https://github.com/carbon-design-system/ibm-products/commit/0df908523eab166b8bb63731f60a727ef846e41f)) +* **Datagrid:** csp violation ([#5831](https://github.com/carbon-design-system/ibm-products/issues/5831)) ([73a9824](https://github.com/carbon-design-system/ibm-products/commit/73a98242150e421a7c414bf7743f453a2234caba)) +* **datagrid:** customise column tearsheet update issue with new columns ([#5953](https://github.com/carbon-design-system/ibm-products/issues/5953)) ([7ab472a](https://github.com/carbon-design-system/ibm-products/commit/7ab472a22d78b07b900513f0b1a0ddce8b7db2f7)) +* **DataGrid:** disable save button on customise column ([#6026](https://github.com/carbon-design-system/ibm-products/issues/6026)) ([2b32f0f](https://github.com/carbon-design-system/ibm-products/commit/2b32f0fa54034d347438347e69dfd865c1248f9f)) +* **Datagrid:** enabled spacer column conditionally ([#5920](https://github.com/carbon-design-system/ibm-products/issues/5920)) ([9bd307e](https://github.com/carbon-design-system/ibm-products/commit/9bd307e4836d986383a0464e799834712f3904e0)) +* **datagrid:** fixes multiselect for instant update bug ([#5970](https://github.com/carbon-design-system/ibm-products/issues/5970)) ([330e902](https://github.com/carbon-design-system/ibm-products/commit/330e902c94cf3c8720ddb4360c1ae313c12f756e)) +* **dataGrid:** focus loss on radio select ([#6073](https://github.com/carbon-design-system/ibm-products/issues/6073)) ([127824b](https://github.com/carbon-design-system/ibm-products/commit/127824b9dcdb9847a58940305bb06c35565c720c)) +* **dataGrid:** header scroll issues ([#6135](https://github.com/carbon-design-system/ibm-products/issues/6135)) ([9d60c0c](https://github.com/carbon-design-system/ibm-products/commit/9d60c0cd0f0ab98ba87915eb50a9de2a55dff5a1)) +* **datagrid:** hidden columns included in search results ([#5989](https://github.com/carbon-design-system/ibm-products/issues/5989)) ([189f452](https://github.com/carbon-design-system/ibm-products/commit/189f4522187981788b0eb431b89f8b6e89eecd47)) +* **Datagrid:** remove redundant aria disabled ([#6103](https://github.com/carbon-design-system/ibm-products/issues/6103)) ([5b58d50](https://github.com/carbon-design-system/ibm-products/commit/5b58d506a39b3d625e169004e1385ae9cfcc6985)) +* **Datagrid:** remove unused span with inputProps ([#5915](https://github.com/carbon-design-system/ibm-products/issues/5915)) ([517e4f3](https://github.com/carbon-design-system/ibm-products/commit/517e4f36631cf1cc81d6f21fd25a83b3c65da540)) +* **Datagrid:** resolve CSP in subcomponents ([#6229](https://github.com/carbon-design-system/ibm-products/issues/6229)) ([95c6489](https://github.com/carbon-design-system/ibm-products/commit/95c6489e30e5e20e344eff958e481ee22be9d465)) +* **Datagrid:** return null for older react versions ([#6003](https://github.com/carbon-design-system/ibm-products/issues/6003)) ([6938654](https://github.com/carbon-design-system/ibm-products/commit/6938654a3ec57ea63f69c4390ffa5a290c01d886)) +* **DataGrid:** row size change issues with virtual scrolling enabled ([#5895](https://github.com/carbon-design-system/ibm-products/issues/5895)) ([a297e8a](https://github.com/carbon-design-system/ibm-products/commit/a297e8a1dc67e8017083452c79b5162eaf282c99)) +* **Datagrid:** select all checkbox to select current page ([#5933](https://github.com/carbon-design-system/ibm-products/issues/5933)) ([602f85d](https://github.com/carbon-design-system/ibm-products/commit/602f85d0a3afd507b31157df27091fc94e60bf27)) +* **Datagrid:** select all row count updated to exclude disabled rows ([#6085](https://github.com/carbon-design-system/ibm-products/issues/6085)) ([c7064de](https://github.com/carbon-design-system/ibm-products/commit/c7064de5be480840775039e2e4bdad00fbf8d4ce)) +* **datagrid:** selectall selects disabled rows ([#6008](https://github.com/carbon-design-system/ibm-products/issues/6008)) ([01d973f](https://github.com/carbon-design-system/ibm-products/commit/01d973f95256ee174e59c902e4c46ddc4781b13f)) +* **Datagrid:** skip await getAsyncSubRows when not defined ([#6028](https://github.com/carbon-design-system/ibm-products/issues/6028)) ([7390b55](https://github.com/carbon-design-system/ibm-products/commit/7390b55425aaf1ceff75056bcb81e2d09d61c118)) +* **datagrid:** tooltip missing in Customize Columns modal ([#6036](https://github.com/carbon-design-system/ibm-products/issues/6036)) ([15ec2a5](https://github.com/carbon-design-system/ibm-products/commit/15ec2a5277c9ef1ba1b972b57d050e4af7da2766)) +* **datagrid:** unique name attribute for row settings radio buttons ([#6009](https://github.com/carbon-design-system/ibm-products/issues/6009)) ([618cc84](https://github.com/carbon-design-system/ibm-products/commit/618cc84a372301571df132a21a06051c8d35a33a)) +* **datagrid:** use same empty array every time ([#5999](https://github.com/carbon-design-system/ibm-products/issues/5999)) ([e6ce08b](https://github.com/carbon-design-system/ibm-products/commit/e6ce08b236acf9f7360e01b2ebb5e5a8568afc9c)), closes [#5998](https://github.com/carbon-design-system/ibm-products/issues/5998) +* **Datagrid:** useflexresize infinite redraw ([#6226](https://github.com/carbon-design-system/ibm-products/issues/6226)) ([8030367](https://github.com/carbon-design-system/ibm-products/commit/8030367c4fe90f9ff84db06935553a289518c2e8)), closes [#5920](https://github.com/carbon-design-system/ibm-products/issues/5920) [#5646](https://github.com/carbon-design-system/ibm-products/issues/5646) +* **Datagrid:** width logic for useSortableColumns vs useActionsColumn ([#6029](https://github.com/carbon-design-system/ibm-products/issues/6029)) ([66f9eee](https://github.com/carbon-design-system/ibm-products/commit/66f9eeeb8df559b3f7cc98989853cce3e85f5852)) +* **EditInPlace:** focus and style issue ([#6146](https://github.com/carbon-design-system/ibm-products/issues/6146)) ([831a0bc](https://github.com/carbon-design-system/ibm-products/commit/831a0bc7da65e65c09228cf2b292cbb879484d3a)) +* **EditInPlace:** removes focus when pressing esc or enter key ([#5943](https://github.com/carbon-design-system/ibm-products/issues/5943)) ([5eff024](https://github.com/carbon-design-system/ibm-products/commit/5eff0243b65123fb39c801194a1b1a8bb9889240)) +* **Export Modal:** Focus moves to parent page ([#6077](https://github.com/carbon-design-system/ibm-products/issues/6077)) ([ef4bfa8](https://github.com/carbon-design-system/ibm-products/commit/ef4bfa87d454eba9ce8b4cb83a464e95d66a189e)) +* **ExportModal:** focus return to trigger button ([#6116](https://github.com/carbon-design-system/ibm-products/issues/6116)) ([bbc770e](https://github.com/carbon-design-system/ibm-products/commit/bbc770e8fc2415c9dd898ead57bdc332e4fdf339)) +* **ExportModal:** screen reader indentifies hidden controls ([#6079](https://github.com/carbon-design-system/ibm-products/issues/6079)) ([dd7564d](https://github.com/carbon-design-system/ibm-products/commit/dd7564d02dcad68052555eb5b2bf543b4a901992)) +* **ExportModal:** update status message ([#6080](https://github.com/carbon-design-system/ibm-products/issues/6080)) ([ec3dead](https://github.com/carbon-design-system/ibm-products/commit/ec3dead1b2dd6c727e09bcd0356d567721d5209f)) +* first step logic enhancement for CreateTearsheet ([#5884](https://github.com/carbon-design-system/ibm-products/issues/5884)) ([4f3b70f](https://github.com/carbon-design-system/ibm-products/commit/4f3b70f93d43a94c50b8eea77b5960f30b59c403)) +* **getstartedcard:** disable vairant issue in JAWS ([#5886](https://github.com/carbon-design-system/ibm-products/issues/5886)) ([515d4c0](https://github.com/carbon-design-system/ibm-products/commit/515d4c0c89f8fe70539946072e9397d297b0faac)) +* **InlineTip:** added optional ? flag on media ([#6137](https://github.com/carbon-design-system/ibm-products/issues/6137)) ([978f3e6](https://github.com/carbon-design-system/ibm-products/commit/978f3e65fff94f6399714fb921e8ef2208a1ec51)) +* nofification panel keyboard close focus ([#6113](https://github.com/carbon-design-system/ibm-products/issues/6113)) ([752739b](https://github.com/carbon-design-system/ibm-products/commit/752739bde31c3dcb5de1ff2702167b7a838350dd)) +* **NotificationPanel:** add missing role ([#5810](https://github.com/carbon-design-system/ibm-products/issues/5810)) ([bf17410](https://github.com/carbon-design-system/ibm-products/commit/bf1741045997b784c98068c618260dfbc7a79dc6)) +* **NotificationPanel:** focus return to trigger on closing notification panel ([#6090](https://github.com/carbon-design-system/ibm-products/issues/6090)) ([6dd626a](https://github.com/carbon-design-system/ibm-products/commit/6dd626ac445a255ca9e7c64eb851c11dbb0117f7)) +* **onboardingComponents:** csp voilation ([#6228](https://github.com/carbon-design-system/ibm-products/issues/6228)) ([6a848b7](https://github.com/carbon-design-system/ibm-products/commit/6a848b7150db52af5891e21066c273b4f9d2d598)) +* **optionstile:** ontoggle should not be required ([#6056](https://github.com/carbon-design-system/ibm-products/issues/6056)) ([af6cf14](https://github.com/carbon-design-system/ibm-products/commit/af6cf147f759f344173baf3350095c319398fe2d)), closes [#4281](https://github.com/carbon-design-system/ibm-products/issues/4281) +* pageheader gap ([#6004](https://github.com/carbon-design-system/ibm-products/issues/6004)) ([97bf3ac](https://github.com/carbon-design-system/ibm-products/commit/97bf3acf41b1ae35875c634cad3315ac5c3d2936)) +* **PageHeader:** change type import ([#6368](https://github.com/carbon-design-system/ibm-products/issues/6368)) ([d653f42](https://github.com/carbon-design-system/ibm-products/commit/d653f42bc06126cb35610a4d85d17655775fc374)) +* **pageheader:** compensate the width of the overflow menu ([#5929](https://github.com/carbon-design-system/ibm-products/issues/5929)) ([baf0ec2](https://github.com/carbon-design-system/ibm-products/commit/baf0ec231c0c343265efbf74b69a9d38db085dd2)) +* **Pageheader:** scrollable headers are not tabbable ([#6145](https://github.com/carbon-design-system/ibm-products/issues/6145)) ([ed578ec](https://github.com/carbon-design-system/ibm-products/commit/ed578ec0d45dcd72a7c96fd1e8370d4a67019ec6)) +* **ProductiveCard:** makes graph screen readable, story only. ([#5883](https://github.com/carbon-design-system/ibm-products/issues/5883)) ([a2db976](https://github.com/carbon-design-system/ibm-products/commit/a2db976c1609df5fd83459e5137e42d3a356ca5d)) +* remove ellipsis from EditInPlace ([#6098](https://github.com/carbon-design-system/ibm-products/issues/6098)) ([0b40cce](https://github.com/carbon-design-system/ibm-products/commit/0b40cce8451abd0e509a6b16490fff862496b414)) +* remove title from datagrid expander ([#6200](https://github.com/carbon-design-system/ibm-products/issues/6200)) ([e7e025e](https://github.com/carbon-design-system/ibm-products/commit/e7e025e034fdcbc18f645145031f56ed07e6cced)) +* remove unnecessary props in feature flag tests ([#6342](https://github.com/carbon-design-system/ibm-products/issues/6342)) ([62f3369](https://github.com/carbon-design-system/ibm-products/commit/62f3369fd4431bf0ecd4156530879489899fa8de)) +* Resolve all typescript errors ([#6013](https://github.com/carbon-design-system/ibm-products/issues/6013)) ([e87db88](https://github.com/carbon-design-system/ibm-products/commit/e87db88a5267e2d1bf4703666c86a1b052191ad2)) +* reword props in card stories ([#5871](https://github.com/carbon-design-system/ibm-products/issues/5871)) ([df80f00](https://github.com/carbon-design-system/ibm-products/commit/df80f0029af2c2ec6d7c53b66d69dfc007c1f446)) +* role main removed from components ([#6006](https://github.com/carbon-design-system/ibm-products/issues/6006)) ([b334a51](https://github.com/carbon-design-system/ibm-products/commit/b334a51c4aa1f3bae26554a9e0b1e65b663b0eed)) +* **sidepanel:** button text change ([#5907](https://github.com/carbon-design-system/ibm-products/issues/5907)) ([f701002](https://github.com/carbon-design-system/ibm-products/commit/f7010028dbedae7178244b4123a3b0bc485efa70)) +* **SidePanel:** resolve focus wrap issue when first element is disabled ([#5991](https://github.com/carbon-design-system/ibm-products/issues/5991)) ([426f588](https://github.com/carbon-design-system/ibm-products/commit/426f588dd8351783e2cad24bde4e2a5e36c64ae7)) +* **SidePanel:** style issue with multi select ([#6123](https://github.com/carbon-design-system/ibm-products/issues/6123)) ([feb6a99](https://github.com/carbon-design-system/ibm-products/commit/feb6a993cb0971442cca80f4c7c86d90eede0bbf)) +* **tagoverflow:** incorrect type for filter prop ([#6000](https://github.com/carbon-design-system/ibm-products/issues/6000)) ([4134043](https://github.com/carbon-design-system/ibm-products/commit/41340439759927a870a335b3dd5dd971e8f44fcb)) +* **TagOverflow:** use operational tag ([#6132](https://github.com/carbon-design-system/ibm-products/issues/6132)) ([791cbec](https://github.com/carbon-design-system/ibm-products/commit/791cbecb2319ce832c1a6341c0a8fbf16b76a3e0)) +* **TagSet:** fix string formatting ([#5880](https://github.com/carbon-design-system/ibm-products/issues/5880)) ([9339559](https://github.com/carbon-design-system/ibm-products/commit/93395596b529fb2e1bb7591e8d4792f1ff1de7ff)) +* **TagSet:** modal gradient ([#4478](https://github.com/carbon-design-system/ibm-products/issues/4478)) ([459109d](https://github.com/carbon-design-system/ibm-products/commit/459109d08ca6baf6a66954dd6fa49360dc553dc6)) +* **tagset:** multiline prop broken ([#6027](https://github.com/carbon-design-system/ibm-products/issues/6027)) ([dff3d68](https://github.com/carbon-design-system/ibm-products/commit/dff3d68dcdc6801c58d1299e4ffa91b2578e53a4)) +* **tagset:** updates props ([#5962](https://github.com/carbon-design-system/ibm-products/issues/5962)) ([cf7c88c](https://github.com/carbon-design-system/ibm-products/commit/cf7c88c293fa05406837afe68d9775d39998818c)) +* tearsheet with nav accessibility ([#5971](https://github.com/carbon-design-system/ibm-products/issues/5971)) ([d2aeeb2](https://github.com/carbon-design-system/ibm-products/commit/d2aeeb2b8e226f1da45bb8fd8ca45584269574d8)) +* **Tearsheet:** add missing declaration for headerActions prop ([#6114](https://github.com/carbon-design-system/ibm-products/issues/6114)) ([d1dafa1](https://github.com/carbon-design-system/ibm-products/commit/d1dafa1e94472eb64e769ccd358e5355837fa9a5)), closes [#546](https://github.com/carbon-design-system/ibm-products/issues/546) +* **Tearsheet:** changed actions prop to optional ([#5984](https://github.com/carbon-design-system/ibm-products/issues/5984)) ([068a7df](https://github.com/carbon-design-system/ibm-products/commit/068a7df53265e71193ef583145c69d17b3f76535)) +* **tearsheet:** Firefox focuses Tearsheet content div with scroll ([#5973](https://github.com/carbon-design-system/ibm-products/issues/5973)) ([19e319b](https://github.com/carbon-design-system/ibm-products/commit/19e319baff3635fb2d1a54d22cfaa5dfc8e95e23)) +* **tearsheet:** focus without sentinels ([#5882](https://github.com/carbon-design-system/ibm-products/issues/5882)) ([f362806](https://github.com/carbon-design-system/ibm-products/commit/f3628062a6e65ea5963353a79da1734db6bc9d80)) +* **tearsheet:** implement a workaround ([#5960](https://github.com/carbon-design-system/ibm-products/issues/5960)) ([c7d1ef3](https://github.com/carbon-design-system/ibm-products/commit/c7d1ef37a22f3820dd22ad97cd247c169fdc97b4)) +* **Tearsheet:** resolve focus issue ([#6217](https://github.com/carbon-design-system/ibm-products/issues/6217)) ([dc53a09](https://github.com/carbon-design-system/ibm-products/commit/dc53a099baba3450d769b9e4581c524673529fa0)) +* **Tearsheet:** update portalTarget type ([#5899](https://github.com/carbon-design-system/ibm-products/issues/5899)) ([d7aa99e](https://github.com/carbon-design-system/ibm-products/commit/d7aa99ed058d3cd55302bc6fe5c169e5a120d64e)) +* these at imports should not exist ([#6359](https://github.com/carbon-design-system/ibm-products/issues/6359)) ([3ea78f2](https://github.com/carbon-design-system/ibm-products/commit/3ea78f2cefc632bfec990026418a4851b3f582f0)) +* **ToolbarButton:** deprecate iconDescription and use label instead ([#5893](https://github.com/carbon-design-system/ibm-products/issues/5893)) ([b968386](https://github.com/carbon-design-system/ibm-products/commit/b968386090b0934f770c66a6eab08f4af0054ee4)) +* update Carbon 11 compatible versions to latest ([#6054](https://github.com/carbon-design-system/ibm-products/issues/6054)) ([0ac7669](https://github.com/carbon-design-system/ibm-products/commit/0ac76692a6eeb85655ca64ca9189297708e26bd9)) +* update to Carbon 11 compatible versions to latest ([#5987](https://github.com/carbon-design-system/ibm-products/issues/5987)) ([173e6c6](https://github.com/carbon-design-system/ibm-products/commit/173e6c6455a4fe619d56148ab432926bc6c640a4)) +* update to Carbon 11 compatible versions to latest ([#6214](https://github.com/carbon-design-system/ibm-products/issues/6214)) ([911c341](https://github.com/carbon-design-system/ibm-products/commit/911c341d258b410ff2109ecb39293c2670796a0e)) +* update to Carbon 11 compatible versions to latest ([#6343](https://github.com/carbon-design-system/ibm-products/issues/6343)) ([71a201a](https://github.com/carbon-design-system/ibm-products/commit/71a201a50fbebe76699ffb0d7df1d2d998370256)) +* update toHaveNoAxeViolations and remove skips ([#5955](https://github.com/carbon-design-system/ibm-products/issues/5955)) ([694128b](https://github.com/carbon-design-system/ibm-products/commit/694128bb707a2400d67e6618af3fea3f3ffba86f)) +* **useFocus:** change delay to 1ms ([#5950](https://github.com/carbon-design-system/ibm-products/issues/5950)) ([5883cd3](https://github.com/carbon-design-system/ibm-products/commit/5883cd3a14039ab7ca044b4ab95621bb70ccf68e)) +* **UserAvatar:** release review fixes ([#6293](https://github.com/carbon-design-system/ibm-products/issues/6293)) ([eafbba3](https://github.com/carbon-design-system/ibm-products/commit/eafbba33b6c9630457eeb0c6d86d030ee699940f)) + + +### Features + +* **`ibm-products-web-components`:** setup new web component package and storybook ([#6148](https://github.com/carbon-design-system/ibm-products/issues/6148)) ([6962187](https://github.com/carbon-design-system/ibm-products/commit/6962187634ba4317c5a4dcbf495978a176efcb79)) +* adding the ability to disable modals for TagSet component ([#5753](https://github.com/carbon-design-system/ibm-products/issues/5753)) ([29e960c](https://github.com/carbon-design-system/ibm-products/commit/29e960c858d2c58d46c86e9ea638a351d5fddd76)) +* **cards:** renames slug to aiLabel ([#6167](https://github.com/carbon-design-system/ibm-products/issues/6167)) ([5b94ed8](https://github.com/carbon-design-system/ibm-products/commit/5b94ed8d01638db747277f104d9f7dd9ab2e0eb3)) +* **carousel:** adds test coverage ([#6355](https://github.com/carbon-design-system/ibm-products/issues/6355)) ([32aa2b2](https://github.com/carbon-design-system/ibm-products/commit/32aa2b24dfa792f875002f882c65533e06309d64)) +* **ConditionBuilder:** enhancing the conditional operators section that manages the primary logic flow ([#5921](https://github.com/carbon-design-system/ibm-products/issues/5921)) ([91733fb](https://github.com/carbon-design-system/ibm-products/commit/91733fb43157eab26c885f0652adaf9276f372d4)) +* **ConditionBuilder:** option to default enable with initial state ([#6007](https://github.com/carbon-design-system/ibm-products/issues/6007)) ([3b2b91c](https://github.com/carbon-design-system/ibm-products/commit/3b2b91c63157d748425c1fa85ed70411e2c7e018)) +* **Conditionbuilder:** renaming both variants to Hierarchical and Non-Hierarchical ([#5847](https://github.com/carbon-design-system/ibm-products/issues/5847)) ([791e2b3](https://github.com/carbon-design-system/ibm-products/commit/791e2b31549f3f4480cac2fc142e550b5e12ea31)) +* **datagrid:** adds radio filter ([#5877](https://github.com/carbon-design-system/ibm-products/issues/5877)) ([12667e8](https://github.com/carbon-design-system/ibm-products/commit/12667e8387afc97c8a81a791c72f7ad323d7be6b)) +* **Datagrid:** call onClearFilters when clearing filters from tag summary ([#5892](https://github.com/carbon-design-system/ibm-products/issues/5892)) ([791618a](https://github.com/carbon-design-system/ibm-products/commit/791618a11618f120b15444dde994da65576a79ff)) +* **datagrids:** Add custom batch actions display min ([#5776](https://github.com/carbon-design-system/ibm-products/issues/5776)) ([485e8bc](https://github.com/carbon-design-system/ibm-products/commit/485e8bcac3193e56d65721076160944b4e126256)) +* **Datagrid:** slug to aiLabel renaming ([#6151](https://github.com/carbon-design-system/ibm-products/issues/6151)) ([b0b3c1c](https://github.com/carbon-design-system/ibm-products/commit/b0b3c1cf40199e7458584ea1d9093224264e1f4c)) +* **empty-states:** exports types ([#6299](https://github.com/carbon-design-system/ibm-products/issues/6299)) ([436f50d](https://github.com/carbon-design-system/ibm-products/commit/436f50d29f6391593050740803bf14ef01b04335)) +* expose onChange and onPrevious for CreateFullPage ([#6271](https://github.com/carbon-design-system/ibm-products/issues/6271)) ([5bd953d](https://github.com/carbon-design-system/ibm-products/commit/5bd953de33d856b791692b9302a424dc6d10d6a1)) +* **tagset:** support for size on overflow tag ([#6065](https://github.com/carbon-design-system/ibm-products/issues/6065)) ([ba29c09](https://github.com/carbon-design-system/ibm-products/commit/ba29c0950f1fcc7388e58523e94a32abd588d59d)) +* **tag:** updates tags to use DismissibleTag ([#6112](https://github.com/carbon-design-system/ibm-products/issues/6112)) ([18b47c7](https://github.com/carbon-design-system/ibm-products/commit/18b47c72ff381db130897da6a2d1f0aa86fd6d85)) +* **Tearsheet:** Slug to aiLabel ([#6169](https://github.com/carbon-design-system/ibm-products/issues/6169)) ([5c0f2ad](https://github.com/carbon-design-system/ibm-products/commit/5c0f2adf55e6c9c7f081dab72ab711b611593476)) + + + + + # [2.54.0-rc.0](https://github.com/carbon-design-system/ibm-products/compare/@carbon/ibm-products@2.48.0-rc.0...@carbon/ibm-products@2.54.0-rc.0) (2024-11-11) diff --git a/packages/ibm-products/package.json b/packages/ibm-products/package.json index 8f976b5c68..0e2e873955 100644 --- a/packages/ibm-products/package.json +++ b/packages/ibm-products/package.json @@ -1,7 +1,7 @@ { "name": "@carbon/ibm-products", "description": "Carbon for IBM Products", - "version": "2.54.0-rc.0", + "version": "2.54.0-rc.1", "license": "Apache-2.0", "main": "lib/index.js", "module": "es/index.js", @@ -81,7 +81,7 @@ "fs-extra": "^11.2.0", "glob": "^10.3.10", "jest": "^29.7.0", - "jest-config-ibm-cloud-cognitive": "^1.13.0-rc.0", + "jest-config-ibm-cloud-cognitive": "^1.13.0-rc.1", "jest-environment-jsdom": "^29.7.0", "namor": "^1.1.2", "npm-check-updates": "^16.14.12", @@ -96,7 +96,7 @@ "dependencies": { "@babel/runtime": "^7.23.9", "@carbon/feature-flags": "^0.24.0", - "@carbon/ibm-products-styles": "^2.50.0-rc.0", + "@carbon/ibm-products-styles": "^2.50.0-rc.1", "@carbon/telemetry": "^0.1.0", "@dnd-kit/core": "^6.0.8", "@dnd-kit/modifiers": "^7.0.0", diff --git a/yarn.lock b/yarn.lock index 25d0ad9025..30e223c29c 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1799,7 +1799,7 @@ __metadata: resolution: "@carbon/ibm-cloud-cognitive-core@workspace:packages/core" dependencies: "@carbon/grid": "npm:^11.29.0" - "@carbon/ibm-products-styles": "npm:^2.50.0-rc.0" + "@carbon/ibm-products-styles": "npm:^2.50.0-rc.1" "@carbon/layout": "npm:^11.28.0" "@carbon/motion": "npm:^11.24.0" "@carbon/react": "npm:^1.69.0" @@ -1865,7 +1865,7 @@ __metadata: cross-env: "npm:^7.0.3" glob: "npm:^10.3.10" jest: "npm:^29.7.0" - jest-config-ibm-cloud-cognitive: "npm:^1.13.0-rc.0" + jest-config-ibm-cloud-cognitive: "npm:^1.13.0-rc.1" jest-environment-jsdom: "npm:^29.7.0" npm-check-updates: "npm:^16.14.12" npm-run-all: "npm:^4.1.5" @@ -1885,7 +1885,7 @@ __metadata: version: 0.0.0-use.local resolution: "@carbon/ibm-products-web-components@workspace:packages/ibm-products-web-components" dependencies: - "@carbon/ibm-products-styles": "npm:^2.50.0-rc.0" + "@carbon/ibm-products-styles": "npm:^2.50.0-rc.1" "@carbon/icons": "npm:^11.52.0" "@carbon/motion": "npm:^11.24.0" "@carbon/styles": "npm:1.68.0" @@ -1943,7 +1943,7 @@ __metadata: "@babel/preset-typescript": "npm:^7.21.5" "@babel/runtime": "npm:^7.23.9" "@carbon/feature-flags": "npm:^0.24.0" - "@carbon/ibm-products-styles": "npm:^2.50.0-rc.0" + "@carbon/ibm-products-styles": "npm:^2.50.0-rc.1" "@carbon/telemetry": "npm:^0.1.0" "@dnd-kit/core": "npm:^6.0.8" "@dnd-kit/modifiers": "npm:^7.0.0" @@ -1968,7 +1968,7 @@ __metadata: glob: "npm:^10.3.10" immutability-helper: "npm:^3.1.1" jest: "npm:^29.7.0" - jest-config-ibm-cloud-cognitive: "npm:^1.13.0-rc.0" + jest-config-ibm-cloud-cognitive: "npm:^1.13.0-rc.1" jest-environment-jsdom: "npm:^29.7.0" lodash: "npm:^4.17.21" lottie-web: "npm:^5.12.2" @@ -17689,7 +17689,7 @@ __metadata: languageName: node linkType: hard -"jest-config-ibm-cloud-cognitive@npm:^1.13.0-rc.0, jest-config-ibm-cloud-cognitive@workspace:config/jest-config-ibm-cloud-cognitive": +"jest-config-ibm-cloud-cognitive@npm:^1.13.0-rc.1, jest-config-ibm-cloud-cognitive@workspace:config/jest-config-ibm-cloud-cognitive": version: 0.0.0-use.local resolution: "jest-config-ibm-cloud-cognitive@workspace:config/jest-config-ibm-cloud-cognitive" dependencies: From f4b1706428ec30c8c7c5c8d9060b1a9071afec04 Mon Sep 17 00:00:00 2001 From: Nandan Devadula <47176249+devadula-nandan@users.noreply.github.com> Date: Mon, 18 Nov 2024 10:07:57 +0530 Subject: [PATCH 3/9] refactor: style specific sticky columns in carbon row (#6351) * refactor: style specific sticky columns in carbon row * fix: hover token and useMemo in header story * chore: snapshot update * fix: increase z index on all sticky column instances --- .../__snapshots__/styles.test.js.snap | 14 ++++++++---- .../components/Datagrid/styles/_datagrid.scss | 22 ++++++++++++++----- .../Datagrid/styles/_useStickyColumn.scss | 4 ++-- .../components/Datagrid/Datagrid.stories.jsx | 2 +- 4 files changed, 29 insertions(+), 13 deletions(-) diff --git a/packages/ibm-products-styles/src/__tests__/__snapshots__/styles.test.js.snap b/packages/ibm-products-styles/src/__tests__/__snapshots__/styles.test.js.snap index 1e390bb4e6..75c14a5b05 100644 --- a/packages/ibm-products-styles/src/__tests__/__snapshots__/styles.test.js.snap +++ b/packages/ibm-products-styles/src/__tests__/__snapshots__/styles.test.js.snap @@ -3647,15 +3647,21 @@ p.c4p--about-modal__copyright-text:first-child { /* stylelint-disable-next-line declaration-no-important */ color: var(--cds-link-primary-hover, #0043ce) !important; } -.c4p--datagrid__grid-container .c4p--datagrid__carbon-row td { +.c4p--datagrid__grid-container .c4p--datagrid__carbon-row .c4p--datagrid__left-sticky-column-cell, +.c4p--datagrid__grid-container .c4p--datagrid__carbon-row .c4p--datagrid__right-sticky-column-cell, +.c4p--datagrid__grid-container .c4p--datagrid__carbon-row .c4p--datagrid__checkbox-cell-sticky-left { /* stylelint-disable-next-line declaration-no-important */ background-color: var(--cds-layer-01, #f4f4f4); } -.c4p--datagrid__grid-container .c4p--datagrid__carbon-row:hover td { +.c4p--datagrid__grid-container .c4p--datagrid__carbon-row:hover .c4p--datagrid__left-sticky-column-cell, +.c4p--datagrid__grid-container .c4p--datagrid__carbon-row:hover .c4p--datagrid__right-sticky-column-cell, +.c4p--datagrid__grid-container .c4p--datagrid__carbon-row:hover .c4p--datagrid__checkbox-cell-sticky-left { /* stylelint-disable-next-line declaration-no-important */ background-color: var(--cds-layer-hover-01, #e8e8e8); } -.c4p--datagrid__grid-container .cds--data-table--selected td { +.c4p--datagrid__grid-container .cds--data-table--selected .c4p--datagrid__left-sticky-column-cell, +.c4p--datagrid__grid-container .cds--data-table--selected .c4p--datagrid__right-sticky-column-cell, +.c4p--datagrid__grid-container .cds--data-table--selected .c4p--datagrid__checkbox-cell-sticky-left { /* stylelint-disable-next-line declaration-no-important */ background-color: var(--cds-layer-selected-01, #e0e0e0); } @@ -3740,7 +3746,7 @@ p.c4p--about-modal__copyright-text:first-child { } .c4p--datagrid__resizableColumn:hover { - background-color: var(--cds-background-selected-hover, rgba(141, 141, 141, 0.32)); + background-color: var(--cds-layer-selected-hover); } .c4p--datagrid__resizableColumn:hover .c4p--datagrid__resizer { border-right: 0.125rem solid var(--cds-border-strong-01, #8d8d8d); diff --git a/packages/ibm-products-styles/src/components/Datagrid/styles/_datagrid.scss b/packages/ibm-products-styles/src/components/Datagrid/styles/_datagrid.scss index 987eb67174..c95f880e1c 100644 --- a/packages/ibm-products-styles/src/components/Datagrid/styles/_datagrid.scss +++ b/packages/ibm-products-styles/src/components/Datagrid/styles/_datagrid.scss @@ -44,7 +44,7 @@ .#{$block-class}__head-select-all.#{$block-class}__checkbox-cell.#{$block-class}__checkbox-cell-sticky-left { position: sticky; - z-index: 1; + z-index: 10; left: 0; } } @@ -413,17 +413,27 @@ } } - .#{$block-class}__carbon-row td { + .#{$block-class}__carbon-row .#{$block-class}__left-sticky-column-cell, + .#{$block-class}__carbon-row .#{$block-class}__right-sticky-column-cell, + .#{$block-class}__carbon-row .#{$block-class}__checkbox-cell-sticky-left { /* stylelint-disable-next-line declaration-no-important */ background-color: $layer-01; } - .#{$block-class}__carbon-row:hover td { + .#{$block-class}__carbon-row:hover .#{$block-class}__left-sticky-column-cell, + .#{$block-class}__carbon-row:hover .#{$block-class}__right-sticky-column-cell, + .#{$block-class}__carbon-row:hover + .#{$block-class}__checkbox-cell-sticky-left { /* stylelint-disable-next-line declaration-no-important */ background-color: $layer-hover-01; } - .#{c4p-settings.$carbon-prefix}--data-table--selected td { + .#{c4p-settings.$carbon-prefix}--data-table--selected + .#{$block-class}__left-sticky-column-cell, + .#{c4p-settings.$carbon-prefix}--data-table--selected + .#{$block-class}__right-sticky-column-cell, + .#{c4p-settings.$carbon-prefix}--data-table--selected + .#{$block-class}__checkbox-cell-sticky-left { /* stylelint-disable-next-line declaration-no-important */ background-color: $layer-selected-01; } @@ -522,7 +532,7 @@ } .#{$block-class}__resizableColumn:hover { - background-color: $background-selected-hover; + background-color: $layer-selected-hover; .#{$block-class}__resizer { border-right: $spacing-01 solid $border-strong-01; @@ -562,7 +572,7 @@ &.#{$block-class}__select-all-sticky-left { position: sticky; - z-index: 1; + z-index: 10; left: 0; background-color: $layer-accent-01; } diff --git a/packages/ibm-products-styles/src/components/Datagrid/styles/_useStickyColumn.scss b/packages/ibm-products-styles/src/components/Datagrid/styles/_useStickyColumn.scss index a4b820e7e8..65b5a7bcde 100644 --- a/packages/ibm-products-styles/src/components/Datagrid/styles/_useStickyColumn.scss +++ b/packages/ibm-products-styles/src/components/Datagrid/styles/_useStickyColumn.scss @@ -36,7 +36,7 @@ .#{variables.$block-class}__left-sticky-column-header { /* stylelint-disable-next-line declaration-no-important */ position: sticky !important; - z-index: 1; + z-index: 10; left: 0; border-right: 1px solid $border-subtle; } @@ -67,6 +67,6 @@ .#{variables.$block-class}__select-all-toggle-on.#{variables.$block-class}__select-all-sticky-left { position: sticky; - z-index: 1; + z-index: 10; left: 0; } diff --git a/packages/ibm-products/src/components/Datagrid/Datagrid.stories.jsx b/packages/ibm-products/src/components/Datagrid/Datagrid.stories.jsx index b4859abf15..39e98fe57b 100644 --- a/packages/ibm-products/src/components/Datagrid/Datagrid.stories.jsx +++ b/packages/ibm-products/src/components/Datagrid/Datagrid.stories.jsx @@ -337,7 +337,7 @@ export const SelectableRow = () => { export const Header = () => { const [data] = useState(makeData(10)); - const columns = getColumns(data); + const columns = React.useMemo(() => getColumns(data), []); const emptyStateTitle = 'Empty state title'; const emptyStateDescription = 'Description explaining why the table is empty'; const datagridState = useDatagrid({ From 21a4b86e0e3d4871e6885b30a7d9f39fda0394ab Mon Sep 17 00:00:00 2001 From: Nandan Devadula <47176249+devadula-nandan@users.noreply.github.com> Date: Mon, 18 Nov 2024 11:04:14 +0530 Subject: [PATCH 4/9] chore: deprecate edit and update (#6401) * chore: deprecate EditSidePanel * chore: deprecate EditFullPage * chore: deprecate EditTearsheet * chore: deprecate EditTearsheetNarrow * chore: deprecate EditTearsheetNarrow WithValidationTemplate * chore: deprecate EditUpdateCards * fix: annotation height * fix: custom annotation on edit full page story * fix: remove grid for button, and story scroll isssue * fix: annotation padding for fulscreen variant * fix: add jsdocs deprecation as per review suggestion * refactor: used decorator story parameter to add annotation * revert: previous grid format * refactor: move grids to decorator * fix: deprecated avts --- .../EditFullPage-test.avt.e2e.js | 2 +- .../EditSidePanel-test.avt.e2e.js | 2 +- .../EditTearsheet-test.avt.e2e.js | 2 +- .../EditTearsheetNarrow-test.avt.e2e.js | 2 +- .../EditTearsheetForm-test.avt.e2e.js | 2 +- .../EditUpdateCards-test.avt.e2e.js | 2 +- .../EditFullPage/EditFullPage.stories.jsx | 25 +++++++++++-- .../EditFullPage/EditFullPage.test.js | 4 +++ .../components/EditFullPage/EditFullPage.tsx | 8 +++++ .../EditSidePanel/EditSidePanel.stories.jsx | 35 +++++++++++++------ .../EditSidePanel/EditSidePanel.test.js | 1 + .../EditSidePanel/EditSidePanel.tsx | 8 +++++ .../EditTearsheet/EditTearsheet.stories.jsx | 20 +++++++++-- .../EditTearsheet/EditTearsheet.test.js | 1 + .../EditTearsheet/EditTearsheet.tsx | 8 +++++ .../EditTearsheetNarrow.stories.jsx | 26 +++++++++++--- .../EditTearsheetNarrow.test.js | 4 +++ .../EditTearsheetNarrow.tsx | 8 +++++ .../EditUpdateCards.stories.jsx | 18 +++++++++- .../EditUpdateCards/EditUpdateCards.test.js | 4 +++ .../EditUpdateCards/EditUpdateCards.tsx | 8 +++++ 21 files changed, 164 insertions(+), 26 deletions(-) diff --git a/e2e/components/EditAndUpdate/EditFullPage-test.avt.e2e.js b/e2e/components/EditAndUpdate/EditFullPage-test.avt.e2e.js index 81eca9456b..9b1edd37d2 100644 --- a/e2e/components/EditAndUpdate/EditFullPage-test.avt.e2e.js +++ b/e2e/components/EditAndUpdate/EditFullPage-test.avt.e2e.js @@ -14,7 +14,7 @@ test.describe('EditFullPage @avt', () => { test('@avt-default-state', async ({ page }) => { await visitStory(page, { component: 'EditFullPage', - id: 'experimental-patterns-edit-and-update-editfullpage--edit-full-page', + id: 'deprecated-edit-and-update-editfullpage--edit-full-page', globals: { carbonTheme: 'white', }, diff --git a/e2e/components/EditAndUpdate/EditSidePanel-test.avt.e2e.js b/e2e/components/EditAndUpdate/EditSidePanel-test.avt.e2e.js index 624776a09d..d094a9f1c4 100644 --- a/e2e/components/EditAndUpdate/EditSidePanel-test.avt.e2e.js +++ b/e2e/components/EditAndUpdate/EditSidePanel-test.avt.e2e.js @@ -15,7 +15,7 @@ test.describe('EditSidePanel @avt', () => { test('@avt-default-state', async ({ page }) => { await visitStory(page, { component: 'EditSidePanel', - id: 'experimental-patterns-edit-and-update-editsidepanel--edit-side-panel', + id: 'deprecated-edit-and-update-editsidepanel--edit-side-panel', globals: { carbonTheme: 'white', }, diff --git a/e2e/components/EditAndUpdate/EditTearsheet-test.avt.e2e.js b/e2e/components/EditAndUpdate/EditTearsheet-test.avt.e2e.js index 59c063ef42..76bd59068e 100644 --- a/e2e/components/EditAndUpdate/EditTearsheet-test.avt.e2e.js +++ b/e2e/components/EditAndUpdate/EditTearsheet-test.avt.e2e.js @@ -15,7 +15,7 @@ test.describe('EditTearsheet @avt', () => { test('@avt-default-state', async ({ page }) => { await visitStory(page, { component: 'EditTearsheet', - id: 'experimental-patterns-edit-and-update-edittearsheet--multi-form-edit-tearsheet', + id: 'deprecated-edit-and-update-edittearsheet--multi-form-edit-tearsheet', globals: { carbonTheme: 'white', }, diff --git a/e2e/components/EditAndUpdate/EditTearsheetNarrow-test.avt.e2e.js b/e2e/components/EditAndUpdate/EditTearsheetNarrow-test.avt.e2e.js index 4345c33a02..ca79c2ed8e 100644 --- a/e2e/components/EditAndUpdate/EditTearsheetNarrow-test.avt.e2e.js +++ b/e2e/components/EditAndUpdate/EditTearsheetNarrow-test.avt.e2e.js @@ -15,7 +15,7 @@ test.describe('EditTearsheetNarrow @avt', () => { test('@avt-default-state', async ({ page }) => { await visitStory(page, { component: 'EditTearsheetNarrow', - id: 'experimental-patterns-edit-and-update-edittearsheetnarrow--edit-tearsheet-narrow', + id: 'deprecated-edit-and-update-edittearsheetnarrow--edit-tearsheet-narrow', globals: { carbonTheme: 'white', }, diff --git a/e2e/components/EditTearsheet/EditTearsheetForm-test.avt.e2e.js b/e2e/components/EditTearsheet/EditTearsheetForm-test.avt.e2e.js index 76261f1f2f..40bad294a1 100644 --- a/e2e/components/EditTearsheet/EditTearsheetForm-test.avt.e2e.js +++ b/e2e/components/EditTearsheet/EditTearsheetForm-test.avt.e2e.js @@ -15,7 +15,7 @@ test.describe('EditTearsheetForm @avt', () => { test('@avt-default-state', async ({ page }) => { await visitStory(page, { component: 'EditTearsheetForm', - id: 'experimental-patterns-edit-and-update-edittearsheet--multi-form-edit-tearsheet', + id: 'deprecated-edit-and-update-edittearsheet--multi-form-edit-tearsheet', globals: { carbonTheme: 'white', }, diff --git a/e2e/components/EditUpdateCards/EditUpdateCards-test.avt.e2e.js b/e2e/components/EditUpdateCards/EditUpdateCards-test.avt.e2e.js index a20b65a846..1b90b034f9 100644 --- a/e2e/components/EditUpdateCards/EditUpdateCards-test.avt.e2e.js +++ b/e2e/components/EditUpdateCards/EditUpdateCards-test.avt.e2e.js @@ -14,7 +14,7 @@ test.describe('EditUpdateCards @avt', () => { test('@avt-default-state', async ({ page }) => { await visitStory(page, { component: 'EditUpdateCards', - id: 'experimental-patterns-edit-and-update-editupdatecards--edit-update-cards', + id: 'deprecated-edit-and-update-editupdatecards--edit-update-cards', globals: { carbonTheme: 'white', }, diff --git a/packages/ibm-products/src/components/EditFullPage/EditFullPage.stories.jsx b/packages/ibm-products/src/components/EditFullPage/EditFullPage.stories.jsx index f0d8f644ce..4d6104db4f 100644 --- a/packages/ibm-products/src/components/EditFullPage/EditFullPage.stories.jsx +++ b/packages/ibm-products/src/components/EditFullPage/EditFullPage.stories.jsx @@ -14,6 +14,7 @@ import { pkg } from '../../settings'; import { EditFullPage } from '.'; import styles from '../CreateFullPage/_storybook-styles.scss?inline'; +import { Annotation } from '../../../../core/.storybook/Annotation'; const storyClass = 'create-full-page-stories'; const blockClass = `${pkg.prefix}--create-full-page`; @@ -34,7 +35,7 @@ import { import DocsPage from './EditFullPage.docs-page'; export default { - title: 'Experimental/Patterns/Edit and update/EditFullPage', + title: 'Deprecated/Edit and update/EditFullPage', component: EditFullPage, tags: ['autodocs'], parameters: { @@ -44,7 +45,27 @@ export default { controls: { sort: 'requiredFirst' }, }, decorators: [ - (story) =>
{story()}
, + (story) => ( +
+ {/* fullPage component styles */} + + + This component is deprecated and will be removed in the next major + version. +
+ } + > + {story()} + + + ), ], }; diff --git a/packages/ibm-products/src/components/EditFullPage/EditFullPage.test.js b/packages/ibm-products/src/components/EditFullPage/EditFullPage.test.js index f03809760c..fb096571a1 100644 --- a/packages/ibm-products/src/components/EditFullPage/EditFullPage.test.js +++ b/packages/ibm-products/src/components/EditFullPage/EditFullPage.test.js @@ -22,6 +22,10 @@ const className = `class-${uuidv4()}`; const dataTestId = uuidv4(); describe(componentName, () => { + beforeEach(() => { + jest.spyOn(console, 'warn').mockImplementation(() => {}); + }); + it('renders a component EditFullPage', async () => { render( ); expect(screen.getByRole('main')).toHaveClass(blockClass); diff --git a/packages/ibm-products/src/components/EditFullPage/EditFullPage.tsx b/packages/ibm-products/src/components/EditFullPage/EditFullPage.tsx index 5aaa1cf5e1..272ffd099a 100644 --- a/packages/ibm-products/src/components/EditFullPage/EditFullPage.tsx +++ b/packages/ibm-products/src/components/EditFullPage/EditFullPage.tsx @@ -48,8 +48,10 @@ export interface EditFullPageProps { // }; /** + * **This component is deprecated.**
* Use when settings on a page need to always be shown in edit mode, or when the context of the page is needed to make several changes. * See usage guidance for further details. + * @deprecated */ export let EditFullPage = React.forwardRef( ( @@ -90,6 +92,12 @@ export let EditFullPage = React.forwardRef( } ); +/**@ts-ignore*/ +EditFullPage.deprecated = { + level: 'warn', + details: `This component is deprecated and will be removed in the next major version.`, +}; + // Return a placeholder if not released and not enabled by feature flag EditFullPage = pkg.checkComponentEnabled(EditFullPage, componentName); diff --git a/packages/ibm-products/src/components/EditSidePanel/EditSidePanel.stories.jsx b/packages/ibm-products/src/components/EditSidePanel/EditSidePanel.stories.jsx index 7b6af2af70..17fb1a2511 100644 --- a/packages/ibm-products/src/components/EditSidePanel/EditSidePanel.stories.jsx +++ b/packages/ibm-products/src/components/EditSidePanel/EditSidePanel.stories.jsx @@ -27,6 +27,7 @@ import { EditSidePanel } from '.'; import styles from './_storybook-styles.scss?inline'; import { StoryDocsPage } from '../../global/js/utils/StoryDocsPage'; import { sidePanelDecorator } from '../../global/decorators/sidePanelDecorator'; +import { Annotation } from '../../../../core/.storybook/Annotation'; const sampleSlug = ( @@ -73,7 +74,7 @@ const renderUIShellHeader = () => ( const prefix = 'edit-side-panel-stories__'; export default { - title: 'Experimental/Patterns/Edit and update/EditSidePanel', + title: 'Deprecated/Edit and update/EditSidePanel', component: EditSidePanel, tags: ['autodocs'], // TODO: Define argTypes for props not represented by standard JS types. @@ -104,7 +105,26 @@ export default { ), }, }, - decorators: [sidePanelDecorator(renderUIShellHeader, prefix)], + decorators: [ + (story) => ( + + + + This component is deprecated and will be removed in the next + major version. + + } + > + {story()} + + + + ), + sidePanelDecorator(renderUIShellHeader, prefix), + ], }; /** @@ -117,14 +137,9 @@ const Template = ({ slug, ...args }) => { const [topicValue, setTopicValue] = useState('Cluster management'); return ( <> - {renderUIShellHeader()} - - - - - + { const { ResizeObserver } = window; beforeEach(() => { + jest.spyOn(console, 'warn').mockImplementation(() => {}); Object.defineProperty(window, 'matchMedia', { writable: true, value: jest.fn().mockImplementation((query) => ({ diff --git a/packages/ibm-products/src/components/EditSidePanel/EditSidePanel.tsx b/packages/ibm-products/src/components/EditSidePanel/EditSidePanel.tsx index 538cb3c197..46b2d0f819 100644 --- a/packages/ibm-products/src/components/EditSidePanel/EditSidePanel.tsx +++ b/packages/ibm-products/src/components/EditSidePanel/EditSidePanel.tsx @@ -128,7 +128,9 @@ export interface EditSidePanelProps { } /** + * **This component is deprecated.**
* Use with medium complexity edits if the user needs page context. + * @deprecated */ export let EditSidePanel = React.forwardRef( ( @@ -224,6 +226,12 @@ export let EditSidePanel = React.forwardRef( } ); +/**@ts-ignore*/ +EditSidePanel.deprecated = { + level: 'warn', + details: `This component is deprecated and will be removed in the next major version.`, +}; + // Return a placeholder if not released and not enabled by feature flag EditSidePanel = pkg.checkComponentEnabled(EditSidePanel, componentName); diff --git a/packages/ibm-products/src/components/EditTearsheet/EditTearsheet.stories.jsx b/packages/ibm-products/src/components/EditTearsheet/EditTearsheet.stories.jsx index 8b227b842b..6682ce87a5 100644 --- a/packages/ibm-products/src/components/EditTearsheet/EditTearsheet.stories.jsx +++ b/packages/ibm-products/src/components/EditTearsheet/EditTearsheet.stories.jsx @@ -4,15 +4,16 @@ * This source code is licensed under the Apache-2.0 license found in the * LICENSE file in the root directory of this source tree. */ - +import React from 'react'; import styles from './_storybook-styles.scss?inline'; import { EditTearsheet } from './EditTearsheet'; import DocsPage from './EditTearsheet.docs-page'; import { MultiFormEditTearsheet } from './preview-components/MultiFormEditTearsheet'; import { slugArgTypes } from '../../global/js/story-parts/slug'; +import { Annotation } from '../../../../core/.storybook/Annotation'; export default { - title: 'Experimental/Patterns/Edit and update/EditTearsheet', + title: 'Deprecated/Edit and update/EditTearsheet', component: EditTearsheet, tags: ['autodocs'], argTypes: { @@ -25,6 +26,21 @@ export default { ...slugArgTypes(), }, parameters: { styles, docs: { page: DocsPage } }, + decorators: [ + (story) => ( + + This component is deprecated and will be removed in the next major + version. + + } + > + {story()} + + ), + ], }; const editTearsheetProps = { diff --git a/packages/ibm-products/src/components/EditTearsheet/EditTearsheet.test.js b/packages/ibm-products/src/components/EditTearsheet/EditTearsheet.test.js index 31779aab33..7e7246fa89 100644 --- a/packages/ibm-products/src/components/EditTearsheet/EditTearsheet.test.js +++ b/packages/ibm-products/src/components/EditTearsheet/EditTearsheet.test.js @@ -98,6 +98,7 @@ describe(componentName, () => { const { ResizeObserver } = window; beforeEach(() => { + jest.spyOn(console, 'warn').mockImplementation(() => {}); window.ResizeObserver = jest.fn().mockImplementation(() => ({ observe: jest.fn(), unobserve: jest.fn(), diff --git a/packages/ibm-products/src/components/EditTearsheet/EditTearsheet.tsx b/packages/ibm-products/src/components/EditTearsheet/EditTearsheet.tsx index 565bbd826a..914fa6c95f 100644 --- a/packages/ibm-products/src/components/EditTearsheet/EditTearsheet.tsx +++ b/packages/ibm-products/src/components/EditTearsheet/EditTearsheet.tsx @@ -139,7 +139,9 @@ interface EditTearsheetProps extends PropsWithChildren { } /** + * **This component is deprecated.**
* Use Tearsheet with medium to complex edits. See usage guidance for further information. + * @deprecated */ export let EditTearsheet = forwardRef( ( @@ -276,6 +278,12 @@ export let EditTearsheet = forwardRef( } ); +/**@ts-ignore*/ +EditTearsheet.deprecated = { + level: 'warn', + details: `This component is deprecated and will be removed in the next major version.`, +}; + // Return a placeholder if not released and not enabled by feature flag EditTearsheet = pkg.checkComponentEnabled(EditTearsheet, componentName); diff --git a/packages/ibm-products/src/components/EditTearsheetNarrow/EditTearsheetNarrow.stories.jsx b/packages/ibm-products/src/components/EditTearsheetNarrow/EditTearsheetNarrow.stories.jsx index 71ea1e469e..5a59eaa0a9 100644 --- a/packages/ibm-products/src/components/EditTearsheetNarrow/EditTearsheetNarrow.stories.jsx +++ b/packages/ibm-products/src/components/EditTearsheetNarrow/EditTearsheetNarrow.stories.jsx @@ -22,9 +22,10 @@ import { CreateTearsheetNarrow } from '../CreateTearsheetNarrow'; import styles from '../CreateTearsheetNarrow/_storybook-styles.scss?inline'; import { StoryDocsPage } from '../../global/js/utils/StoryDocsPage'; import { SlugSample, slugArgTypes } from '../../global/js/story-parts/slug'; +import { Annotation } from '../../../../core/.storybook/Annotation'; export default { - title: 'Experimental/Patterns/Edit and update/EditTearsheetNarrow', + title: 'Deprecated/Edit and update/EditTearsheetNarrow', component: EditTearsheetNarrow, tags: ['autodocs'], parameters: { @@ -35,6 +36,21 @@ export default { ), }, }, + decorators: [ + (story) => ( + + This component is deprecated and will be removed in the next major + version. + + } + > + {story()} + + ), + ], argTypes: { ...slugArgTypes(), }, @@ -71,7 +87,7 @@ const Template = ({ slug, ...args }) => { retentionTime <= 0 || quantity <= 0; return ( -
+ <>
+ ); }; @@ -169,7 +185,7 @@ const WithValidationTemplate = ({ slug, ...args }) => { retentionTime <= 0 || quantity <= 0; return ( -
+ <>
+ ); }; diff --git a/packages/ibm-products/src/components/EditTearsheetNarrow/EditTearsheetNarrow.test.js b/packages/ibm-products/src/components/EditTearsheetNarrow/EditTearsheetNarrow.test.js index 8960fcf9ab..c879a6612e 100644 --- a/packages/ibm-products/src/components/EditTearsheetNarrow/EditTearsheetNarrow.test.js +++ b/packages/ibm-products/src/components/EditTearsheetNarrow/EditTearsheetNarrow.test.js @@ -22,6 +22,10 @@ const className = `class-${uuidv4()}`; const dataTestId = uuidv4(); describe(componentName, () => { + beforeEach(() => { + jest.spyOn(console, 'warn').mockImplementation(() => {}); + }); + it('renders a component EditTearsheetNarrow', async () => { render( ); expect(screen.getByRole('main')).toHaveClass(blockClass); diff --git a/packages/ibm-products/src/components/EditTearsheetNarrow/EditTearsheetNarrow.tsx b/packages/ibm-products/src/components/EditTearsheetNarrow/EditTearsheetNarrow.tsx index 294541a385..b62744a513 100644 --- a/packages/ibm-products/src/components/EditTearsheetNarrow/EditTearsheetNarrow.tsx +++ b/packages/ibm-products/src/components/EditTearsheetNarrow/EditTearsheetNarrow.tsx @@ -50,7 +50,9 @@ export interface EditTearsheetNarrowProps { } /** + * **This component is deprecated.**
* Use a narrow tearsheet as an alternative to a modal when there is scrolling. See usage guidance for further information. + * @deprecated */ export let EditTearsheetNarrow = React.forwardRef( ( @@ -91,6 +93,12 @@ export let EditTearsheetNarrow = React.forwardRef( } ); +/**@ts-ignore*/ +EditTearsheetNarrow.deprecated = { + level: 'warn', + details: `This component is deprecated and will be removed in the next major version.`, +}; + // Return a placeholder if not released and not enabled by feature flag EditTearsheetNarrow = pkg.checkComponentEnabled( EditTearsheetNarrow, diff --git a/packages/ibm-products/src/components/EditUpdateCards/EditUpdateCards.stories.jsx b/packages/ibm-products/src/components/EditUpdateCards/EditUpdateCards.stories.jsx index 7c9f4e9f96..365ca702a4 100644 --- a/packages/ibm-products/src/components/EditUpdateCards/EditUpdateCards.stories.jsx +++ b/packages/ibm-products/src/components/EditUpdateCards/EditUpdateCards.stories.jsx @@ -28,9 +28,10 @@ import { } from '@carbon/react/icons'; import { pkg /*, carbon */ } from '../../settings'; import { StoryDocsPage } from '../../global/js/utils/StoryDocsPage'; +import { Annotation } from '../../../../core/.storybook/Annotation'; export default { - title: 'Experimental/Patterns/Edit and update/EditUpdateCards', + title: 'Deprecated/Edit and update/EditUpdateCards', component: EditUpdateCards, tags: ['autodocs'], // TODO: Define argTypes for props not represented by standard JS types. @@ -45,6 +46,21 @@ export default { ), }, }, + decorators: [ + (story) => ( + + This component is deprecated and will be removed in the next major + version. + + } + > + {story()} + + ), + ], }; const defaultStoryProps = { diff --git a/packages/ibm-products/src/components/EditUpdateCards/EditUpdateCards.test.js b/packages/ibm-products/src/components/EditUpdateCards/EditUpdateCards.test.js index d4d381b2d5..5d390eeb99 100644 --- a/packages/ibm-products/src/components/EditUpdateCards/EditUpdateCards.test.js +++ b/packages/ibm-products/src/components/EditUpdateCards/EditUpdateCards.test.js @@ -22,6 +22,10 @@ const className = `class-${uuidv4()}`; const dataTestId = uuidv4(); describe(componentName, () => { + beforeEach(() => { + jest.spyOn(console, 'warn').mockImplementation(() => {}); + }); + it('renders a component EditUpdateCards', async () => { render( ); expect(screen.getByTestId(dataTestId)).toHaveClass(blockClass); diff --git a/packages/ibm-products/src/components/EditUpdateCards/EditUpdateCards.tsx b/packages/ibm-products/src/components/EditUpdateCards/EditUpdateCards.tsx index 4085330429..ca68d5bc8a 100644 --- a/packages/ibm-products/src/components/EditUpdateCards/EditUpdateCards.tsx +++ b/packages/ibm-products/src/components/EditUpdateCards/EditUpdateCards.tsx @@ -139,9 +139,11 @@ export interface EditUpdateCardsProps { // }; /** + * **This component is deprecated.**
Editable cards allow a user to view, modify, and save the content contained within the card. These cards are generally used in instances where a user needs to make changes to a resource instances (ex. configuration details), account plan, etc. Editable cards allow a user to edit something within context. + @deprecated */ export let EditUpdateCards = React.forwardRef( ( @@ -220,6 +222,12 @@ export let EditUpdateCards = React.forwardRef( } ); +/**@ts-ignore*/ +EditUpdateCards.deprecated = { + level: 'warn', + details: `This component is deprecated and will be removed in the next major version.`, +}; + // Return a placeholder if not released and not enabled by feature flag EditUpdateCards = pkg.checkComponentEnabled(EditUpdateCards, componentName); From 2ef70ba6fd56983d30d1a1d2f6658ce155b01acf Mon Sep 17 00:00:00 2001 From: Nandan Devadula <47176249+devadula-nandan@users.noreply.github.com> Date: Mon, 18 Nov 2024 11:04:34 +0530 Subject: [PATCH 5/9] docs(Tearsheet): add aiLabel usage to docs (#6441) * docs(Tearsheet): add aiLabel usage to docs * fix: lint --------- Co-authored-by: Matt Gallo --- .../Tearsheet/Tearsheet.docs-page.js | 69 +++++++++++++++++++ .../src/components/Tearsheet/Tearsheet.mdx | 60 ---------------- .../Tearsheet/Tearsheet.stories.jsx | 11 ++- 3 files changed, 78 insertions(+), 62 deletions(-) create mode 100644 packages/ibm-products/src/components/Tearsheet/Tearsheet.docs-page.js delete mode 100644 packages/ibm-products/src/components/Tearsheet/Tearsheet.mdx diff --git a/packages/ibm-products/src/components/Tearsheet/Tearsheet.docs-page.js b/packages/ibm-products/src/components/Tearsheet/Tearsheet.docs-page.js new file mode 100644 index 0000000000..16ed7a35dc --- /dev/null +++ b/packages/ibm-products/src/components/Tearsheet/Tearsheet.docs-page.js @@ -0,0 +1,69 @@ +/** + * Copyright IBM Corp. 2024 + * + * This source code is licensed under the Apache-2.0 license found in the + * LICENSE file in the root directory of this source tree. + */ + +import React from 'react'; +import { StoryDocsPage } from '../../global/js/utils/StoryDocsPage'; + +import * as stories from './Tearsheet.stories'; + +const DocsPage = () => ( + + ... ... + + } +> + ... + + `, + }, + }, + ]} + /> +); + +export default DocsPage; diff --git a/packages/ibm-products/src/components/Tearsheet/Tearsheet.mdx b/packages/ibm-products/src/components/Tearsheet/Tearsheet.mdx deleted file mode 100644 index 2ad5bd5db2..0000000000 --- a/packages/ibm-products/src/components/Tearsheet/Tearsheet.mdx +++ /dev/null @@ -1,60 +0,0 @@ -import { Story, Controls, Source, Canvas } from '@storybook/addon-docs'; -import { CodesandboxLink } from '../../global/js/utils/story-helper'; -import { Tearsheet, TearsheetNarrow } from '.'; -import * as TearsheetStories from './Tearsheet.stories'; -import * as TearsheetNarrowStories from './Tearsheet.stories'; -import AnatomyImg from './_story-assets/tearsheet-anatomy.png'; - -# Tearsheet and TearsheetNarrow - -## Table of Contents - -- [Overview](#overview) -- [Example usage](#example-usage) -- [Component API](#component-api) - -## Overview - -A tearsheet is a mostly full-screen type of dialog that keeps users in-context -and focused by bringing actionable content front and center while revealing -parts of the UI behind it. There are two sizes of tearsheets: narrow and wide. - -A tearsheet is comprised of up to 5 zones, allowing for flexibility depending on -the content. - - - -1. **Header zone:** Includes a one or more of a label, title, description, - navigation area (e.g. for tabs) and close icon. -2. **Main content area:** This typically contains forms, tables, and items that - a user may interact with. -3. **Navigation buttons:** Used to navigate the flow and to finalize/complete - the steps required. -4. **Influencer:** This usually contains a menu, vertical progress indicator, or - filters. Can be on the left or right, and has 2 possible widths. Not - available in narrow tearsheets. -5. **Background overlay:** Obscures underlying page content. - -Tearsheets may be stacked up to 3 levels deep. - -## Example usage - -### Wide tearsheet - - - - - -### Narrow tearsheet - - - - - -## Code sample - - - -## Component API - - diff --git a/packages/ibm-products/src/components/Tearsheet/Tearsheet.stories.jsx b/packages/ibm-products/src/components/Tearsheet/Tearsheet.stories.jsx index 3d062b3200..c17a2686e9 100644 --- a/packages/ibm-products/src/components/Tearsheet/Tearsheet.stories.jsx +++ b/packages/ibm-products/src/components/Tearsheet/Tearsheet.stories.jsx @@ -6,6 +6,7 @@ */ import React, { useRef, useState } from 'react'; +import DocsPage from './Tearsheet.docs-page'; import { action } from '@storybook/addon-actions'; @@ -44,7 +45,13 @@ export default { title: 'IBM Products/Components/Tearsheet', component: Tearsheet, tags: ['autodocs'], - parameters: { styles /* docs: { page: mdx } */, layout: 'fullscreen' }, + parameters: { + styles, + layout: 'fullscreen', + docs: { + page: DocsPage, + }, + }, argTypes: { ...getDeprecatedArgTypes(deprecatedProps), actions: { @@ -173,7 +180,7 @@ const mainContent = ( const title = 'Title of the tearsheet'; const sampleAILabel = ( - +

AI Explained

From 1f5b63ec428ddd2a2b2ee7c4153c83c2fff6a61c Mon Sep 17 00:00:00 2001 From: Amal K Joy <153802538+amal-k-joy@users.noreply.github.com> Date: Mon, 18 Nov 2024 12:16:19 +0530 Subject: [PATCH 6/9] fix(conditionBuilder): issue fix and data correction (#6421) --- .../ConditionBuilderItemOption/ItemOption.tsx | 3 --- .../ItemOptionForValueField.tsx | 6 ++++-- .../src/components/ConditionBuilder/assets/SampleData.js | 8 ++++---- 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderItem/ConditionBuilderItemOption/ItemOption.tsx b/packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderItem/ConditionBuilderItemOption/ItemOption.tsx index b21bd01e0a..83f421674c 100644 --- a/packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderItem/ConditionBuilderItemOption/ItemOption.tsx +++ b/packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderItem/ConditionBuilderItemOption/ItemOption.tsx @@ -85,8 +85,6 @@ export const ItemOption = ({ ); }; - const preventDefault = (evt) => evt.preventDefault(); - if (!allOptions) { return; } @@ -99,7 +97,6 @@ export const ItemOption = ({ labelText={clearSearchText} closeButtonLabelText={clearSearchText} onChange={onSearchChangeHandler} - onKeyDown={preventDefault} />
)} diff --git a/packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderItem/ConditionBuilderItemOption/ItemOptionForValueField.tsx b/packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderItem/ConditionBuilderItemOption/ItemOptionForValueField.tsx index 198b1696e9..9f0728e9ae 100644 --- a/packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderItem/ConditionBuilderItemOption/ItemOptionForValueField.tsx +++ b/packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderItem/ConditionBuilderItemOption/ItemOptionForValueField.tsx @@ -145,6 +145,10 @@ export const ItemOptionForValueField = ({ } else { onChange(option, evt); } + if (evt.target instanceof SVGElement) { + evt.stopPropagation(); + //stop propagate event , since this closes the popover when clicked on checkboxes which are SVGs. + } }; const getAriaLabel = () => { @@ -154,7 +158,6 @@ export const ItemOptionForValueField = ({ ? conditionState.property : propertyText; }; - const preventDefault = (evt) => evt.preventDefault(); if (!allOptions) { return ; @@ -168,7 +171,6 @@ export const ItemOptionForValueField = ({ labelText={clearSearchText} closeButtonLabelText={clearSearchText} onChange={onSearchChangeHandler} - onKeyDown={preventDefault} /> )} diff --git a/packages/ibm-products/src/components/ConditionBuilder/assets/SampleData.js b/packages/ibm-products/src/components/ConditionBuilder/assets/SampleData.js index 07814302f7..5c2543bdea 100644 --- a/packages/ibm-products/src/components/ConditionBuilder/assets/SampleData.js +++ b/packages/ibm-products/src/components/ConditionBuilder/assets/SampleData.js @@ -140,12 +140,12 @@ export const sampleDataStructure_nonHierarchical = { operator: 'oneOf', value: [ { - label: 'Africa', - id: 'Africa', + label: 'Afghanistan', + id: 'AF', }, { - label: { id: 'India', label: 'India' }, - id: 'Ind', + label: 'Albania', + id: 'AL', }, ], id: uuidv4(), From 7428bdf2bd46142c548c70180dc1cc369add01ca Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 18 Nov 2024 10:01:06 -0500 Subject: [PATCH 7/9] chore(deps): bump @eslint/plugin-kit from 0.2.0 to 0.2.3 (#6450) Bumps [@eslint/plugin-kit](https://github.com/eslint/rewrite) from 0.2.0 to 0.2.3. - [Release notes](https://github.com/eslint/rewrite/releases) - [Changelog](https://github.com/eslint/rewrite/blob/main/release-please-config.json) - [Commits](https://github.com/eslint/rewrite/compare/core-v0.2.0...plugin-kit-v0.2.3) --- updated-dependencies: - dependency-name: "@eslint/plugin-kit" dependency-type: indirect ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- yarn.lock | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/yarn.lock b/yarn.lock index 30e223c29c..8c6cf936af 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3648,11 +3648,11 @@ __metadata: linkType: hard "@eslint/plugin-kit@npm:^0.2.0": - version: 0.2.0 - resolution: "@eslint/plugin-kit@npm:0.2.0" + version: 0.2.3 + resolution: "@eslint/plugin-kit@npm:0.2.3" dependencies: levn: "npm:^0.4.1" - checksum: ebb363174397341dea47dc35fc206e24328083e4f0fa1c539687dbb7f94bef77e43faa12867d032e6eea5ac980ea8fbb6b1d844186e422d327c04088041b99f3 + checksum: 0d0653ef840823fd5c0354ef8f1937e7763dbe830173eb6d2d55a19374bf04a06dff0e5214330c10a9425cf38655f632bb0d7d0666249b366e506ae291d82f7e languageName: node linkType: hard From 711eb72ef00d1f1935fd0fcec9e0c0383dff53dc Mon Sep 17 00:00:00 2001 From: David Menendez Date: Mon, 18 Nov 2024 12:59:45 -0600 Subject: [PATCH 8/9] feat: add utils section to storybook (#6394) * feat: add utils section to storybook * fix: avt urls --- e2e/components/ActionBar/ActionBar-test.avt.e2e.js | 2 +- e2e/components/Cascade/Cascade-test.avt.e2e.js | 2 +- e2e/components/DelimitedList/DelimitedList-test.avt.e2e.js | 2 +- e2e/components/ScrollGradient/ScrollGradient-test.avt.e2e.js | 2 +- e2e/components/TagOverflow/TagOverflow-test.avt.e2e.js | 2 +- e2e/components/TruncatedList/TruncatedList-test.avt.e2e.js | 2 +- packages/core/.storybook/preview.js | 2 ++ .../ibm-products/src/components/ActionBar/ActionBar.stories.jsx | 2 +- .../ibm-products/src/components/Cascade/Cascade.stories.jsx | 2 +- .../src/components/DelimitedList/DelimitedList.stories.jsx | 2 +- .../src/components/ScrollGradient/ScrollGradient.stories.jsx | 2 +- .../src/components/TagOverflow/TagOverflow.stories.jsx | 2 +- .../src/components/TruncatedList/TruncatedList.stories.jsx | 2 +- 13 files changed, 14 insertions(+), 12 deletions(-) diff --git a/e2e/components/ActionBar/ActionBar-test.avt.e2e.js b/e2e/components/ActionBar/ActionBar-test.avt.e2e.js index 35a4afc4bb..edd6deb38e 100644 --- a/e2e/components/ActionBar/ActionBar-test.avt.e2e.js +++ b/e2e/components/ActionBar/ActionBar-test.avt.e2e.js @@ -14,7 +14,7 @@ test.describe('ActionBar @avt', () => { test('@avt-default-state', async ({ page }) => { await visitStory(page, { component: 'ActionBar', - id: 'experimental-components-actionbar--default', + id: 'utils-components-actionbar--default', globals: { carbonTheme: 'white', }, diff --git a/e2e/components/Cascade/Cascade-test.avt.e2e.js b/e2e/components/Cascade/Cascade-test.avt.e2e.js index dd5ae696b3..b7031011d9 100644 --- a/e2e/components/Cascade/Cascade-test.avt.e2e.js +++ b/e2e/components/Cascade/Cascade-test.avt.e2e.js @@ -14,7 +14,7 @@ test.describe('Cascade @avt', () => { test('@avt-default-state', async ({ page }) => { await visitStory(page, { component: 'Cascade', - id: 'ibm-products-patterns-cascade--without-grid', + id: 'utils-components-cascade--without-grid', globals: { carbonTheme: 'white', }, diff --git a/e2e/components/DelimitedList/DelimitedList-test.avt.e2e.js b/e2e/components/DelimitedList/DelimitedList-test.avt.e2e.js index 4213a37e49..098ee731cb 100644 --- a/e2e/components/DelimitedList/DelimitedList-test.avt.e2e.js +++ b/e2e/components/DelimitedList/DelimitedList-test.avt.e2e.js @@ -14,7 +14,7 @@ test.describe('DelimitedList @avt', () => { test('@avt-default-state', async ({ page }) => { await visitStory(page, { component: 'DelimitedList', - id: 'experimental-components-delimited-list-delimitedlist--delimited', + id: 'utils-components-delimitedlist--delimited', globals: { carbonTheme: 'white', }, diff --git a/e2e/components/ScrollGradient/ScrollGradient-test.avt.e2e.js b/e2e/components/ScrollGradient/ScrollGradient-test.avt.e2e.js index 62d8bdeba2..527360454a 100644 --- a/e2e/components/ScrollGradient/ScrollGradient-test.avt.e2e.js +++ b/e2e/components/ScrollGradient/ScrollGradient-test.avt.e2e.js @@ -14,7 +14,7 @@ test.describe('ScrollGradient @avt', () => { test('@avt-default-state', async ({ page }) => { await visitStory(page, { component: 'ScrollGradient', - id: 'experimental-components-scroll-gradient-scrollgradient--scroll-gradient-vertical', + id: 'utils-components-scrollgradient--scroll-gradient-vertical', globals: { carbonTheme: 'white', }, diff --git a/e2e/components/TagOverflow/TagOverflow-test.avt.e2e.js b/e2e/components/TagOverflow/TagOverflow-test.avt.e2e.js index b9feaad161..f794dfa7d9 100644 --- a/e2e/components/TagOverflow/TagOverflow-test.avt.e2e.js +++ b/e2e/components/TagOverflow/TagOverflow-test.avt.e2e.js @@ -14,7 +14,7 @@ test.describe('TagOverflow @avt', () => { test('@avt-default-state', async ({ page }) => { await visitStory(page, { component: 'TagOverflow', - id: 'experimental-components-tag-overflow-tagoverflow--tags-with-overflow-count', + id: 'utils-components-tagoverflow--tags-with-overflow-count', globals: { carbonTheme: 'white', }, diff --git a/e2e/components/TruncatedList/TruncatedList-test.avt.e2e.js b/e2e/components/TruncatedList/TruncatedList-test.avt.e2e.js index 4f9ec76861..8f8bd6ed42 100644 --- a/e2e/components/TruncatedList/TruncatedList-test.avt.e2e.js +++ b/e2e/components/TruncatedList/TruncatedList-test.avt.e2e.js @@ -16,7 +16,7 @@ test.describe('TruncatedList @avt', () => { test('@avt-default-state', async ({ page }) => { await visitStory(page, { component: 'TruncatedList', - id: 'experimental-components-truncated-list-truncatedlist--truncated-list', + id: 'utils-components-truncatedlist--truncated-list', globals: { carbonTheme: 'white', }, diff --git a/packages/core/.storybook/preview.js b/packages/core/.storybook/preview.js index 39886913cd..3749462492 100644 --- a/packages/core/.storybook/preview.js +++ b/packages/core/.storybook/preview.js @@ -128,6 +128,8 @@ const parameters = { ['Components', 'Patterns', 'Internal', 'Onboarding'], 'Experimental', ['Components', 'Patterns', 'Onboarding'], + 'Utils', + ['Components'], 'Deprecated', ], }, diff --git a/packages/ibm-products/src/components/ActionBar/ActionBar.stories.jsx b/packages/ibm-products/src/components/ActionBar/ActionBar.stories.jsx index 339bb777ef..af5ceee927 100644 --- a/packages/ibm-products/src/components/ActionBar/ActionBar.stories.jsx +++ b/packages/ibm-products/src/components/ActionBar/ActionBar.stories.jsx @@ -29,7 +29,7 @@ const getActions = (num) => })); export default { - title: 'Experimental/Components/ActionBar', + title: 'Utils/Components/ActionBar', component: ActionBar, tags: ['autodocs'], argTypes: { diff --git a/packages/ibm-products/src/components/Cascade/Cascade.stories.jsx b/packages/ibm-products/src/components/Cascade/Cascade.stories.jsx index 9e4ec7bf05..1d8b1629b5 100644 --- a/packages/ibm-products/src/components/Cascade/Cascade.stories.jsx +++ b/packages/ibm-products/src/components/Cascade/Cascade.stories.jsx @@ -12,7 +12,7 @@ import { Column } from '@carbon/react'; import DocsPage from './Cascade.docs-page'; export default { - title: 'IBM Products/Patterns/Cascade', + title: 'Utils/Components/Cascade', component: Cascade, tags: ['autodocs'], parameters: { diff --git a/packages/ibm-products/src/components/DelimitedList/DelimitedList.stories.jsx b/packages/ibm-products/src/components/DelimitedList/DelimitedList.stories.jsx index 62cad69893..f3c8996f50 100644 --- a/packages/ibm-products/src/components/DelimitedList/DelimitedList.stories.jsx +++ b/packages/ibm-products/src/components/DelimitedList/DelimitedList.stories.jsx @@ -15,7 +15,7 @@ import { DocsPage } from './DelimitedList.docs-page'; const storyClass = 'delimited-list-stories'; export default { - title: 'Experimental/Components/Delimited list/DelimitedList', + title: 'Utils/Components/DelimitedList', component: DelimitedList, tags: ['autodocs'], parameters: { diff --git a/packages/ibm-products/src/components/ScrollGradient/ScrollGradient.stories.jsx b/packages/ibm-products/src/components/ScrollGradient/ScrollGradient.stories.jsx index 626687f7b6..c6054047ce 100644 --- a/packages/ibm-products/src/components/ScrollGradient/ScrollGradient.stories.jsx +++ b/packages/ibm-products/src/components/ScrollGradient/ScrollGradient.stories.jsx @@ -26,7 +26,7 @@ const storyChildren = ( ); export default { - title: 'Experimental/Components/Scroll gradient/ScrollGradient', + title: 'Utils/Components/ScrollGradient', component: ScrollGradient, tags: ['autodocs'], // TODO: Define argTypes for props not represented by standard JS types. diff --git a/packages/ibm-products/src/components/TagOverflow/TagOverflow.stories.jsx b/packages/ibm-products/src/components/TagOverflow/TagOverflow.stories.jsx index 100b082778..e7fd34845e 100644 --- a/packages/ibm-products/src/components/TagOverflow/TagOverflow.stories.jsx +++ b/packages/ibm-products/src/components/TagOverflow/TagOverflow.stories.jsx @@ -30,7 +30,7 @@ const blockClass = `${pkg.prefix}--tag-set`; const blockClassModal = `${blockClass}-modal`; export default { - title: 'Experimental/Components/Tag overflow/TagOverflow', + title: 'Utils/Components/TagOverflow', component: TagOverflow, tags: ['autodocs'], parameters: { diff --git a/packages/ibm-products/src/components/TruncatedList/TruncatedList.stories.jsx b/packages/ibm-products/src/components/TruncatedList/TruncatedList.stories.jsx index 033f808a21..62aff87aa9 100644 --- a/packages/ibm-products/src/components/TruncatedList/TruncatedList.stories.jsx +++ b/packages/ibm-products/src/components/TruncatedList/TruncatedList.stories.jsx @@ -18,7 +18,7 @@ import mdx from './TruncatedList.mdx'; const storyClass = 'truncated-list-stories'; export default { - title: 'Experimental/Components/Truncated list/TruncatedList', + title: 'Utils/Components/TruncatedList', component: TruncatedList, tags: ['autodocs'], // TODO: Define argTypes for props not represented by standard JS types. From 98b30f3c808931441917a520405df56147d39ac7 Mon Sep 17 00:00:00 2001 From: Nandan Devadula <47176249+devadula-nandan@users.noreply.github.com> Date: Wed, 20 Nov 2024 01:59:41 +0530 Subject: [PATCH 9/9] chore: increase percy stability in ci checks (#6467) * chore: increase percy stability in ci checks * fix: network idle timeout in percy config * fix: network idle timeout within recommended treshold * chore: clean up and test with less timeout --- .percy.yml | 7 ++++++- .../components/CreateFullPage/CreateFullPage.stories.jsx | 7 +++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/.percy.yml b/.percy.yml index 859929afc9..59f582dc7c 100644 --- a/.percy.yml +++ b/.percy.yml @@ -5,13 +5,18 @@ snapshot: - 360 - 1366 minHeight: 1024 +discovery: + network_idle_timeout: 500 storybook: include: ['/IBM Products/'] exclude: [ '/Datagrid/*', '/DataSpreadsheet/', + 'Cascade: With Grid', + 'Cascade: Without Grid', + # to be fixed '/MultiAddSelect: With Avatars/', # avoid dynamic avatar color generation '/Tag set/TagSet: Hundreds Of Tags', # avoid dynamic tag color generation - '/Page header/PageHeader: Page header with all items, pre-collapsed', # takes random time, to collapse on initial load + '/Page header/PageHeader: Page header with all items, pre-collapsed', # takes random time, to collapse on initial load. '/Tag set/TagSet: Many Tags', # takes time to calculate the overflow, causing random layout shift ] diff --git a/packages/ibm-products/src/components/CreateFullPage/CreateFullPage.stories.jsx b/packages/ibm-products/src/components/CreateFullPage/CreateFullPage.stories.jsx index 1108fbfd32..1850755831 100644 --- a/packages/ibm-products/src/components/CreateFullPage/CreateFullPage.stories.jsx +++ b/packages/ibm-products/src/components/CreateFullPage/CreateFullPage.stories.jsx @@ -56,12 +56,11 @@ export default { docs: { page: DocsPage }, controls: { sort: 'requiredFirst' }, percy: { - waitForSelector: [ - `button.${blockClass}__create-button`, - `.${blockClass}__influencer`, - ], + waitForSelector: `button.${blockClass}__create-button`, + waitForSelector: `.${blockClass}__influencer`, }, }, + decorators: [ (story) =>
{story()}
, ],