Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SkipToContent]: does not target any part of the page to allow skipping #606

Closed
jendowns opened this issue Dec 11, 2019 · 3 comments · Fixed by #607
Closed

[SkipToContent]: does not target any part of the page to allow skipping #606

jendowns opened this issue Dec 11, 2019 · 3 comments · Fixed by #607

Comments

@jendowns
Copy link
Contributor

Detailed description

The SkipToContent component is meant to link out to the main section of a page, to allow keyboard users to skip directly to that content.

Unfortunately, while the SkipToContent component currently links to #main-content, there is currently no element/target with that id on any of the pages. As a result, the SkipToContent link does not go anywhere.

Ideally, there would be an element on the page somewhere with the id="main-content" so that when a user activates the SkipToContent link, they can jump to that element/target.

@jendowns
Copy link
Contributor Author

I can open a PR to propose a fix for this shortly 👍

@jendowns
Copy link
Contributor Author

Also FYI this affects the Carbon website as well -- but I assume that a change here would ultimately be absorbed into the website after a version bump?

@jendowns jendowns changed the title [SkipToContent]: does not function correctly by targetting any part of the page [SkipToContent]: does not target any part of the page to allow skipping Dec 11, 2019
@alisonjoseph
Copy link
Member

Thanks @jendowns! and yep the change would be applied to all the websites using the theme once updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants