From 7f621e78d9e8e078b294bace8119797d83bc6a9b Mon Sep 17 00:00:00 2001
From: Josh Black <josh@josh.black>
Date: Wed, 11 Dec 2019 12:13:37 -0600
Subject: [PATCH 1/2] fix(data-table): update menu to match visible and
 accessible labels

---
 packages/react/src/components/DataTable/TableToolbarMenu.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/packages/react/src/components/DataTable/TableToolbarMenu.js b/packages/react/src/components/DataTable/TableToolbarMenu.js
index b745f015392c..6ad394bca816 100644
--- a/packages/react/src/components/DataTable/TableToolbarMenu.js
+++ b/packages/react/src/components/DataTable/TableToolbarMenu.js
@@ -27,9 +27,11 @@ const TableToolbarMenu = ({
   );
   return (
     <OverflowMenu
+      ariaLabel={iconDescription}
       renderIcon={renderIcon}
       className={toolbarActionClasses}
       title={iconDescription}
+      iconDescription={iconDescription}
       flipped
       {...rest}>
       {children}

From e51fa409e363c6d540ffc3e5eaddafbaef64f1bb Mon Sep 17 00:00:00 2001
From: Josh Black <josh@josh.black>
Date: Wed, 11 Dec 2019 16:18:09 -0600
Subject: [PATCH 2/2] chore(react): update snapshots

---
 .../__snapshots__/DataTable-test.js.snap      | 32 +++++++++++--------
 .../TableToolbarMenu-test.js.snap             | 16 ++++++----
 2 files changed, 27 insertions(+), 21 deletions(-)

diff --git a/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap b/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap
index 7273314e7f8e..a2a5c3cd4e80 100644
--- a/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap
+++ b/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap
@@ -2342,8 +2342,10 @@ exports[`DataTable should render 1`] = `
                 }
               >
                 <ForwardRef(OverflowMenu)
+                  ariaLabel="Settings"
                   className="bx--toolbar-action bx--overflow-menu"
                   flipped={true}
+                  iconDescription="Settings"
                   renderIcon={
                     Object {
                       "$$typeof": Symbol(react.forward_ref),
@@ -2353,11 +2355,11 @@ exports[`DataTable should render 1`] = `
                   title="Settings"
                 >
                   <OverflowMenu
-                    ariaLabel="Menu"
+                    ariaLabel="Settings"
                     className="bx--toolbar-action bx--overflow-menu"
                     direction="bottom"
                     flipped={true}
-                    iconDescription="open and close list of options"
+                    iconDescription="Settings"
                     innerRef={null}
                     light={false}
                     menuOffset={[Function]}
@@ -2382,7 +2384,7 @@ exports[`DataTable should render 1`] = `
                       <button
                         aria-expanded={false}
                         aria-haspopup={true}
-                        aria-label="Menu"
+                        aria-label="Settings"
                         className="bx--toolbar-action bx--overflow-menu bx--overflow-menu"
                         onClick={[Function]}
                         onClose={[Function]}
@@ -2392,14 +2394,14 @@ exports[`DataTable should render 1`] = `
                         title="Settings"
                       >
                         <ForwardRef(Settings16)
-                          aria-label="open and close list of options"
+                          aria-label="Settings"
                           className="bx--overflow-menu__icon"
                           focusable="false"
                           onClick={[Function]}
                           onKeyDown={[Function]}
                         >
                           <Icon
-                            aria-label="open and close list of options"
+                            aria-label="Settings"
                             className="bx--overflow-menu__icon"
                             focusable="false"
                             height={16}
@@ -2411,7 +2413,7 @@ exports[`DataTable should render 1`] = `
                             xmlns="http://www.w3.org/2000/svg"
                           >
                             <svg
-                              aria-label="open and close list of options"
+                              aria-label="Settings"
                               className="bx--overflow-menu__icon"
                               focusable="false"
                               height={16}
@@ -2435,7 +2437,7 @@ exports[`DataTable should render 1`] = `
                                 d="M8 11c-1.7 0-3-1.3-3-3s1.3-3 3-3 3 1.3 3 3c0 1.6-1.3 3-3 3zm0-5c-1.1 0-2 .8-2 1.9V8c0 1.1.8 2 1.9 2H8c1.1 0 2-.8 2-1.9V8c0-1.1-.8-2-2-2 .1 0 0 0 0 0z"
                               />
                               <title>
-                                open and close list of options
+                                Settings
                               </title>
                             </svg>
                           </Icon>
@@ -3317,8 +3319,10 @@ exports[`DataTable sticky header should render 1`] = `
                 }
               >
                 <ForwardRef(OverflowMenu)
+                  ariaLabel="Settings"
                   className="bx--toolbar-action bx--overflow-menu"
                   flipped={true}
+                  iconDescription="Settings"
                   renderIcon={
                     Object {
                       "$$typeof": Symbol(react.forward_ref),
@@ -3328,11 +3332,11 @@ exports[`DataTable sticky header should render 1`] = `
                   title="Settings"
                 >
                   <OverflowMenu
-                    ariaLabel="Menu"
+                    ariaLabel="Settings"
                     className="bx--toolbar-action bx--overflow-menu"
                     direction="bottom"
                     flipped={true}
-                    iconDescription="open and close list of options"
+                    iconDescription="Settings"
                     innerRef={null}
                     light={false}
                     menuOffset={[Function]}
@@ -3357,7 +3361,7 @@ exports[`DataTable sticky header should render 1`] = `
                       <button
                         aria-expanded={false}
                         aria-haspopup={true}
-                        aria-label="Menu"
+                        aria-label="Settings"
                         className="bx--toolbar-action bx--overflow-menu bx--overflow-menu"
                         onClick={[Function]}
                         onClose={[Function]}
@@ -3367,14 +3371,14 @@ exports[`DataTable sticky header should render 1`] = `
                         title="Settings"
                       >
                         <ForwardRef(Settings16)
-                          aria-label="open and close list of options"
+                          aria-label="Settings"
                           className="bx--overflow-menu__icon"
                           focusable="false"
                           onClick={[Function]}
                           onKeyDown={[Function]}
                         >
                           <Icon
-                            aria-label="open and close list of options"
+                            aria-label="Settings"
                             className="bx--overflow-menu__icon"
                             focusable="false"
                             height={16}
@@ -3386,7 +3390,7 @@ exports[`DataTable sticky header should render 1`] = `
                             xmlns="http://www.w3.org/2000/svg"
                           >
                             <svg
-                              aria-label="open and close list of options"
+                              aria-label="Settings"
                               className="bx--overflow-menu__icon"
                               focusable="false"
                               height={16}
@@ -3410,7 +3414,7 @@ exports[`DataTable sticky header should render 1`] = `
                                 d="M8 11c-1.7 0-3-1.3-3-3s1.3-3 3-3 3 1.3 3 3c0 1.6-1.3 3-3 3zm0-5c-1.1 0-2 .8-2 1.9V8c0 1.1.8 2 1.9 2H8c1.1 0 2-.8 2-1.9V8c0-1.1-.8-2-2-2 .1 0 0 0 0 0z"
                               />
                               <title>
-                                open and close list of options
+                                Settings
                               </title>
                             </svg>
                           </Icon>
diff --git a/packages/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarMenu-test.js.snap b/packages/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarMenu-test.js.snap
index a8504a0d5e3e..6c5af9ef52bd 100644
--- a/packages/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarMenu-test.js.snap
+++ b/packages/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarMenu-test.js.snap
@@ -12,8 +12,10 @@ exports[`DataTable.TableToolbarMenu should render 1`] = `
   }
 >
   <ForwardRef(OverflowMenu)
+    ariaLabel="Add"
     className="custom-class bx--toolbar-action bx--overflow-menu"
     flipped={true}
+    iconDescription="Add"
     renderIcon={
       Object {
         "$$typeof": Symbol(react.forward_ref),
@@ -23,11 +25,11 @@ exports[`DataTable.TableToolbarMenu should render 1`] = `
     title="Add"
   >
     <OverflowMenu
-      ariaLabel="Menu"
+      ariaLabel="Add"
       className="custom-class bx--toolbar-action bx--overflow-menu"
       direction="bottom"
       flipped={true}
-      iconDescription="open and close list of options"
+      iconDescription="Add"
       innerRef={null}
       light={false}
       menuOffset={[Function]}
@@ -52,7 +54,7 @@ exports[`DataTable.TableToolbarMenu should render 1`] = `
         <button
           aria-expanded={false}
           aria-haspopup={true}
-          aria-label="Menu"
+          aria-label="Add"
           className="custom-class bx--toolbar-action bx--overflow-menu bx--overflow-menu"
           onClick={[Function]}
           onClose={[Function]}
@@ -62,14 +64,14 @@ exports[`DataTable.TableToolbarMenu should render 1`] = `
           title="Add"
         >
           <ForwardRef(Download16)
-            aria-label="open and close list of options"
+            aria-label="Add"
             className="bx--overflow-menu__icon"
             focusable="false"
             onClick={[Function]}
             onKeyDown={[Function]}
           >
             <Icon
-              aria-label="open and close list of options"
+              aria-label="Add"
               className="bx--overflow-menu__icon"
               focusable="false"
               height={16}
@@ -81,7 +83,7 @@ exports[`DataTable.TableToolbarMenu should render 1`] = `
               xmlns="http://www.w3.org/2000/svg"
             >
               <svg
-                aria-label="open and close list of options"
+                aria-label="Add"
                 className="bx--overflow-menu__icon"
                 focusable="false"
                 height={16}
@@ -102,7 +104,7 @@ exports[`DataTable.TableToolbarMenu should render 1`] = `
                   d="M13 7l-.7-.7-3.8 3.8V1h-1v9.1L3.7 6.3 3 7l5 5zm0 5v2H3v-2H2v2c0 .6.4 1 1 1h10c.6 0 1-.4 1-1v-2h-1z"
                 />
                 <title>
-                  open and close list of options
+                  Add
                 </title>
               </svg>
             </Icon>