Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional VRT for Buttons #9265

Closed
4 tasks
Tracked by #8911
tay1orjones opened this issue Jul 23, 2021 · 0 comments
Closed
4 tasks
Tracked by #8911

Additional VRT for Buttons #9265

tay1orjones opened this issue Jul 23, 2021 · 0 comments

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Jul 23, 2021 •
edited
Loading

This issue is to implement visual regression testing (VRT) for the following components by adding baseline Percy snapshot(s) inside a *-test.e2e.js file. More info and high level steps to complete can be found in the issue, #8911

The Button had an initial set of snapshots added in #8958 but these other components were missed and should be double checked to see if they need snapshots or are already covered.

  • ButtonSkeleton
  • DangerButton
  • PrimaryButton
  • SecondaryButton
@tay1orjones tay1orjones mentioned this issue Jul 23, 2021
Closed
56 tasks
@sstrubberg sstrubberg closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2022
@sstrubberg sstrubberg moved this to ✅ Done in Design System Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Design System
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tay1orjones @sstrubberg