Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra space in 3 button modal footer #9117

Closed
2 tasks done
weaseldotro opened this issue Jul 6, 2021 · 1 comment
Closed
2 tasks done

Extra space in 3 button modal footer #9117

weaseldotro opened this issue Jul 6, 2021 · 1 comment

Comments

@weaseldotro
Copy link

weaseldotro commented Jul 6, 2021

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Link to storybook

When using the 3 button modal, there is some extra space to the left of the footer. It looks like there should be 4 buttons, but there are only 3, and the first button is missing.
I think the buttons should span all the available space, with each button having a width of 33.33%, so it would be consistent with the looks of the 2 button modal. Now this looks like those blank switches you see in cars who have some missing options.

I read the component guidance for modals https://carbondesignsystem.com/components/modal/usage/ and the PR #7775 but it doesn't say anything about the reasoning of this situation. I'm guessing it's because of symmetry, so that there's a clear distinction where the half point of the footer is?

On a phone this looks particularly bad, the first button container is squeezed so there is just some blank space at the left of the modal footer.

9BE072DC-39C9-4E6D-8C39-3BF3AB108743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants