-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update size
prop in components to use consistent terms for size
#8151
Comments
I don't think will be an issue and t-shirt sizes are more concise |
List of components that use the size prop:
Questions:
|
@tw15egan great questions, I'm down for @aagonzales what would you recommend for TJ's questions above for |
@joshblack looking into it a bit more, it seems like we should be good just sticking with the current t-shirt sizes vs. the full name. This will also give us a bit more flexibility for adding |
All changes have been made with the exceptions for the following components:
|
Closed for #8370 |
Currently size in component code are:
But should be:
This issue is for updating the API of components that accept a
size
prop to follow this convention. If it's possible, it would be preferred to add these options in as part of the existing API and deprecate existing options before we remove them in v11.The text was updated successfully, but these errors were encountered: