Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ~25% of components to use new design tokens #8149

Closed
joshblack opened this issue Mar 22, 2021 · 3 comments · Fixed by #8425
Closed

Update ~25% of components to use new design tokens #8149

joshblack opened this issue Mar 22, 2021 · 3 comments · Fixed by #8425
Assignees
@tw15egan @jnm2377
Labels
package: components carbon-components
Milestone
2021 Alpha Release

Comments

@joshblack
Copy link
Contributor

As part of #8148, this issue is responsible for taking the first step in updating our components to use the new design tokens. There are probably several strategies that we could follow to implement this, including:

  • Add new tokens to the existing themes and have them fallback to the current tokens
  • Add new tokens to the existing themes and then toggle usage based on feature flags in the component scss files

It is up to the implementors to figure out which approach will work best going into this release for our team 👀
@joshblack joshblack added the package: components carbon-components label Mar 22, 2021
@joshblack joshblack added this to the 2021 Alpha Release milestone Mar 22, 2021
@joshblack joshblack changed the title Update 25-50% of components to use new design tokens Update ~25% of components to use new design tokens Mar 22, 2021
@joshblack joshblack mentioned this issue Mar 22, 2021
Closed
86 tasks
@tw15egan tw15egan mentioned this issue Mar 30, 2021
Closed
@tw15egan
Copy link
Collaborator

tw15egan commented Mar 30, 2021 •
edited by jnm2377
Loading

Components to update:

Josefina

  • Accordion
  • Breadcrumb
  • Button
  • Checkbox
  • CodeSnippet
  • ComboBox

TJ

  • ContentSwitcher
  • ContextMenu
  • CopyButton
  • DataTable
  • DatePicker
  • Dropdown

@tw15egan
Copy link
Collaborator

Will need to wait for #8238 before starting this

@jnm2377 jnm2377 mentioned this issue Mar 30, 2021
Merged
@tw15egan
Copy link
Collaborator

Component token spec: #8187

@joshblack joshblack mentioned this issue Apr 5, 2021
Closed
This was referenced Apr 5, 2021
Merged
Closed
@jnm2377 jnm2377 mentioned this issue Apr 15, 2021
Merged
@kodiakhq kodiakhq bot closed this as completed in #8425 Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tw15egan tw15egan

@jnm2377 jnm2377

Labels
package: components carbon-components
Projects
None yet
Milestone
2021 Alpha Release
Development

Successfully merging a pull request may close this issue.

feat(Components): update color tokens (1/2) jnm2377/carbon
3 participants
@joshblack @tw15egan @jnm2377