Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colour contrast problem for Carbon tag component #6997

Closed
KJaspers opened this issue Oct 8, 2020 · 8 comments
Closed

Colour contrast problem for Carbon tag component #6997

KJaspers opened this issue Oct 8, 2020 · 8 comments

Comments

@KJaspers
Copy link

KJaspers commented Oct 8, 2020

Our colour contrast analyser found the following problem for the Carbon tag component (kind=purple):

Screenshot 2020-10-08 at 08 33 37

@tw15egan
Copy link
Collaborator

tw15egan commented Oct 8, 2020

cc @carbon-design-system/design

@laurenmrice
Copy link
Member

For the purple tag:
-The text color is Purple 70 (#6929C4)
-The background color is Purple 20 (#E8DAFF)

This combination does pass WCAG AA. I think you may have the wrong hex value for the text color (#695CD5)

@laurenmrice
Copy link
Member

Its a bug in react which we need to update to the above ^

@tw15egan
Copy link
Collaborator

tw15egan commented Oct 8, 2020

@laurenmrice that's what we currently have in React

Screen Shot 2020-10-08 at 12 22 02 PM

@laurenmrice
Copy link
Member

Oh, you are right ! Doing some further investigation, I looked at this in Firefox/Chrome/Safari, the Firefox browser is making the colors show up differently (almost a warmer color).
Artboard
.

@KJaspers
Copy link
Author

KJaspers commented Oct 9, 2020

BTW: We are using the Carbon Vue.js library.

@joshblack
Copy link
Contributor

Is there a good way to reproduce the issue? Tried using FF's built-in contrast checker as well and saw what seems to be the correct values:

Screen Shot 2020-10-19 at 11 38 55

@tw15egan
Copy link
Collaborator

tw15egan commented Feb 4, 2021

Closing this out, contrast values were increased in this PR: #7262

@tw15egan tw15egan closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants