Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToggleSmall should be a variant of toggle #6653

Closed
vpicone opened this issue Aug 12, 2020 · 1 comment · Fixed by #7380
Closed

ToggleSmall should be a variant of toggle #6653

vpicone opened this issue Aug 12, 2020 · 1 comment · Fixed by #7380
Assignees
@tw15egan
Labels
component: toggle role: dev 🤖 type: enhancement 💡

Comments

@vpicone
Copy link
Contributor

vpicone commented Aug 12, 2020

Ala button

motivation: This is what props are best used for. We should stick to the pattern of using kind/size prop rather than creating a whole new component.
This was referenced Nov 19, 2020
Open
Merged
@brandones brandones mentioned this issue Nov 20, 2020
Closed
2 tasks
@tw15egan tw15egan self-assigned this Nov 23, 2020
@tw15egan tw15egan mentioned this issue Dec 1, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #7380 Dec 4, 2020
@vpicone
Copy link
Contributor Author

vpicone commented Dec 4, 2020

Bless you @tw15egan

@emyarod emyarod mentioned this issue Feb 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tw15egan tw15egan

Labels
component: toggle role: dev 🤖 type: enhancement 💡
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(toggle): convert ToggleSmall to a variant of Toggle tw15egan/carbon
3 participants
@vpicone @tw15egan @laurenmrice