Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVT1: Orphan content violation in Tooltip #6308

Closed
xiepingp opened this issue Jun 18, 2020 · 22 comments
Closed

AVT1: Orphan content violation in Tooltip #6308

xiepingp opened this issue Jun 18, 2020 · 22 comments
Assignees
Labels

Comments

@xiepingp
Copy link

xiepingp commented Jun 18, 2020

Moving from: alchemy-containers/argonauts-ui#1176

=====ENVIRONMENT=====
Browser: Chrome
DAP tool (version is 1.8.0.0) with "IBM Accessibility January 2020" and "IBM Accessibility Experimental" supported rulesets.

=====STEPS TO REPRODUCE=====
Go to https://cloud.ibm.com/observe/ -> click "Create new" button (LogDNA or Sysdig or Activitytracker)
LogDNA: on LogDNA instance creation page, click tooltip icon besides 'Select a resource group' or besides 'Tags'
Sysdig: on Sysdig instance creation page, click tooltip icon besides 'Select a resource group' or besides 'Tags'
Activitytracker: on Activitytracker instance creation page, click tooltip icon besides 'Select a resource group' or besides 'Tags'

=====DEFECT DESCRIPTION=====
Issue: Orphan content found that does not reside within a WAI-ARIA landmark or labelled region role.

=====EXPECTED RESULT=====
https://aat.w3ibm.mybluemix.net/token/ffe6145a-21af-417b-b1c1-a34e72f4ac64/d9578cd4-659f-48de-a06f-1ad6eb41766c/archives/2020JanDeploy//doc/w3/help/en-US/idhi_accessibility_check_g1157.html

LogDNA:
1176

catalog_services_ibm-log-analysis-with-logdna_tooltip

Sysdig:
catalog_services_ibm-cloud-monitoring-with-sysdig_tooltip

Activitytracker:
catalog_services_ibm-cloud-activity-tracker-with-logdna_tooltip

@joshblack
Copy link
Contributor

cc @dakahn how should we handle the portal/landmark violation from DAP? In the past we talked about this being a false positive, right?

@dakahn
Copy link
Contributor

dakahn commented Jun 24, 2020

@joshblack let me do some testing and reproduce this error. if memory serves me right it wasn't truly orphaned, yeah

@joshblack
Copy link
Contributor

@dakahn got it, let me know what you find!

@dakahn
Copy link
Contributor

dakahn commented Jul 22, 2020

So word back from HQ is we should maybe set role="region" on the tooltip dialog to get this error to go away. This does seem to be AC/DAP handling dialogs in a non-appy way, but I'm still waiting to hear more.

@dakahn
Copy link
Contributor

dakahn commented Sep 1, 2020

Running latest DAP/Accessibility Checker doesn't throw this error anymore.

@dakahn dakahn closed this as completed Sep 1, 2020
@xiepingp
Copy link
Author

xiepingp commented Sep 2, 2020

@dakahn , would you mind advising which carbon version fixes this issue?

@xiepingp
Copy link
Author

@dakahn, our dev is wondering which carbon version having this fix so that he could do the update accordingly. Could you please advise?

@mashenka123
Copy link

@dakahn Is it the carbon 10.17.0 which has the fix? Please kindly confirm, thank you!

@xiepingp
Copy link
Author

xiepingp commented Sep 16, 2020

The Orphan content violation in Tooltip has gone, but new violation appears on the same element
1176 - retest
1176 - retest  - details
Not sure it is a Carbon bug or not...
@flannanl fyi.

@flannanl
Copy link

flannanl commented Sep 16, 2020

Seems like the violation is from the <span> element in the tooltip. So I believe this is from carbon as well.

image

@dakahn
Copy link
Contributor

dakahn commented Sep 16, 2020

Reopening!

@dakahn dakahn reopened this Sep 16, 2020
@dakahn
Copy link
Contributor

dakahn commented Sep 16, 2020

I'm unable to recreate this issue on our end
image

@flannanl @xiepingp
Can you test and confirm you see this issue at this link so we can figure out if this is an AC bug, a bug in our implementation or yours.

@xiepingp
Copy link
Author

I didn't see the violation in the storybook either, @flannanl may you have a look?
Screen Shot 2020-09-17 at 10 06 06 AM

@flannanl
Copy link

The complaining element is coming from Tooltip component for sure. When the tooltip is closed, the span element will be removed. I am also seeing the same span element in the storybook, but somehow it is not complained in the storybook. What I found is that the tooltip element in the storybook is created in an iframe where the one in the Console page is a direct child element under the body.

image

@flannanl
Copy link

And the carbon-react version we picked up is v7.18.

@dakahn
Copy link
Contributor

dakahn commented Sep 18, 2020

I'm unable to recreate that on our docs site as well

could you update to latest 7.20?

@flannanl
Copy link

@dakahn I cannot move up carbon. The cloudPAL team controls when to move up the carbon version.

@dakahn
Copy link
Contributor

dakahn commented Sep 28, 2020

@flannanl let me know if you're able to recreate your bug on either linked page above. If not we can try and figure out what's happening in your code.

@flannanl
Copy link

@dakahn Yes, I'm still seeing it with 7.20

@flannanl
Copy link

image

@emyarod
Copy link
Member

emyarod commented Mar 23, 2021

I am unable to reproduce this error

image

image

@dakahn
Copy link
Contributor

dakahn commented Mar 30, 2021

Confirmed. No longer can reproduce. They might have updated the ruleset on us. Closing as resolved 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants