Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooltip] Performance issues #2774

Closed
2 tasks done
ggcatu opened this issue May 17, 2019 · 6 comments
Closed
2 tasks done

[Tooltip] Performance issues #2774

ggcatu opened this issue May 17, 2019 · 6 comments
Labels
component: tooltip severity: 3 https://ibm.biz/carbon-severity type: bug 🐛 version: 9 Issues pertaining to legacy Carbon

Comments

@ggcatu
Copy link

ggcatu commented May 17, 2019

[Tooltip] Performance issues

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.

Tooltip component it's creating performance issues in pages where there's multiple (lot) of instances of it.

Is this issue related to a specific component?

Tooltip Component

What did you expect to happen? What happened instead? What would you like to
see changed?

Not re-rendering, or committing changes, since no changes are made to the component itself.

What browser are you working in?

Google Chrome

What version of the Carbon Design System are you using?

"carbon-components": "^9.84.1"
"carbon-components-react": "^6.106.2"

Was able to reproduce it after upgrading to latest versions.

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

Saferpayments

Steps to reproduce the issue

  1. Create a component
  2. Add a bunch of tooltip components
  3. Suffer bad performance

In the sandbox, you can basically click on the checkbox, and you will see the response time it's really slow.
Sandbox: https://codesandbox.io/s/codesandbox-880jt

Additional information

Using the react profiler shows up a bunch of DOM commits done by the Tooltip component.

image

@asudoh
Copy link
Contributor

asudoh commented May 18, 2019

Hi @ggcatu thank you for reporting! While it looks that your finding indicates something that we need to fix, let me advise that hover-over user-interaction of <Tooltip> has been deprecated (removed in v10) and <TooltipDefition> seems much closer to your use case.

@dakahn dakahn added version: 9 Issues pertaining to legacy Carbon priority: low severity: 3 https://ibm.biz/carbon-severity labels May 20, 2019
@JSoet
Copy link

JSoet commented May 27, 2019

Hi @asudoh, any update on this, do you think this will be possibly fixed in the next month or two? We will not be able to upgrade to v10 before our next release due to the large number of design changes in it, but we are implementing a page which uses dozens of tooltips, like @ggcatu 's example and it's very noticeable...

@asudoh
Copy link
Contributor

asudoh commented May 27, 2019

Please be advised that <TooltipDefinition> and <TooltipIcon> are available in v9 as well.

@JSoet
Copy link

JSoet commented May 28, 2019

Hm, thanks for the info, maybe we will be able to use tooltip definition instead, it doesn't seem to have the same problem:
https://codesandbox.io/s/codesandbox-5z2k4

@tw15egan
Copy link
Collaborator

Might need to do something like we did with this fix: #5336

@emyarod
Copy link
Member

emyarod commented Feb 25, 2020

I believe this should now be resolved ref carbon-design-system/carbon-components-react#2424 #5363

@emyarod emyarod closed this as completed Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tooltip severity: 3 https://ibm.biz/carbon-severity type: bug 🐛 version: 9 Issues pertaining to legacy Carbon
Projects
None yet
Development

No branches or pull requests

8 participants