[Bug]: ComboBox downshiftProps after selecting a item is not emitting onChange event

[ashishkrz]

Package

@carbon/react

Browser

Chrome

Package version

1.72.0

React version

18.3.1

Description

There was an issue with Combobox with downshiftProps, which got fixed here #17027. But now the issue is , after the item gets selected from combobox, the onChange event is not happening.

Reproduction/example

https://stackblitz.com/edit/github-v56j87-igdhfb?file=src%2FApp.jsx

Steps to reproduce

Try selecting item from combobox, observe the onChange is not getting called after a selection:

onChange={(e) => { console.info('HELLO', e); }}

Suggested Severity

Severity 2 = User cannot complete task, and/or no workaround within the user experience of a given component.

Application/PAL

Power Virtual Server UI (PowerVS)

Code of Conduct

• I agree to follow this project's Code of Conduct
• I checked the current issues for duplicate problems

[2nikhiltom]

Hey, do you see this issue on 1.72.0?, the stackblitz you shared is on 1.71.1

[ashishkrz]

@2nikhiltom I updated the package there, please check. The issue exist on 1.72.0.

[ashishkrz]

@2nikhiltom Do we have any update on same?

[cknabe]

@Neues I think this is related to your change here: #18041

Passing in onStateChange in downshiftProps is overriding the onStateChange passed into useCombobox. The reason this breaks, is because onChange was moved from onInputValueChange and onSelectedItemChange into the new onStateChange.

I reverted the changes in 18041 locally and everything works as expected.

Without digging further into it, I guess there are a number of possibilities:

1. @ashishkrz or anyone else overriding onStateChange, can call onChange in their overriden code
2. A solution could be found where onChange is called outside of onStateChange
3. Revert 18041 and find a different solution for that issue

[Neues]

@cknabe Thanks for the tag and the detailed description of the issue. The solution that I came up with is to call downshiftProps.onStateChange within the existing onStateChange so that the onChange continues to work as expected. Let me know what you think.
#18441