[Bug]: TypeScript: TableToolbarMenuProps.iconDescription is required

[lewandom]

Package

@carbon/react

Browser

No response

Package version

1.28.0

React version

No response

Description

When using TableToolbarMenu component in a TypeScript project, the iconDescription prop must be provided:

Type error: Property 'iconDescription' is missing in type '{ children: Element[]; }' but required in type 'TableToolbarMenuProps'.

While it is really a required prop in PropTypes, it does have a default value in defaultProps. Therefore, to keep same usage of this component between JS and TS, it'd be better to make it optional in TableToolbarMenuProps and set a default value when destructuring functional component props.

Raising this as a bug despite this probably would be covered by #13424, because it actually errors out in real life usage.

Reproduction/example

See below

Steps to reproduce

Simply create use the component in a TypeScript project without any props:

<TableToolbarMenu>
   ...
</TableToolbarMenu>

Suggested Severity

None

Application/PAL

No response

Code of Conduct

• I agree to follow this project's Code of Conduct
• I checked the current issues for duplicate problems

[lewandom]

A similar problem exists for TableHeader.scope property.

[tay1orjones]

@lewandom thanks for catching this, I agree. Anywhere a prop is marked required but has a default like this should not be required and the default provided through default function params.