Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Light prop not working on dropdowns #12956

Closed
2 tasks done
kglickman opened this issue Jan 10, 2023 · 1 comment · Fixed by #12984
Closed
2 tasks done

[Bug]: Light prop not working on dropdowns #12956

kglickman opened this issue Jan 10, 2023 · 1 comment · Fixed by #12984

Comments

@kglickman
Copy link

kglickman commented Jan 10, 2023

Package

@carbon/react

Browser

No response

Package version

1.20.0

React version

16.14.0

Description

We are using the "light" prop on many fields and are not ready to deal with <Layer> yet. However, "light" isn't working on DropDown, ComboBox and MultSelect fields. The styles used to reference field02 and now they are referencing field01 instead.

Suggested Severity

Severity 4 = Unrelated to a user task, has a workaround or does not need a workaround.

Reproduction/example

https://stackblitz.com/edit/github-r4v9a1

Steps to reproduce

Note that the ComboBox and the DropDown input boxes should have a gray background. The TextInput and TextArea work correctly.

Code of Conduct

@kglickman kglickman changed the title [Bug]: [Bug]: Light prop not working on dropdowns Jan 10, 2023
@tay1orjones
Copy link
Member

tay1orjones commented Jan 17, 2023

Thanks for reporting! The light prop is also not working for Tiles, and Select it seems. The classes are being applied, but the styling is incorrect.

https://stackblitz.com/edit/github-uy9avp-mg1evl?file=src%2FApp.jsx

@tay1orjones tay1orjones added severity: 3 https://ibm.biz/carbon-severity and removed status: needs triage 🕵️‍♀️ labels Jan 17, 2023
@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System Jan 17, 2023
@tw15egan tw15egan self-assigned this Jan 17, 2023
@tw15egan tw15egan moved this from ⏱ Backlog to 🏗 In Progress in Design System Jan 17, 2023
@tay1orjones tay1orjones added this to the 2023 Q1 milestone Jan 18, 2023
@kodiakhq kodiakhq bot closed this as completed in #12984 Jan 18, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in Design System Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants